* [PATCH -next] rtc: sd3078: make symbol 'sd3078_driver' static
@ 2019-01-16 3:01 Wei Yongjun
2019-01-22 16:53 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2019-01-16 3:01 UTC (permalink / raw)
To: Dianlong Li, Alessandro Zummo, Alexandre Belloni
Cc: Wei Yongjun, linux-rtc, kernel-janitors
Fixes the following sparse warning:
drivers/rtc/rtc-sd3078.c:218:19: warning:
symbol 'sd3078_driver' was not declared. Should it be static?
Fixes: 1d67a232105b ("rtc: sd3078: new driver.")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/rtc/rtc-sd3078.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-sd3078.c b/drivers/rtc/rtc-sd3078.c
index a70d7311..704844f 100644
--- a/drivers/rtc/rtc-sd3078.c
+++ b/drivers/rtc/rtc-sd3078.c
@@ -215,7 +215,7 @@ static int sd3078_probe(struct i2c_client *client,
};
MODULE_DEVICE_TABLE(of, rtc_dt_match);
-struct i2c_driver sd3078_driver = {
+static struct i2c_driver sd3078_driver = {
.driver = {
.name = "sd3078",
.owner = THIS_MODULE,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] rtc: sd3078: make symbol 'sd3078_driver' static
2019-01-16 3:01 [PATCH -next] rtc: sd3078: make symbol 'sd3078_driver' static Wei Yongjun
@ 2019-01-22 16:53 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2019-01-22 16:53 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Dianlong Li, Alessandro Zummo, linux-rtc, kernel-janitors
On 16/01/2019 03:01:21+0000, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/rtc/rtc-sd3078.c:218:19: warning:
> symbol 'sd3078_driver' was not declared. Should it be static?
>
> Fixes: 1d67a232105b ("rtc: sd3078: new driver.")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/rtc/rtc-sd3078.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-22 16:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-16 3:01 [PATCH -next] rtc: sd3078: make symbol 'sd3078_driver' static Wei Yongjun
2019-01-22 16:53 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).