* [PATCH 1/2] rtc: goldfish: Use correct return value for goldfish_rtc_probe()
@ 2020-05-25 1:39 Tiezhu Yang
2020-05-25 1:39 ` [PATCH 2/2] rtc: mpc5121: Use correct return value for mpc5121_rtc_probe() Tiezhu Yang
2020-05-30 1:32 ` [PATCH 1/2] rtc: goldfish: Use correct return value for goldfish_rtc_probe() Alexandre Belloni
0 siblings, 2 replies; 3+ messages in thread
From: Tiezhu Yang @ 2020-05-25 1:39 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni
Cc: linux-rtc, linux-kernel, Xuefeng Li, Tiezhu Yang
When call function devm_platform_ioremap_resource(), we should use IS_ERR()
to check the return value and return PTR_ERR() if failed.
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/rtc/rtc-goldfish.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-goldfish.c b/drivers/rtc/rtc-goldfish.c
index cb6b0ad..2779715 100644
--- a/drivers/rtc/rtc-goldfish.c
+++ b/drivers/rtc/rtc-goldfish.c
@@ -174,7 +174,7 @@ static int goldfish_rtc_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, rtcdrv);
rtcdrv->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(rtcdrv->base))
- return -ENODEV;
+ return PTR_ERR(rtcdrv->base);
rtcdrv->irq = platform_get_irq(pdev, 0);
if (rtcdrv->irq < 0)
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] rtc: mpc5121: Use correct return value for mpc5121_rtc_probe()
2020-05-25 1:39 [PATCH 1/2] rtc: goldfish: Use correct return value for goldfish_rtc_probe() Tiezhu Yang
@ 2020-05-25 1:39 ` Tiezhu Yang
2020-05-30 1:32 ` [PATCH 1/2] rtc: goldfish: Use correct return value for goldfish_rtc_probe() Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Tiezhu Yang @ 2020-05-25 1:39 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni
Cc: linux-rtc, linux-kernel, Xuefeng Li, Tiezhu Yang
When call function devm_platform_ioremap_resource(), we should use IS_ERR()
to check the return value and return PTR_ERR() if failed.
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
drivers/rtc/rtc-mpc5121.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-mpc5121.c b/drivers/rtc/rtc-mpc5121.c
index 3040844..5c2ce71 100644
--- a/drivers/rtc/rtc-mpc5121.c
+++ b/drivers/rtc/rtc-mpc5121.c
@@ -316,7 +316,7 @@ static int mpc5121_rtc_probe(struct platform_device *op)
rtc->regs = devm_platform_ioremap_resource(op, 0);
if (IS_ERR(rtc->regs)) {
dev_err(&op->dev, "%s: couldn't map io space\n", __func__);
- return -ENOSYS;
+ return PTR_ERR(rtc->regs);
}
device_init_wakeup(&op->dev, 1);
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] rtc: goldfish: Use correct return value for goldfish_rtc_probe()
2020-05-25 1:39 [PATCH 1/2] rtc: goldfish: Use correct return value for goldfish_rtc_probe() Tiezhu Yang
2020-05-25 1:39 ` [PATCH 2/2] rtc: mpc5121: Use correct return value for mpc5121_rtc_probe() Tiezhu Yang
@ 2020-05-30 1:32 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2020-05-30 1:32 UTC (permalink / raw)
To: Alessandro Zummo, Tiezhu Yang
Cc: Alexandre Belloni, linux-rtc, Xuefeng Li, linux-kernel
On Mon, 25 May 2020 09:39:47 +0800, Tiezhu Yang wrote:
> When call function devm_platform_ioremap_resource(), we should use IS_ERR()
> to check the return value and return PTR_ERR() if failed.
Applied, thanks!
[1/2] rtc: goldfish: Use correct return value for goldfish_rtc_probe()
commit: e712bb5c45313b3ab35ece2fb0a44cdc49548bd9
[2/2] rtc: mpc5121: Use correct return value for mpc5121_rtc_probe()
commit: 4c2a13a2d686a7412d862802156eebd0e15df7ad
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-30 1:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-25 1:39 [PATCH 1/2] rtc: goldfish: Use correct return value for goldfish_rtc_probe() Tiezhu Yang
2020-05-25 1:39 ` [PATCH 2/2] rtc: mpc5121: Use correct return value for mpc5121_rtc_probe() Tiezhu Yang
2020-05-30 1:32 ` [PATCH 1/2] rtc: goldfish: Use correct return value for goldfish_rtc_probe() Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).