linux-rtc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] rtc: rv3028: add the missed check for devm_regmap_init_i2c
@ 2020-05-27 15:07 Chuhong Yuan
  2020-05-30  1:56 ` Alexandre Belloni
  0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2020-05-27 15:07 UTC (permalink / raw)
  Cc: Alessandro Zummo, Alexandre Belloni, linux-rtc, linux-kernel,
	Chuhong Yuan

rv3028_probe() misses a check for devm_regmap_init_i2c().
Add the missed check to fix it.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
 drivers/rtc/rtc-rv3028.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/rtc/rtc-rv3028.c b/drivers/rtc/rtc-rv3028.c
index a0ddc86c975a..ec84db0b3d7a 100644
--- a/drivers/rtc/rtc-rv3028.c
+++ b/drivers/rtc/rtc-rv3028.c
@@ -755,6 +755,8 @@ static int rv3028_probe(struct i2c_client *client)
 		return -ENOMEM;
 
 	rv3028->regmap = devm_regmap_init_i2c(client, &regmap_config);
+	if (IS_ERR(rv3028->regmap))
+		return PTR_ERR(rv3028->regmap);
 
 	i2c_set_clientdata(client, rv3028);
 
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] rtc: rv3028: add the missed check for devm_regmap_init_i2c
  2020-05-27 15:07 [PATCH] rtc: rv3028: add the missed check for devm_regmap_init_i2c Chuhong Yuan
@ 2020-05-30  1:56 ` Alexandre Belloni
  0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2020-05-30  1:56 UTC (permalink / raw)
  To: Chuhong Yuan; +Cc: Alexandre Belloni, linux-rtc, linux-kernel, Alessandro Zummo

On Wed, 27 May 2020 23:07:04 +0800, Chuhong Yuan wrote:
> rv3028_probe() misses a check for devm_regmap_init_i2c().
> Add the missed check to fix it.

Applied, thanks!

[1/1] rtc: rv3028: add the missed check for devm_regmap_init_i2c

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@bootlin.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-30  1:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-27 15:07 [PATCH] rtc: rv3028: add the missed check for devm_regmap_init_i2c Chuhong Yuan
2020-05-30  1:56 ` Alexandre Belloni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).