From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Huacai Chen <chenhc@lemote.com>,
Miodrag Dinic <miodrag.dinic@mips.com>,
Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Huacai Chen <chenhuacai@gmail.com>,
linux-rtc@vger.kernel.org, Jiaxun Yang <jiaxun.yang@flygoat.com>,
Fuxin Zhang <zhangfx@lemote.com>
Subject: Re: [PATCH] rtc: goldfish: Enable interrupt in set_alarm() when necessary
Date: Thu, 16 Jul 2020 11:16:32 +0200 [thread overview]
Message-ID: <159489095984.8950.1847922720738517417.b4-ty@bootlin.com> (raw)
In-Reply-To: <1592654683-31314-1-git-send-email-chenhc@lemote.com>
On Sat, 20 Jun 2020 20:04:43 +0800, Huacai Chen wrote:
> When use goldfish rtc, the "hwclock" command fails with "select() to
> /dev/rtc to wait for clock tick timed out". This is because "hwclock"
> need the set_alarm() hook to enable interrupt when alrm->enabled is
> true. This operation is missing in goldfish rtc (but other rtc drivers,
> such as cmos rtc, enable interrupt here), so add it.
Applied, thanks!
[1/1] rtc: goldfish: Enable interrupt in set_alarm() when necessary
commit: 22f8d5a1bf230cf8567a4121fc3789babb46336d
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
prev parent reply other threads:[~2020-07-16 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 12:04 [PATCH] rtc: goldfish: Enable interrupt in set_alarm() when necessary Huacai Chen
2020-07-03 3:00 ` Huacai Chen
2020-07-09 9:39 ` Huacai Chen
2020-07-09 10:30 ` Miodrag Dinic
2020-07-16 9:16 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159489095984.8950.1847922720738517417.b4-ty@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=chenhc@lemote.com \
--cc=chenhuacai@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-rtc@vger.kernel.org \
--cc=miodrag.dinic@mips.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).