From: Huacai Chen <chenhuacai@gmail.com>
To: Miodrag Dinic <miodrag.dinic@mips.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, Fuxin Zhang <zhangfx@lemote.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH] rtc: goldfish: Enable interrupt in set_alarm() when necessary
Date: Fri, 3 Jul 2020 11:00:54 +0800 [thread overview]
Message-ID: <CAAhV-H4iaAdxQD8GYYAZAusS+-dD6APy=jUMXm0QpdOXNS_N_Q@mail.gmail.com> (raw)
In-Reply-To: <1592654683-31314-1-git-send-email-chenhc@lemote.com>
Ping?
On Sat, Jun 20, 2020 at 8:03 PM Huacai Chen <chenhc@lemote.com> wrote:
>
> When use goldfish rtc, the "hwclock" command fails with "select() to
> /dev/rtc to wait for clock tick timed out". This is because "hwclock"
> need the set_alarm() hook to enable interrupt when alrm->enabled is
> true. This operation is missing in goldfish rtc (but other rtc drivers,
> such as cmos rtc, enable interrupt here), so add it.
>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> drivers/rtc/rtc-goldfish.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rtc/rtc-goldfish.c b/drivers/rtc/rtc-goldfish.c
> index 1a3420e..d5083b0 100644
> --- a/drivers/rtc/rtc-goldfish.c
> +++ b/drivers/rtc/rtc-goldfish.c
> @@ -73,6 +73,7 @@ static int goldfish_rtc_set_alarm(struct device *dev,
> rtc_alarm64 = rtc_tm_to_time64(&alrm->time) * NSEC_PER_SEC;
> writel((rtc_alarm64 >> 32), base + TIMER_ALARM_HIGH);
> writel(rtc_alarm64, base + TIMER_ALARM_LOW);
> + writel(1, base + TIMER_IRQ_ENABLED);
> } else {
> /*
> * if this function was called with enabled=0
> --
> 2.7.0
>
next prev parent reply other threads:[~2020-07-03 3:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 12:04 [PATCH] rtc: goldfish: Enable interrupt in set_alarm() when necessary Huacai Chen
2020-07-03 3:00 ` Huacai Chen [this message]
2020-07-09 9:39 ` Huacai Chen
2020-07-09 10:30 ` Miodrag Dinic
2020-07-16 9:16 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAhV-H4iaAdxQD8GYYAZAusS+-dD6APy=jUMXm0QpdOXNS_N_Q@mail.gmail.com' \
--to=chenhuacai@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-rtc@vger.kernel.org \
--cc=miodrag.dinic@mips.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).