* [PATCH] rtc: omap: include header for omap_rtc_power_off_program prototype
@ 2023-03-11 9:40 Krzysztof Kozlowski
2023-03-17 22:24 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-11 9:40 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, Tony Lindgren, Keerthy,
linux-rtc, linux-kernel
Cc: Krzysztof Kozlowski
Non-static functions should have a prototype:
drivers/rtc/rtc-omap.c:410:5: error: no previous prototype for ‘omap_rtc_power_off_program’ [-Werror=missing-prototypes]
Fixes: 6256f7f7f217 ("rtc: OMAP: Add support for rtc-only mode")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/rtc/rtc-omap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
index 4d4f3b1a7309..73634a3ccfd3 100644
--- a/drivers/rtc/rtc-omap.c
+++ b/drivers/rtc/rtc-omap.c
@@ -25,6 +25,7 @@
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
#include <linux/rtc.h>
+#include <linux/rtc/rtc-omap.h>
/*
* The OMAP RTC is a year/month/day/hours/minutes/seconds BCD clock
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: omap: include header for omap_rtc_power_off_program prototype
2023-03-11 9:40 [PATCH] rtc: omap: include header for omap_rtc_power_off_program prototype Krzysztof Kozlowski
@ 2023-03-17 22:24 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2023-03-17 22:24 UTC (permalink / raw)
To: Alessandro Zummo, Tony Lindgren, Keerthy, linux-rtc,
linux-kernel, Krzysztof Kozlowski
On Sat, 11 Mar 2023 10:40:21 +0100, Krzysztof Kozlowski wrote:
> Non-static functions should have a prototype:
>
> drivers/rtc/rtc-omap.c:410:5: error: no previous prototype for ‘omap_rtc_power_off_program’ [-Werror=missing-prototypes]
>
>
Applied, thanks!
[1/1] rtc: omap: include header for omap_rtc_power_off_program prototype
commit: f69c2b5420497b7a54181ce170d682cbeb1f119f
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-17 22:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-11 9:40 [PATCH] rtc: omap: include header for omap_rtc_power_off_program prototype Krzysztof Kozlowski
2023-03-17 22:24 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).