* [PATCH] rtc: ds1390: mark OF related data as maybe unused
@ 2023-03-11 11:12 Krzysztof Kozlowski
2023-03-17 22:24 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-11 11:12 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni, linux-rtc, linux-kernel
Cc: Krzysztof Kozlowski
The driver can be compile tested with !CONFIG_OF making certain data
unused:
drivers/rtc/rtc-ds1390.c:216:34: error: ‘ds1390_of_match’ defined but not used [-Werror=unused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/rtc/rtc-ds1390.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-ds1390.c b/drivers/rtc/rtc-ds1390.c
index 93ce72b9ae59..f46428ca77cc 100644
--- a/drivers/rtc/rtc-ds1390.c
+++ b/drivers/rtc/rtc-ds1390.c
@@ -213,7 +213,7 @@ static int ds1390_probe(struct spi_device *spi)
return res;
}
-static const struct of_device_id ds1390_of_match[] = {
+static const struct of_device_id ds1390_of_match[] __maybe_unused = {
{ .compatible = "dallas,ds1390" },
{}
};
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: ds1390: mark OF related data as maybe unused
2023-03-11 11:12 [PATCH] rtc: ds1390: mark OF related data as maybe unused Krzysztof Kozlowski
@ 2023-03-17 22:24 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2023-03-17 22:24 UTC (permalink / raw)
To: Alessandro Zummo, linux-rtc, linux-kernel, Krzysztof Kozlowski
On Sat, 11 Mar 2023 12:12:26 +0100, Krzysztof Kozlowski wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
>
> drivers/rtc/rtc-ds1390.c:216:34: error: ‘ds1390_of_match’ defined but not used [-Werror=unused-const-variable=]
>
>
Applied, thanks!
[1/1] rtc: ds1390: mark OF related data as maybe unused
commit: cca1e2f790703bb22b56d94c5efc66c1d9517b21
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-17 22:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-11 11:12 [PATCH] rtc: ds1390: mark OF related data as maybe unused Krzysztof Kozlowski
2023-03-17 22:24 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).