* [PATCH] ARM: kirkwood: ts219: disable the SoC's RTC
@ 2019-07-23 19:45 Uwe Kleine-König
2019-07-23 20:03 ` Alexandre Belloni
2019-07-23 22:20 ` Andrew Lunn
0 siblings, 2 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2019-07-23 19:45 UTC (permalink / raw)
To: Alexandre Belloni, Alessandro Zummo
Cc: linux-rtc, linux-arm-kernel, tbm, Oliver Hartkopp, Andrew Lunn
The internal RTC doesn't work, loading the driver only yields
rtc-mv f1010300.rtc: internal RTC not ticking
. So disable it.
Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
---
arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi
index a88eb22070a1..994cabcf4b51 100644
--- a/arch/arm/boot/dts/kirkwood-ts219.dtsi
+++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi
@@ -104,3 +104,11 @@
&pcie0 {
status = "okay";
};
+
+&rtc {
+ /*
+ * There is a s35390a available on the i2c bus, the internal rtc isn't
+ * working (probably no crystal assembled).
+ */
+ status = "disabled";
+};
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: kirkwood: ts219: disable the SoC's RTC
2019-07-23 19:45 [PATCH] ARM: kirkwood: ts219: disable the SoC's RTC Uwe Kleine-König
@ 2019-07-23 20:03 ` Alexandre Belloni
2019-07-23 20:24 ` Uwe Kleine-König
2019-07-23 22:20 ` Andrew Lunn
1 sibling, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2019-07-23 20:03 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Alessandro Zummo, linux-rtc, linux-arm-kernel, tbm,
Oliver Hartkopp, Andrew Lunn
On 23/07/2019 21:45:05+0200, Uwe Kleine-König wrote:
> The internal RTC doesn't work, loading the driver only yields
>
> rtc-mv f1010300.rtc: internal RTC not ticking
>
> . So disable it.
>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> ---
> arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> index a88eb22070a1..994cabcf4b51 100644
> --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> @@ -104,3 +104,11 @@
> &pcie0 {
> status = "okay";
> };
> +
> +&rtc {
> + /*
> + * There is a s35390a available on the i2c bus, the internal rtc isn't
> + * working (probably no crystal assembled).
> + */
> + status = "disabled";
> +};
You could also use the aliases to ensure rtc0 is the s35390a. This would
solve the initial issue.
> --
> 2.20.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: kirkwood: ts219: disable the SoC's RTC
2019-07-23 20:03 ` Alexandre Belloni
@ 2019-07-23 20:24 ` Uwe Kleine-König
2019-07-24 8:57 ` Alexandre Belloni
0 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2019-07-23 20:24 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Alessandro Zummo, linux-rtc, linux-arm-kernel, tbm,
Oliver Hartkopp, Andrew Lunn
[-- Attachment #1.1: Type: text/plain, Size: 1176 bytes --]
On 7/23/19 10:03 PM, Alexandre Belloni wrote:
> On 23/07/2019 21:45:05+0200, Uwe Kleine-König wrote:
>> The internal RTC doesn't work, loading the driver only yields
>>
>> rtc-mv f1010300.rtc: internal RTC not ticking
>>
>> . So disable it.
>>
>> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
>> ---
>> arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi
>> index a88eb22070a1..994cabcf4b51 100644
>> --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi
>> +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi
>> @@ -104,3 +104,11 @@
>> &pcie0 {
>> status = "okay";
>> };
>> +
>> +&rtc {
>> + /*
>> + * There is a s35390a available on the i2c bus, the internal rtc isn't
>> + * working (probably no crystal assembled).
>> + */
>> + status = "disabled";
>> +};
>
> You could also use the aliases to ensure rtc0 is the s35390a. This would
> solve the initial issue.
What do you assume is my initial issue? Adding the alias doesn't make
the above message disappear from the boot log.
Best regards
Uwe
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: kirkwood: ts219: disable the SoC's RTC
2019-07-23 19:45 [PATCH] ARM: kirkwood: ts219: disable the SoC's RTC Uwe Kleine-König
2019-07-23 20:03 ` Alexandre Belloni
@ 2019-07-23 22:20 ` Andrew Lunn
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2019-07-23 22:20 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Alexandre Belloni, Alessandro Zummo, linux-rtc, linux-arm-kernel,
tbm, Oliver Hartkopp, Gregory Clement
On Tue, Jul 23, 2019 at 09:45:05PM +0200, Uwe Kleine-König wrote:
> The internal RTC doesn't work, loading the driver only yields
>
> rtc-mv f1010300.rtc: internal RTC not ticking
>
> . So disable it.
>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Hi Uwe
This should probably go via the mvebu maintainers, who look after the
DT files.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: kirkwood: ts219: disable the SoC's RTC
2019-07-23 20:24 ` Uwe Kleine-König
@ 2019-07-24 8:57 ` Alexandre Belloni
0 siblings, 0 replies; 5+ messages in thread
From: Alexandre Belloni @ 2019-07-24 8:57 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Alessandro Zummo, linux-rtc, linux-arm-kernel, tbm,
Oliver Hartkopp, Andrew Lunn
On 23/07/2019 22:24:18+0200, Uwe Kleine-König wrote:
> On 7/23/19 10:03 PM, Alexandre Belloni wrote:
> > On 23/07/2019 21:45:05+0200, Uwe Kleine-König wrote:
> >> The internal RTC doesn't work, loading the driver only yields
> >>
> >> rtc-mv f1010300.rtc: internal RTC not ticking
> >>
> >> . So disable it.
> >>
> >> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> >> ---
> >> arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++
> >> 1 file changed, 8 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> >> index a88eb22070a1..994cabcf4b51 100644
> >> --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi
> >> +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> >> @@ -104,3 +104,11 @@
> >> &pcie0 {
> >> status = "okay";
> >> };
> >> +
> >> +&rtc {
> >> + /*
> >> + * There is a s35390a available on the i2c bus, the internal rtc isn't
> >> + * working (probably no crystal assembled).
> >> + */
> >> + status = "disabled";
> >> +};
> >
> > You could also use the aliases to ensure rtc0 is the s35390a. This would
> > solve the initial issue.
>
> What do you assume is my initial issue? Adding the alias doesn't make
> the above message disappear from the boot log.
>
I overlooked that the rtc is not working at all (and I thought it only
needed some init in u-boot like the armada38x). Seems good to me then.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-24 8:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-23 19:45 [PATCH] ARM: kirkwood: ts219: disable the SoC's RTC Uwe Kleine-König
2019-07-23 20:03 ` Alexandre Belloni
2019-07-23 20:24 ` Uwe Kleine-König
2019-07-24 8:57 ` Alexandre Belloni
2019-07-23 22:20 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).