From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Biwen Li <biwen.li@nxp.com>
Cc: a.zummo@towertech.it, leoyang.li@nxp.com,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [v2] rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w
Date: Fri, 16 Aug 2019 10:04:17 +0200 [thread overview]
Message-ID: <20190816080417.GB3545@piout.net> (raw)
In-Reply-To: <20190816024636.34738-1-biwen.li@nxp.com>
On 16/08/2019 10:46:36+0800, Biwen Li wrote:
> Issue:
> - # hwclock -w
> hwclock: RTC_SET_TIME: Invalid argument
>
> Why:
> - Relative patch: https://lkml.org/lkml/2019/4/3/55 , this patch
> will always check for unwritable registers, it will compare reg
> with max_register in regmap_writeable.
>
> - In drivers/rtc/rtc-pcf85363.c, CTRL_STOP_EN is 0x2e, but DT_100THS
> is 0, max_regiter is 0x2f, then reg will be equal to 0x30,
> '0x30 < 0x2f' is false,so regmap_writeable will return false.
>
> - Root cause: the buf[] was written to a wrong place in the file
> drivers/rtc/rtc-pcf85363.c
>
This is not true, the RTC wraps the register accesses properly and this
is probably something that should be handled by regmap_writable.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-08-16 8:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 2:46 [v2] rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w Biwen Li
2019-08-16 8:04 ` Alexandre Belloni [this message]
2019-08-16 15:50 ` Li Yang
2019-08-16 16:28 ` Alexandre Belloni
2019-08-16 19:40 ` Li Yang
2019-08-20 18:22 ` Mark Brown
2019-08-20 18:33 ` Li Yang
2019-08-21 11:21 ` Mark Brown
2019-08-21 11:24 ` Alexandre Belloni
2019-08-21 11:30 ` Mark Brown
2019-08-21 11:38 ` Alexandre Belloni
2019-08-21 11:47 ` Mark Brown
2019-08-21 6:20 ` Nandor Han
2019-08-26 4:29 ` [EXT] " Biwen Li
2019-08-26 9:17 ` Nandor Han
2019-08-26 9:49 ` Biwen Li
2019-08-26 10:06 ` Alexandre Belloni
2019-08-26 10:40 ` Biwen Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816080417.GB3545@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=biwen.li@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).