From: Andreas Kemnade <andreas@kemnade.info>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Stefan Agner <stefan@agner.ch>,
lee.jones@linaro.org, a.zummo@towertech.it,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
phh@phh.me, b.galvani@gmail.com, letux-kernel@openphoenux.org
Subject: Re: [PATCH 5/5] rtc: rtc-rc5t583: add ricoh rc5t619 RTC driver
Date: Mon, 21 Oct 2019 17:20:55 +0200 [thread overview]
Message-ID: <20191021172055.2fa66549@kemnade.info> (raw)
In-Reply-To: <20191021135028.GV3125@piout.net>
[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]
On Mon, 21 Oct 2019 15:50:28 +0200
Alexandre Belloni <alexandre.belloni@bootlin.com> wrote:
> On 21/10/2019 15:19:09+0200, Stefan Agner wrote:
> > On 2019-10-21 07:41, Andreas Kemnade wrote:
> > > Add an RTC driver for the RTC device on Ricoh MFD rc5t619,
> > > which is implemented as a variant of rn5t618
> > >
> > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > > ---
> > > drivers/rtc/Kconfig | 10 +
> > > drivers/rtc/Makefile | 1 +
> > > drivers/rtc/rtc-rc5t619.c | 476 ++++++++++++++++++++++++++++++++++++++++++++++
> >
> > Parts of this driver look very similar to drivers/rtc/rtc-rc5t583.c. Can
> > it maybe shared?
> >
>
> If this could be done it would be better. I can't find any public
> datasheet though...
>
at least they have different alarm configurations, The rc5t619 can specify
alarm in seconds, the rc5t583 not but has other alarm configurations which
are not present in the rn5t619 (judging by the lack of unused registers where
thoes information could be filled in).
Register addresses do not match.
Some details seem to be the same like century flag.
Interestingly the rc5t583 driver does not care about 12h/24h mode.
So there is a bug there.
Regards,
Andreas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-10-21 15:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 5:40 [PATCH 0/5] Add rtc support for rn5t618 mfd Andreas Kemnade
2019-10-21 5:41 ` [PATCH 1/5] mfd: rn5t618: prepare for irq handling Andreas Kemnade
2019-10-21 5:41 ` [PATCH 2/5] mfd: rn5t618: add irq support Andreas Kemnade
2019-10-21 9:07 ` Alexandre Belloni
2019-10-21 15:06 ` Andreas Kemnade
2019-10-21 5:41 ` [PATCH 3/5] mfd: rn5t618: add rtc related registers Andreas Kemnade
2019-10-21 5:41 ` [PATCH 4/5] mfd: rn5t618: add more subdevices Andreas Kemnade
2019-10-21 5:41 ` [PATCH 5/5] rtc: rtc-rc5t583: add ricoh rc5t619 RTC driver Andreas Kemnade
2019-10-21 10:15 ` Alexandre Belloni
2019-10-21 10:31 ` [Letux-kernel] " H. Nikolaus Schaller
2019-10-21 15:09 ` Alexandre Belloni
2019-10-21 21:13 ` Andreas Kemnade
2019-10-23 23:17 ` Alexandre Belloni
2019-10-24 20:25 ` Andreas Kemnade
2019-10-24 22:06 ` Alexandre Belloni
2019-10-29 6:46 ` Andreas Kemnade
2019-10-21 13:19 ` Stefan Agner
2019-10-21 13:50 ` Alexandre Belloni
2019-10-21 15:20 ` Andreas Kemnade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021172055.2fa66549@kemnade.info \
--to=andreas@kemnade.info \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=b.galvani@gmail.com \
--cc=lee.jones@linaro.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=phh@phh.me \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).