Linux-RTC Archive on lore.kernel.org
 help / color / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
	mazziesaccount@gmail.com, Alessandro Zummo <a.zummo@towertech.it>,
	linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask
Date: Thu, 7 Nov 2019 18:38:59 +0100
Message-ID: <20191107173859.GR8309@piout.net> (raw)
In-Reply-To: <20191107112850.GP8309@piout.net>

On 07/11/2019 12:33:53+0100, Alexandre Belloni wrote:
> On 07/11/2019 10:59:49+0000, Lee Jones wrote:
> > On Tue, 05 Nov 2019, Alexandre Belloni wrote:
> > 
> > > On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > > > When RTC is used in 24H mode (and it is by this driver) the maximum
> > > > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > > > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> > > > 
> > > > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
> > > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > > > ---
> > > >  include/linux/mfd/rohm-bd70528.h | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > Applied, thanks.
> > 
> > You have been duped. This is clearly not an RTC patch.
> > 
> 
> Well, it only affects the RTC driver. Do you want to take it?
> 

I've removed it from rtc-next, up to you to take it.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 11:47 Matti Vaittinen
2019-11-05 16:53 ` Alexandre Belloni
2019-11-05 16:57   ` Alexandre Belloni
2019-11-05 18:13     ` Vaittinen, Matti
2019-11-07 10:59   ` Lee Jones
2019-11-07 11:28     ` Alexandre Belloni
2019-11-07 17:38       ` Alexandre Belloni [this message]
2019-11-07 11:46     ` Vaittinen, Matti

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191107173859.GR8309@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=a.zummo@towertech.it \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=mazziesaccount@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RTC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rtc/0 linux-rtc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rtc linux-rtc/ https://lore.kernel.org/linux-rtc \
		linux-rtc@vger.kernel.org
	public-inbox-index linux-rtc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rtc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git