* [PATCH 00/17] platform/chrome: Replace cros_ec_cmd_xfer_status
@ 2020-01-30 20:30 Prashant Malani
2020-01-30 20:31 ` [PATCH 14/17] rtc: cros-ec: Use cros_ec_send_cmd_msg() Prashant Malani
0 siblings, 1 reply; 2+ messages in thread
From: Prashant Malani @ 2020-01-30 20:30 UTC (permalink / raw)
To: linux-kernel
Cc: Prashant Malani, Akshu Agrawal, Alexandre Belloni,
moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
Benjamin Tissoires, Dmitry Torokhov, Enric Balletbo i Serra,
Evan Green, Fabien Lahoudere, Guenter Roeck, Gwendal Grignou,
Hans Verkuil, Hartmut Knaack, Jonathan Cameron,
Lars-Peter Clausen, Lee Jones,
open list:I2C SUBSYSTEM HOST DRIVERS,
open list:IIO SUBSYSTEM AND DRIVERS, open list:HID CORE LAYER,
open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB),
open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS,
open list:PWM SUBSYSTEM,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM, Mauro Carvalho Chehab,
Neil Armstrong, Nick Vaccaro, Peter Meerwald-Stadler,
Raul E Rangel, Uwe Kleine-König, Wolfram Sang
Many callers of cros_ec_cmd_xfer_status() use similar setup and cleanup
code, including setting up the cros_ec_command message struct and
copying the received buffer.
This series introduces a replacement function cros_ec_send_cmd_msg() that
performs this setup and teardown, and then updates all call sites that
used xfer_status() to use the new function instead.
The final patch in the series drops cros_ec_cmd_xfer_status() altogether.
Prashant Malani (17):
platform/chrome: Add EC command msg wrapper
platform/chrome: chardev: Use send_cmd_msg()
platform/chrome: proto: Use send_cmd_msg
platform/chrome: usbpd_logger: Use cmd_send_msg()
platform/chrome: sensorhub: Use send_cmd_msg()
platform/chrome: debugfs: Use send_cmd_msg()
platform/chrome: sysfs: Use send_cmd_msg()
extcon: cros_ec: Use cros_ec_send_cmd_msg()
hid: google-hammer: Use cros_ec_send_cmd_msg()
iio: cros_ec: Use cros_ec_send_cmd_msg()
ASoC: cros_ec_codec: Use cros_ec_send_cmd_msg()
power: supply: cros: Use cros_ec_send_cmd_msg()
pwm: cros-ec: Remove cros_ec_cmd_xfer_status()
rtc: cros-ec: Use cros_ec_send_cmd_msg()
media: cros-ec-cec: Use cros_ec_send_cmd_msg()
i2c: cros-ec-tunnel: Use cros_ec_send_cmd_msg()
platform/chrome: Drop cros_ec_cmd_xfer_status()
drivers/extcon/extcon-usbc-cros-ec.c | 62 ++------
drivers/hid/hid-google-hammer.c | 23 +--
drivers/i2c/busses/i2c-cros-ec-tunnel.c | 23 ++-
.../cros_ec_sensors/cros_ec_sensors_core.c | 43 +++---
.../media/platform/cros-ec-cec/cros-ec-cec.c | 39 ++---
drivers/platform/chrome/cros_ec_chardev.c | 18 +--
drivers/platform/chrome/cros_ec_debugfs.c | 135 ++++++------------
drivers/platform/chrome/cros_ec_proto.c | 75 ++++++----
drivers/platform/chrome/cros_ec_sensorhub.c | 29 ++--
drivers/platform/chrome/cros_ec_sysfs.c | 106 ++++++--------
drivers/platform/chrome/cros_usbpd_logger.c | 13 +-
drivers/power/supply/cros_usbpd-charger.c | 63 ++------
drivers/pwm/pwm-cros-ec.c | 27 ++--
drivers/rtc/rtc-cros-ec.c | 27 ++--
include/linux/platform_data/cros_ec_proto.h | 6 +-
sound/soc/codecs/cros_ec_codec.c | 71 +++------
16 files changed, 276 insertions(+), 484 deletions(-)
--
2.25.0.341.g760bfbb309-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 14/17] rtc: cros-ec: Use cros_ec_send_cmd_msg()
2020-01-30 20:30 [PATCH 00/17] platform/chrome: Replace cros_ec_cmd_xfer_status Prashant Malani
@ 2020-01-30 20:31 ` Prashant Malani
0 siblings, 0 replies; 2+ messages in thread
From: Prashant Malani @ 2020-01-30 20:31 UTC (permalink / raw)
To: linux-kernel
Cc: Prashant Malani, Alessandro Zummo, Alexandre Belloni,
Benson Leung, Enric Balletbo i Serra, Guenter Roeck,
open list:REAL TIME CLOCK (RTC) SUBSYSTEM
Replace cros_ec_cmd_xfer_status() with cros_ec_send_cmd_msg() which does
the message buffer setup and cleanup.
Signed-off-by: Prashant Malani <pmalani@chromium.org>
---
drivers/rtc/rtc-cros-ec.c | 27 ++++++++-------------------
1 file changed, 8 insertions(+), 19 deletions(-)
diff --git a/drivers/rtc/rtc-cros-ec.c b/drivers/rtc/rtc-cros-ec.c
index d043d30f05bc1d..113638a82e2c0c 100644
--- a/drivers/rtc/rtc-cros-ec.c
+++ b/drivers/rtc/rtc-cros-ec.c
@@ -34,16 +34,11 @@ static int cros_ec_rtc_get(struct cros_ec_device *cros_ec, u32 command,
u32 *response)
{
int ret;
- struct {
- struct cros_ec_command msg;
- struct ec_response_rtc data;
- } __packed msg;
- memset(&msg, 0, sizeof(msg));
- msg.msg.command = command;
- msg.msg.insize = sizeof(msg.data);
+ struct ec_response_rtc data = {0};
- ret = cros_ec_cmd_xfer_status(cros_ec, &msg.msg);
+ ret = cros_ec_send_cmd_msg(cros_ec, 0, command, NULL, 0,
+ &data, sizeof(data));
if (ret < 0) {
dev_err(cros_ec->dev,
"error getting %s from EC: %d\n",
@@ -52,7 +47,7 @@ static int cros_ec_rtc_get(struct cros_ec_device *cros_ec, u32 command,
return ret;
}
- *response = msg.data.time;
+ *response = data.time;
return 0;
}
@@ -61,17 +56,11 @@ static int cros_ec_rtc_set(struct cros_ec_device *cros_ec, u32 command,
u32 param)
{
int ret = 0;
- struct {
- struct cros_ec_command msg;
- struct ec_response_rtc data;
- } __packed msg;
+ struct ec_response_rtc data;
- memset(&msg, 0, sizeof(msg));
- msg.msg.command = command;
- msg.msg.outsize = sizeof(msg.data);
- msg.data.time = param;
-
- ret = cros_ec_cmd_xfer_status(cros_ec, &msg.msg);
+ data.time = param;
+ ret = cros_ec_send_cmd_msg(cros_ec, 0, command, &data, sizeof(data),
+ NULL, 0);
if (ret < 0) {
dev_err(cros_ec->dev, "error setting %s on EC: %d\n",
command == EC_CMD_RTC_SET_VALUE ? "time" : "alarm",
--
2.25.0.341.g760bfbb309-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-30 20:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-30 20:30 [PATCH 00/17] platform/chrome: Replace cros_ec_cmd_xfer_status Prashant Malani
2020-01-30 20:31 ` [PATCH 14/17] rtc: cros-ec: Use cros_ec_send_cmd_msg() Prashant Malani
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).