From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: a.zummo@towertech.it, wim@linux-watchdog.org, linux@roeck-us.net,
linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] rtc: ds1307: add support for watchdog timer on ds1388
Date: Mon, 30 Mar 2020 20:39:17 +0200 [thread overview]
Message-ID: <20200330183917.GG846876@piout.net> (raw)
In-Reply-To: <20200330025500.6991-1-chris.packham@alliedtelesis.co.nz>
On 30/03/2020 15:55:00+1300, Chris Packham wrote:
> The DS1388 variant has watchdog timer capabilities. When using a DS1388
> and having enabled CONFIG_WATCHDOG_CORE register a watchdog device for
> the DS1388.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> Changes in v3:
> - Address review comments from Guenter. Add select WATCHDOG_CORE, remove
> unnecessary wdt member, add set_timeout op, use devm_watchdog_register
> Changes in v2:
> - Address review comments from Alexandre, the only functional change is setting
> the hundredths of seconds to 0 instead of 99.
>
> drivers/rtc/Kconfig | 1 +
> drivers/rtc/rtc-ds1307.c | 115 +++++++++++++++++++++++++++++++++++++++
> 2 files changed, 116 insertions(+)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-03-30 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 2:55 [PATCH v3] rtc: ds1307: add support for watchdog timer on ds1388 Chris Packham
2020-03-30 15:33 ` Guenter Roeck
2020-03-30 18:39 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330183917.GG846876@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).