Linux-RTC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] rtc: mc13xxx: fix a double-unlock issue
@ 2020-05-03 18:22 wu000273
  2020-05-11 14:23 ` Alexandre Belloni
  0 siblings, 1 reply; 2+ messages in thread
From: wu000273 @ 2020-05-03 18:22 UTC (permalink / raw)
  To: a.zummo
  Cc: alexandre.belloni, Markus.Elfring, linux-rtc, linux-kernel, kjlu,
	wu000273

From: Qiushi Wu <wu000273@umn.edu>

In function mc13xxx_rtc_probe, the mc13xxx_unlock() is called
before rtc_register_device(). But in the error path of
rtc_register_device(), the mc13xxx_unlock() is called again,
which causes a double-unlock problem. Thus add a call of the
function “mc13xxx_lock” in an if branch for the completion
of the exception handling.

Fixes: e4ae7023e182a ("rtc: mc13xxx: set range")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
---
 drivers/rtc/rtc-mc13xxx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-mc13xxx.c b/drivers/rtc/rtc-mc13xxx.c
index afce2c0b4bd6..d6802e6191cb 100644
--- a/drivers/rtc/rtc-mc13xxx.c
+++ b/drivers/rtc/rtc-mc13xxx.c
@@ -308,8 +308,10 @@ static int __init mc13xxx_rtc_probe(struct platform_device *pdev)
 	mc13xxx_unlock(mc13xxx);
 
 	ret = rtc_register_device(priv->rtc);
-	if (ret)
+	if (ret) {
+		mc13xxx_lock(mc13xxx);
 		goto err_irq_request;
+	}
 
 	return 0;
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] rtc: mc13xxx: fix a double-unlock issue
  2020-05-03 18:22 [PATCH v2] rtc: mc13xxx: fix a double-unlock issue wu000273
@ 2020-05-11 14:23 ` Alexandre Belloni
  0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2020-05-11 14:23 UTC (permalink / raw)
  To: wu000273; +Cc: a.zummo, Markus.Elfring, linux-rtc, linux-kernel, kjlu

On 03/05/2020 13:22:35-0500, wu000273@umn.edu wrote:
> From: Qiushi Wu <wu000273@umn.edu>
> 
> In function mc13xxx_rtc_probe, the mc13xxx_unlock() is called
> before rtc_register_device(). But in the error path of
> rtc_register_device(), the mc13xxx_unlock() is called again,
> which causes a double-unlock problem. Thus add a call of the
> function “mc13xxx_lock” in an if branch for the completion
> of the exception handling.
> 
> Fixes: e4ae7023e182a ("rtc: mc13xxx: set range")
> Signed-off-by: Qiushi Wu <wu000273@umn.edu>
> ---
>  drivers/rtc/rtc-mc13xxx.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-03 18:22 [PATCH v2] rtc: mc13xxx: fix a double-unlock issue wu000273
2020-05-11 14:23 ` Alexandre Belloni

Linux-RTC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rtc/0 linux-rtc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rtc linux-rtc/ https://lore.kernel.org/linux-rtc \
		linux-rtc@vger.kernel.org
	public-inbox-index linux-rtc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rtc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git