From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Bruno Thomsen <bruno.thomsen@gmail.com>
Cc: Liam Beguin <liambeguin@gmail.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH v2 2/2] rtc: pcf2127: add alarm support
Date: Tue, 16 Jun 2020 10:47:37 +0200 [thread overview]
Message-ID: <20200616084737.GG241261@piout.net> (raw)
In-Reply-To: <CAH+2xPBUuaNsxuTm+JDGWbDMMUn3SVwkOQXo_N5U4HaDiFGScA@mail.gmail.com>
On 16/06/2020 10:38:00+0200, Bruno Thomsen wrote:
> > +static int pcf2127_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
> > +{
> > + struct pcf2127 *pcf2127 = dev_get_drvdata(dev);
> > + unsigned int buf[5], ctrl2;
> > + int ret;
> > +
> > + ret = regmap_read(pcf2127->regmap, PCF2127_REG_CTRL2, &ctrl2);
> > + if (ret) {
> > + dev_err(dev, "%s: ctrl2 read error\n", __func__);
> > + return ret;
> > + }
> > +
> > + ret = pcf2127_wdt_active_ping(&pcf2127->wdd);
> > + if (ret)
> > + return ret;
> > +
> > + ret = regmap_bulk_read(pcf2127->regmap, PCF2127_REG_ALARM_SC, buf,
> > + sizeof(buf));
> > + if (ret) {
> > + dev_err(dev, "%s: alarm read error\n", __func__);
> > + return ret;
> > + }
> > +
> > + alrm->enabled = ctrl2 & PCF2127_BIT_CTRL2_AIE;
> > + alrm->pending = ctrl2 & PCF2127_BIT_CTRL2_AF;
> > +
> > + alrm->time.tm_sec = bcd2bin(buf[0] & 0x7F);
> > + alrm->time.tm_min = bcd2bin(buf[1] & 0x7F);
> > + alrm->time.tm_hour = bcd2bin(buf[2] & 0x3F);
> > + alrm->time.tm_mday = bcd2bin(buf[3] & 0x3F);
> > + alrm->time.tm_wday = buf[4] & 0x07;
> > +
> > + dev_dbg(dev, "%s: alarm is %d:%d:%d, mday=%d, wday=%d\n", __func__,
> > + alrm->time.tm_hour, alrm->time.tm_min, alrm->time.tm_sec,
> > + alrm->time.tm_mday, alrm->time.tm_wday);
> > +
> > + return 0;
> > +}
> > +
> > +static int pcf2127_rtc_alarm_irq_enable(struct device *dev, u32 enable)
> > +{
> > + struct pcf2127 *pcf2127 = dev_get_drvdata(dev);
> > + int ret;
> > +
> > + ret = regmap_update_bits(pcf2127->regmap, PCF2127_REG_CTRL2,
> > + PCF2127_BIT_CTRL2_AIE,
> > + enable ? PCF2127_BIT_CTRL2_AIE : 0);
> > + if (ret) {
> > + dev_err(dev, "%s: failed to %s alarm (%d)\n", __func__,
> > + enable ? "enable" : "disable",
> > + ret);
> > + return ret;
> > + }
> > +
> > + ret = pcf2127_wdt_active_ping(&pcf2127->wdd);
> > + if (ret)
> > + return ret;
> > +
> > + return 0;
>
> Just do "return ret;" unconditional.
>
Just return pcf2127_wdt_active_ping(&pcf2127->wdd);
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-06-16 8:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 4:04 [PATCH v2 0/2] rtc: pcf2127: add alarm support Liam Beguin
2020-06-14 4:04 ` [PATCH v2 1/2] rtc: pcf2127: add pca2129 device id Liam Beguin
2020-06-16 8:17 ` Bruno Thomsen
2020-06-16 8:45 ` Alexandre Belloni
2020-06-14 4:04 ` [PATCH v2 2/2] rtc: pcf2127: add alarm support Liam Beguin
2020-06-16 8:38 ` Bruno Thomsen
2020-06-16 8:47 ` Alexandre Belloni [this message]
2020-06-16 13:11 ` Liam Beguin
2020-06-16 9:02 ` Alexandre Belloni
2020-06-16 13:07 ` Liam Beguin
2020-06-16 18:31 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616084737.GG241261@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=bruno.thomsen@gmail.com \
--cc=liambeguin@gmail.com \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).