From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Liam Beguin <liambeguin@gmail.com>
Cc: bruno.thomsen@gmail.com, a.zummo@towertech.it, linux-rtc@vger.kernel.org
Subject: Re: [PATCH v2 2/2] rtc: pcf2127: add alarm support
Date: Tue, 16 Jun 2020 20:31:28 +0200 [thread overview]
Message-ID: <20200616183128.GI241261@piout.net> (raw)
In-Reply-To: <C3IJT2LEDYLY.2NK6MCEXUHZHA@atris>
On 16/06/2020 09:07:59-0400, Liam Beguin wrote:
> > It is generally not useful to have those debug strings anymore because
> > the core already provides tracepoints at the correct locations.
> >
> > If you really want to keep it, then please use %ptR.
> >
> > This is also valid for the other dev_dbg.
> >
>
> I'm not particularly attached to keeping these in. I just left them in
> since it seemed to be common in other rtc drivers.
>
Yes, those predates the tracepoints (which are fairly recent).
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-06-16 18:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 4:04 [PATCH v2 0/2] rtc: pcf2127: add alarm support Liam Beguin
2020-06-14 4:04 ` [PATCH v2 1/2] rtc: pcf2127: add pca2129 device id Liam Beguin
2020-06-16 8:17 ` Bruno Thomsen
2020-06-16 8:45 ` Alexandre Belloni
2020-06-14 4:04 ` [PATCH v2 2/2] rtc: pcf2127: add alarm support Liam Beguin
2020-06-16 8:38 ` Bruno Thomsen
2020-06-16 8:47 ` Alexandre Belloni
2020-06-16 13:11 ` Liam Beguin
2020-06-16 9:02 ` Alexandre Belloni
2020-06-16 13:07 ` Liam Beguin
2020-06-16 18:31 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616183128.GI241261@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=bruno.thomsen@gmail.com \
--cc=liambeguin@gmail.com \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).