* Re: [PATCH] rtc: cpcap: fix range
2020-06-29 11:41 ` [PATCH] rtc: cpcap: fix range Sebastian Reichel
@ 2020-06-29 14:34 ` Tony Lindgren
2020-06-29 17:25 ` Merlijn Wajer
2020-07-02 20:23 ` Alexandre Belloni
2 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2020-06-29 14:34 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Sebastian Reichel, Alexandre Belloni, Dev Null, Pavel Machek,
Merlijn Wajer, linux-kernel, linux-omap, linux-rtc,
Sicelo A . Mhlongo
* Sebastian Reichel <sebastian.reichel@collabora.com> [200629 11:42]:
> Unbreak CPCAP driver, which has one more bit in the day counter
> increasing the max. range from 2014 to 2058. The original commit
> introducing the range limit was obviously wrong, since the driver
> has only been written in 2017 (3 years after 14 bits would have
> run out).
So I guess with 14 bits vs 15 bits we have these date ranges:
1970 + (0x3fff / 365) = 2014
1970 + (0x7fff / 365) = 2059
Meaning we can't do the whole year for 2059 and it's only 2058
compatible like you say above :)
Acked-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rtc: cpcap: fix range
2020-06-29 11:41 ` [PATCH] rtc: cpcap: fix range Sebastian Reichel
2020-06-29 14:34 ` Tony Lindgren
@ 2020-06-29 17:25 ` Merlijn Wajer
2020-07-02 20:23 ` Alexandre Belloni
2 siblings, 0 replies; 4+ messages in thread
From: Merlijn Wajer @ 2020-06-29 17:25 UTC (permalink / raw)
To: Sebastian Reichel, Sebastian Reichel, Alexandre Belloni, Dev Null
Cc: Tony Lindgren, Pavel Machek, linux-kernel, linux-omap, linux-rtc,
Sicelo A . Mhlongo
Hi,
On 29/06/2020 13:41, Sebastian Reichel wrote:
> Unbreak CPCAP driver, which has one more bit in the day counter
> increasing the max. range from 2014 to 2058. The original commit
> introducing the range limit was obviously wrong, since the driver
> has only been written in 2017 (3 years after 14 bits would have
> run out).
This seems to work for me, thanks.
Please add as you deem appropriate:
Tested-by: Merlijn Wajer <merlijn@wizzup.org>
Acked-by: Merlijn Wajer <merlijn@wizzup.org>
Cheers,
Merlijn
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rtc: cpcap: fix range
2020-06-29 11:41 ` [PATCH] rtc: cpcap: fix range Sebastian Reichel
2020-06-29 14:34 ` Tony Lindgren
2020-06-29 17:25 ` Merlijn Wajer
@ 2020-07-02 20:23 ` Alexandre Belloni
2 siblings, 0 replies; 4+ messages in thread
From: Alexandre Belloni @ 2020-07-02 20:23 UTC (permalink / raw)
To: Dev Null, Sebastian Reichel, Sebastian Reichel
Cc: Alexandre Belloni, linux-omap, Pavel Machek, linux-kernel,
Merlijn Wajer, Tony Lindgren, linux-rtc, Sicelo A . Mhlongo
On Mon, 29 Jun 2020 13:41:23 +0200, Sebastian Reichel wrote:
> Unbreak CPCAP driver, which has one more bit in the day counter
> increasing the max. range from 2014 to 2058. The original commit
> introducing the range limit was obviously wrong, since the driver
> has only been written in 2017 (3 years after 14 bits would have
> run out).
Applied, thanks!
What happen is that I can't count bits and so I though PCAP had 13 bits and
CPCAP 14 bits while it is indeed 14 and 15. I did the correct thing in the PCAP
driver though.
Thanks for the fix!
[1/1] rtc: cpcap: fix range
commit: d6ac11f677ded28180fc9e59b01db79036c3ec31
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
^ permalink raw reply [flat|nested] 4+ messages in thread