* [PATCH v5 12/20] dt-bindings: rtc: sun6i: Add H616 compatible string [not found] <20210127172500.13356-1-andre.przywara@arm.com> @ 2021-01-27 17:24 ` Andre Przywara 2021-01-28 10:20 ` Maxime Ripard 2021-01-31 13:44 ` Jernej Škrabec 0 siblings, 2 replies; 4+ messages in thread From: Andre Przywara @ 2021-01-27 17:24 UTC (permalink / raw) To: Maxime Ripard, Chen-Yu Tsai Cc: Jernej Skrabec, Samuel Holland, Icenowy Zheng, Rob Herring, Clément Péron, Shuosheng Huang, Yangtao Li, linux-arm-kernel, linux-kernel, linux-sunxi, Alessandro Zummo, Alexandre Belloni, devicetree, linux-rtc Add the obvious compatible name to the existing RTC binding, and pair it with the existing H6 fallback compatible string, as the devices are compatible. Signed-off-by: Andre Przywara <andre.przywara@arm.com> Acked-by: Rob Herring <robh@kernel.org> --- .../devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml index b1b0ee769b71..4193e5813344 100644 --- a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml +++ b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml @@ -26,6 +26,9 @@ properties: - const: allwinner,sun50i-a64-rtc - const: allwinner,sun8i-h3-rtc - const: allwinner,sun50i-h6-rtc + - items: + - const: allwinner,sun50i-h616-rtc + - const: allwinner,sun50i-h6-rtc reg: maxItems: 1 -- 2.17.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v5 12/20] dt-bindings: rtc: sun6i: Add H616 compatible string 2021-01-27 17:24 ` [PATCH v5 12/20] dt-bindings: rtc: sun6i: Add H616 compatible string Andre Przywara @ 2021-01-28 10:20 ` Maxime Ripard 2021-01-31 13:44 ` Jernej Škrabec 1 sibling, 0 replies; 4+ messages in thread From: Maxime Ripard @ 2021-01-28 10:20 UTC (permalink / raw) To: Andre Przywara Cc: Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Icenowy Zheng, Rob Herring, Clément Péron, Shuosheng Huang, Yangtao Li, linux-arm-kernel, linux-kernel, linux-sunxi, Alessandro Zummo, Alexandre Belloni, devicetree, linux-rtc [-- Attachment #1: Type: text/plain, Size: 390 bytes --] On Wed, Jan 27, 2021 at 05:24:52PM +0000, Andre Przywara wrote: > Add the obvious compatible name to the existing RTC binding, and pair > it with the existing H6 fallback compatible string, as the devices are > compatible. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > Acked-by: Rob Herring <robh@kernel.org> Acked-by: Maxime Ripard <mripard@kernel.org> maxime [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v5 12/20] dt-bindings: rtc: sun6i: Add H616 compatible string 2021-01-27 17:24 ` [PATCH v5 12/20] dt-bindings: rtc: sun6i: Add H616 compatible string Andre Przywara 2021-01-28 10:20 ` Maxime Ripard @ 2021-01-31 13:44 ` Jernej Škrabec 2021-02-02 0:05 ` Andre Przywara 1 sibling, 1 reply; 4+ messages in thread From: Jernej Škrabec @ 2021-01-31 13:44 UTC (permalink / raw) To: Maxime Ripard, Chen-Yu Tsai, Andre Przywara Cc: Samuel Holland, Icenowy Zheng, Rob Herring, Clément Péron, Shuosheng Huang, Yangtao Li, linux-arm-kernel, linux-kernel, linux-sunxi, Alessandro Zummo, Alexandre Belloni, devicetree, linux-rtc Hi! Dne sreda, 27. januar 2021 ob 18:24:52 CET je Andre Przywara napisal(a): > Add the obvious compatible name to the existing RTC binding, and pair > it with the existing H6 fallback compatible string, as the devices are > compatible. After close lookup I would disagree with this observation. Major difference is that H616 doesn't support usage of external 32768 Hz oscillator. It uses 24 MHz oscillator with divider for that case. Due to that change, whole logic for external oscillator should go out. Additionally, this logic overwrites default value in LOSC_CTRL register, which is not nice (there is no documentation for those bits). Best regards, Jernej > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > Acked-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31- rtc.yaml b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml > index b1b0ee769b71..4193e5813344 100644 > --- a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml > +++ b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml > @@ -26,6 +26,9 @@ properties: > - const: allwinner,sun50i-a64-rtc > - const: allwinner,sun8i-h3-rtc > - const: allwinner,sun50i-h6-rtc > + - items: > + - const: allwinner,sun50i-h616-rtc > + - const: allwinner,sun50i-h6-rtc > > reg: > maxItems: 1 > -- > 2.17.5 > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v5 12/20] dt-bindings: rtc: sun6i: Add H616 compatible string 2021-01-31 13:44 ` Jernej Škrabec @ 2021-02-02 0:05 ` Andre Przywara 0 siblings, 0 replies; 4+ messages in thread From: Andre Przywara @ 2021-02-02 0:05 UTC (permalink / raw) To: Jernej Škrabec Cc: Maxime Ripard, Chen-Yu Tsai, Samuel Holland, Icenowy Zheng, Rob Herring, Clément Péron, Shuosheng Huang, Yangtao Li, linux-arm-kernel, linux-kernel, linux-sunxi, Alessandro Zummo, Alexandre Belloni, devicetree, linux-rtc On Sun, 31 Jan 2021 14:44:40 +0100 Jernej Škrabec <jernej.skrabec@siol.net> wrote: Hi Jernej, > Dne sreda, 27. januar 2021 ob 18:24:52 CET je Andre Przywara napisal(a): > > Add the obvious compatible name to the existing RTC binding, and pair > > it with the existing H6 fallback compatible string, as the devices are > > compatible. > > After close lookup I would disagree with this observation. Major difference is > that H616 doesn't support usage of external 32768 Hz oscillator. It uses 24 > MHz oscillator with divider for that case. Due to that change, whole logic for > external oscillator should go out. Additionally, this logic overwrites default > value in LOSC_CTRL register, which is not nice (there is no documentation for > those bits). Thanks for the heads up, and I wonder if there is more to that. From comparing the RTC documentation, I wonder if we should actually have incoming clocks in the bindings (the crystals / external clock sources with 32KHz, 16MHz, 24MHz). Then we could actually model which crystals the board provides. It seems like the H6 made the 32KHz OSC optional, and the H616 simply doesn't support it anymore - at the very least I don't see any X32K pins anymore. But more importantly: looking more closely (I only skimmed over the register summary back then) the actual RTC registers are different: the H616 encodes a linear day number (vs. a broken-down D-M-Y), also the time-of-day register is different. So we definitely need a driver update, and hence need to drop this patch. Cheers, Andre > Best regards, > Jernej > > > > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > > Acked-by: Rob Herring <robh@kernel.org> > > --- > > .../devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31- > rtc.yaml b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml > > index b1b0ee769b71..4193e5813344 100644 > > --- a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml > > +++ b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml > > @@ -26,6 +26,9 @@ properties: > > - const: allwinner,sun50i-a64-rtc > > - const: allwinner,sun8i-h3-rtc > > - const: allwinner,sun50i-h6-rtc > > + - items: > > + - const: allwinner,sun50i-h616-rtc > > + - const: allwinner,sun50i-h6-rtc > > > > reg: > > maxItems: 1 > > -- > > 2.17.5 > > > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-02 0:07 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20210127172500.13356-1-andre.przywara@arm.com> 2021-01-27 17:24 ` [PATCH v5 12/20] dt-bindings: rtc: sun6i: Add H616 compatible string Andre Przywara 2021-01-28 10:20 ` Maxime Ripard 2021-01-31 13:44 ` Jernej Škrabec 2021-02-02 0:05 ` Andre Przywara
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).