[PATCH v5] rtc: rx6110: add ACPI bindings to I2C

[PATCH v5] rtc: rx6110: add ACPI bindings to I2C

[Claudius Heine]

From: Johannes Hahn <johannes-hahn@siemens.com>

This allows the RX6110 driver to be automatically assigned to the right
device on the I2C bus.

Signed-off-by: Johannes Hahn <johannes-hahn@siemens.com>
Co-developed-by: Claudius Heine <ch@denx.de>
Signed-off-by: Claudius Heine <ch@denx.de>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reported-by: kernel test robot <lkp@intel.com>
---
 drivers/rtc/rtc-rx6110.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/rtc/rtc-rx6110.c b/drivers/rtc/rtc-rx6110.c
index 79161d4c6ce4..f4d425002f7f 100644
--- a/drivers/rtc/rtc-rx6110.c
+++ b/drivers/rtc/rtc-rx6110.c
@@ -447,6 +447,12 @@ static int rx6110_i2c_probe(struct i2c_client *client,
 	return rx6110_probe(rx6110, &client->dev);
 }
 
+static const struct acpi_device_id rx6110_i2c_acpi_match[] = {
+	{ "SECC6110" },
+	{ }
+};
+MODULE_DEVICE_TABLE(acpi, rx6110_i2c_acpi_match);
+
 static const struct i2c_device_id rx6110_i2c_id[] = {
 	{ "rx6110", 0 },
 	{ }
@@ -456,6 +462,7 @@ MODULE_DEVICE_TABLE(i2c, rx6110_i2c_id);
 static struct i2c_driver rx6110_i2c_driver = {
 	.driver = {
 		.name = RX6110_DRIVER_NAME,
+		.acpi_match_table = rx6110_i2c_acpi_match,
 	},
 	.probe		= rx6110_i2c_probe,
 	.id_table	= rx6110_i2c_id,

base-commit: 1df27313f50a57497c1faeb6a6ae4ca939c85a7d
-- 
2.30.1

Re: [PATCH v5] rtc: rx6110: add ACPI bindings to I2C

[Andy Shevchenko]

On Wed, Mar 17, 2021 at 9:56 AM Claudius Heine <ch@denx.de> wrote:
>
> From: Johannes Hahn <johannes-hahn@siemens.com>
>
> This allows the RX6110 driver to be automatically assigned to the right
> device on the I2C bus.

Thanks for an update!

> Signed-off-by: Johannes Hahn <johannes-hahn@siemens.com>
> Co-developed-by: Claudius Heine <ch@denx.de>
> Signed-off-by: Claudius Heine <ch@denx.de>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Reported-by: kernel test robot <lkp@intel.com>

This is usually for patches that do fix found problems, here it's a
completely new item and the report was done in the middle of the
development. That said, you may give credit to LKP by just mentioning
it in the comments section (after the cutter '---' line). I'll leave
this to Alexandre and Alessandro to decide if you need a resend or
they may remove it when applying. (In my opinion resend is not needed
right now)


> ---
>  drivers/rtc/rtc-rx6110.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/rtc/rtc-rx6110.c b/drivers/rtc/rtc-rx6110.c
> index 79161d4c6ce4..f4d425002f7f 100644
> --- a/drivers/rtc/rtc-rx6110.c
> +++ b/drivers/rtc/rtc-rx6110.c
> @@ -447,6 +447,12 @@ static int rx6110_i2c_probe(struct i2c_client *client,
>         return rx6110_probe(rx6110, &client->dev);
>  }
>
> +static const struct acpi_device_id rx6110_i2c_acpi_match[] = {
> +       { "SECC6110" },
> +       { }
> +};
> +MODULE_DEVICE_TABLE(acpi, rx6110_i2c_acpi_match);
> +
>  static const struct i2c_device_id rx6110_i2c_id[] = {
>         { "rx6110", 0 },
>         { }
> @@ -456,6 +462,7 @@ MODULE_DEVICE_TABLE(i2c, rx6110_i2c_id);
>  static struct i2c_driver rx6110_i2c_driver = {
>         .driver = {
>                 .name = RX6110_DRIVER_NAME,
> +               .acpi_match_table = rx6110_i2c_acpi_match,
>         },
>         .probe          = rx6110_i2c_probe,
>         .id_table       = rx6110_i2c_id,
>
> base-commit: 1df27313f50a57497c1faeb6a6ae4ca939c85a7d
> --
> 2.30.1
>


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v5] rtc: rx6110: add ACPI bindings to I2C

[Claudius Heine]

Hi Andy,

On 2021-03-17 10:28, Andy Shevchenko wrote:
> On Wed, Mar 17, 2021 at 9:56 AM Claudius Heine <ch@denx.de> wrote:
>>
>> From: Johannes Hahn <johannes-hahn@siemens.com>
>>
>> This allows the RX6110 driver to be automatically assigned to the right
>> device on the I2C bus.
> 
> Thanks for an update!
> 
>> Signed-off-by: Johannes Hahn <johannes-hahn@siemens.com>
>> Co-developed-by: Claudius Heine <ch@denx.de>
>> Signed-off-by: Claudius Heine <ch@denx.de>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
>> Reported-by: kernel test robot <lkp@intel.com>
> 
> This is usually for patches that do fix found problems, here it's a
> completely new item and the report was done in the middle of the
> development. That said, you may give credit to LKP by just mentioning
> it in the comments section (after the cutter '---' line). I'll leave
> this to Alexandre and Alessandro to decide if you need a resend or
> they may remove it when applying. (In my opinion resend is not needed
> right now)
Ok. Thanks a lot for your reviews and patience!

regards,
Claudius

Re: [PATCH v5] rtc: rx6110: add ACPI bindings to I2C

[Alexandre Belloni]

On Wed, 17 Mar 2021 08:52:27 +0100, Claudius Heine wrote:
> This allows the RX6110 driver to be automatically assigned to the right
> device on the I2C bus.

Applied, thanks!

[1/1] rtc: rx6110: add ACPI bindings to I2C
      commit: 8d69f62fddf6c1a8c7745120c4d6aab9322b001a

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@bootlin.com>

Re: [PATCH v5] rtc: rx6110: add ACPI bindings to I2C

[Alexandre Belloni]

On 17/03/2021 10:32:39+0100, Claudius Heine wrote:
> Hi Andy,
> 
> On 2021-03-17 10:28, Andy Shevchenko wrote:
> > On Wed, Mar 17, 2021 at 9:56 AM Claudius Heine <ch@denx.de> wrote:
> > > 
> > > From: Johannes Hahn <johannes-hahn@siemens.com>
> > > 
> > > This allows the RX6110 driver to be automatically assigned to the right
> > > device on the I2C bus.
> > 
> > Thanks for an update!
> > 
> > > Signed-off-by: Johannes Hahn <johannes-hahn@siemens.com>
> > > Co-developed-by: Claudius Heine <ch@denx.de>
> > > Signed-off-by: Claudius Heine <ch@denx.de>
> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > 
> > > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > This is usually for patches that do fix found problems, here it's a
> > completely new item and the report was done in the middle of the
> > development. That said, you may give credit to LKP by just mentioning
> > it in the comments section (after the cutter '---' line). I'll leave
> > this to Alexandre and Alessandro to decide if you need a resend or
> > they may remove it when applying. (In my opinion resend is not needed
> > right now)
> Ok. Thanks a lot for your reviews and patience!
> 

I removed it when applying. Thanks for the work and the reviews!


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com