From: Jinke Fan <fanjinke@hygon.cn>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: "a.zummo@towertech.it" <a.zummo@towertech.it>,
Wen Pu <puwen@hygon.cn>,
"thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
"kim.phillips@amd.com" <kim.phillips@amd.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] rtc: Fix the AltCentury value on AMD/Hygon platform
Date: Wed, 9 Oct 2019 03:18:07 +0000 [thread overview]
Message-ID: <55aaed33-9f65-7580-74be-f5cd92c26e27@hygon.cn> (raw)
In-Reply-To: <20191008094419.GT4254@piout.net>
On 2019/10/8 17:44, Alexandre Belloni wrote:
> On 08/10/2019 17:37:12+0800, Jinke Fan wrote:
>> When using following operations:
>> save_control = CMOS_READ(RTC_CONTROL);
>> - CMOS_WRITE((save_control|RTC_SET), RTC_CONTROL);
>> + CMOS_WRITE((save_control | RTC_SET), RTC_CONTROL);
>
> Unrelated change.
OK, this line change will be cancelled in the patch v3.
>> save_freq_select = CMOS_READ(RTC_FREQ_SELECT);
>> - CMOS_WRITE((save_freq_select|RTC_DIV_RESET2), RTC_FREQ_SELECT);
>> +
>> +#if defined(CONFIG_CPU_SUP_AMD) || defined(CONFIG_CPU_SUP_HYGON)
>> + CMOS_WRITE((save_freq_select & (~RTC_DV0)), RTC_FREQ_SELECT);
>
> That does break all the other x86 platforms.
Yes, it's a mistake. In the patch v3, the modifications will be
limited to AMD/Hygon vendor id.
--
Best Regards,
Jinke Fan
prev parent reply other threads:[~2019-10-09 3:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 9:37 [PATCH v2] rtc: Fix the AltCentury value on AMD/Hygon platform Jinke Fan
2019-10-08 9:44 ` Alexandre Belloni
2019-10-09 3:18 ` Jinke Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55aaed33-9f65-7580-74be-f5cd92c26e27@hygon.cn \
--to=fanjinke@hygon.cn \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=puwen@hygon.cn \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).