Linux-RTC Archive on lore.kernel.org
 help / color / Atom feed
From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "rdunlap@infradead.org" <rdunlap@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"lee.jones@linaro.org" <lee.jones@linaro.org>
Subject: Re: [PATCH] rtc: bd70528: add dependency to fix build errors
Date: Mon, 8 Jul 2019 13:29:14 +0000
Message-ID: <653472d59d565401d96ec83a42406cf6c2f77453.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <420b921d-10ca-1d9a-ac46-5969a7f0e0b9@infradead.org>

Hello Randy,

Thanks a lot for trying to clean up the mess :)

On Sun, 2019-07-07 at 09:12 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build errors when MFD_ROHM_BD70528=m, BD70528_WATCHDOG=m,
> and RTC_DRV_BD70528=y.  Fixes these build errors:
> 
> ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_alm_enable':
> rtc-bd70528.c:(.text+0x3a2): undefined reference to
> `bd70528_wdt_lock'
> ld: rtc-bd70528.c:(.text+0x3f8): undefined reference to
> `bd70528_wdt_unlock'
> ld: drivers/rtc/rtc-bd70528.o: in function
> `bd70528_set_rtc_based_timers':
> rtc-bd70528.c:(.text+0x41c): undefined reference to `bd70528_wdt_set'
> ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_set_time':
> rtc-bd70528.c:(.text+0x500): undefined reference to
> `bd70528_wdt_lock'
> ld: rtc-bd70528.c:(.text+0x587): undefined reference to
> `bd70528_wdt_unlock'
> 
> Also add a blank line to separate the Kconfig entry from the one
> above it.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> Cc: linux-rtc@vger.kernel.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> Found in mmotm but applies to linux-next.
> 
>  drivers/rtc/Kconfig |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- mmotm-2019-0706-2200.orig/drivers/rtc/Kconfig
> +++ mmotm-2019-0706-2200/drivers/rtc/Kconfig
> @@ -498,8 +498,10 @@ config RTC_DRV_M41T80_WDT
>  	help
>  	  If you say Y here you will get support for the
>  	  watchdog timer in the ST M41T60 and M41T80 RTC chips series.
> +
>  config RTC_DRV_BD70528
>  	tristate "ROHM BD70528 PMIC RTC"
> +	depends on MFD_ROHM_BD70528

This is definitely required dependency. But I guess this is still not
fixing everything... I assume this allows configuring MFD and RTC in-
kernel while leaving WDG to be built as module. That will probably also
fail. I am not sure how to solve this elegantly while still allowing
WDG to be left out if it is not needed.

>  	help
>  	  If you say Y here you will get support for the RTC
>  	  on ROHM BD70528 Power Management IC.
> 
> 

Br,
	Matti Vaittinen

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-07 16:12 Randy Dunlap
2019-07-08 13:29 ` Vaittinen, Matti [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=653472d59d565401d96ec83a42406cf6c2f77453.camel@fi.rohmeurope.com \
    --to=matti.vaittinen@fi.rohmeurope.com \
    --cc=akpm@linux-foundation.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RTC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rtc/0 linux-rtc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rtc linux-rtc/ https://lore.kernel.org/linux-rtc \
		linux-rtc@vger.kernel.org linux-rtc@archiver.kernel.org
	public-inbox-index linux-rtc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rtc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox