* [PATCH] rtc: fsl-ftm-alarm: remove the useless variable
@ 2020-03-23 7:29 Peng Ma
2020-03-23 8:28 ` Alexandre Belloni
0 siblings, 1 reply; 3+ messages in thread
From: Peng Ma @ 2020-03-23 7:29 UTC (permalink / raw)
To: a.zummo, alexandre.belloni
Cc: linux-rtc, linux-kernel, leoyang.li, ran.wang_1, biwen.li, Peng Ma
Remove the useless variable to fixed the below build warning:
drivers/rtc/rtc-fsl-ftm-alarm.c: In function 'ftm_rtc_probe':
drivers/rtc/rtc-fsl-ftm-alarm.c:246:22: warning: unused variable 'np' [-Wunused-variable]
struct device_node *np = pdev->dev.of_node;
Signed-off-by: Peng Ma <peng.ma@nxp.com>
---
drivers/rtc/rtc-fsl-ftm-alarm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c
index c572044..0f4142b 100644
--- a/drivers/rtc/rtc-fsl-ftm-alarm.c
+++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
@@ -243,7 +243,6 @@ static const struct rtc_class_ops ftm_rtc_ops = {
static int ftm_rtc_probe(struct platform_device *pdev)
{
- struct device_node *np = pdev->dev.of_node;
int irq;
int ret;
struct ftm_rtc *rtc;
--
2.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtc: fsl-ftm-alarm: remove the useless variable
2020-03-23 7:29 [PATCH] rtc: fsl-ftm-alarm: remove the useless variable Peng Ma
@ 2020-03-23 8:28 ` Alexandre Belloni
2020-03-23 9:15 ` [EXT] " Peng Ma
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Belloni @ 2020-03-23 8:28 UTC (permalink / raw)
To: Peng Ma
Cc: a.zummo, linux-rtc, linux-kernel, leoyang.li, ran.wang_1, biwen.li
On 23/03/2020 15:29:56+0800, Peng Ma wrote:
> Remove the useless variable to fixed the below build warning:
> drivers/rtc/rtc-fsl-ftm-alarm.c: In function 'ftm_rtc_probe':
> drivers/rtc/rtc-fsl-ftm-alarm.c:246:22: warning: unused variable 'np' [-Wunused-variable]
> struct device_node *np = pdev->dev.of_node;
>
> Signed-off-by: Peng Ma <peng.ma@nxp.com>
> ---
> drivers/rtc/rtc-fsl-ftm-alarm.c | 1 -
> 1 file changed, 1 deletion(-)
>
I squashed it in the offending commit.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [EXT] Re: [PATCH] rtc: fsl-ftm-alarm: remove the useless variable
2020-03-23 8:28 ` Alexandre Belloni
@ 2020-03-23 9:15 ` Peng Ma
0 siblings, 0 replies; 3+ messages in thread
From: Peng Ma @ 2020-03-23 9:15 UTC (permalink / raw)
To: Alexandre Belloni
Cc: a.zummo, linux-rtc, linux-kernel, Leo Li, Ran Wang, Biwen Li
>-----Original Message-----
>From: Alexandre Belloni <alexandre.belloni@bootlin.com>
>Sent: 2020年3月23日 16:29
>To: Peng Ma <peng.ma@nxp.com>
>Cc: a.zummo@towertech.it; linux-rtc@vger.kernel.org;
>linux-kernel@vger.kernel.org; Leo Li <leoyang.li@nxp.com>; Ran Wang
><ran.wang_1@nxp.com>; Biwen Li <biwen.li@nxp.com>
>Subject: [EXT] Re: [PATCH] rtc: fsl-ftm-alarm: remove the useless variable
>
>Caution: EXT Email
>
>On 23/03/2020 15:29:56+0800, Peng Ma wrote:
>> Remove the useless variable to fixed the below build warning:
>> drivers/rtc/rtc-fsl-ftm-alarm.c: In function 'ftm_rtc_probe':
>> drivers/rtc/rtc-fsl-ftm-alarm.c:246:22: warning: unused variable 'np'
>[-Wunused-variable]
>> struct device_node *np = pdev->dev.of_node;
>>
>> Signed-off-by: Peng Ma <peng.ma@nxp.com>
>> ---
>> drivers/rtc/rtc-fsl-ftm-alarm.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>
>I squashed it in the offending commit.
[Peng Ma] OK,Got it, thanks
Best Regards,
Peng
>--
>Alexandre Belloni, Bootlin
>Embedded Linux and Kernel engineering
>https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
>om&data=02%7C01%7Cpeng.ma%40nxp.com%7Cd3d60d9c26524805b352
>08d7cf043999%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6372054
>89372736346&sdata=wb4bBcP8dMbriAdZFnSgl44JokZ0AK6MsGa7z6CWGlg
>%3D&reserved=0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-23 9:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-23 7:29 [PATCH] rtc: fsl-ftm-alarm: remove the useless variable Peng Ma
2020-03-23 8:28 ` Alexandre Belloni
2020-03-23 9:15 ` [EXT] " Peng Ma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).