From: Tzung-Bi Shih <tzungbi@google.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Fei Shao <fshao@chromium.org>,
Eddie Huang <eddie.huang@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Yuchen Huang <yuchen.huang@mediatek.com>,
Ran Bi <ran.bi@mediatek.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-rtc@vger.kernel.org, srv_heupstream@mediatek.com,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Wen Su <wen.su@mediatek.com>, Jiaxin Yu <jiaxin.yu@mediatek.com>
Subject: Re: [PATCH RESEND v5 8/8] arm64: dts: mt6359: add PMIC MT6359 related nodes
Date: Tue, 2 Feb 2021 11:51:11 +0800 [thread overview]
Message-ID: <CA+Px+wXP2vrFbou+SCRZuXYr4XPPxYHZfk+oSM7_GPXZSD24UQ@mail.gmail.com> (raw)
In-Reply-To: <1cbf58f1-376c-fa93-98a2-53a41fa24273@gmail.com>
On Sun, Jan 31, 2021 at 7:06 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
> On 29/01/2021 10:49, Hsin-Hsiung Wang wrote:
> > + mt6359codec: mt6359codec {
> > + };
>
> I understand that the dmic-mode and mic-type-X depends on the actual board on
> which it is used. In that case I think we should add mt6359codec node in the dts
> instead of dtsi file. I'd advise to set these properties as well as otherwise we
> get a (slightly misleading) warning in the driver.
I feel it is better to include the node in dtsi to represent the whole
MT6359 PMIC.
We could either:
- Set default values of these properties in the dtsi to avoid the
warning message.
- Or https://patchwork.kernel.org/project/alsa-devel/patch/20210202033557.1621029-1-tzungbi@google.com/
next prev parent reply other threads:[~2021-02-02 3:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1611913781-23460-1-git-send-email-hsin-hsiung.wang@mediatek.com>
2021-01-29 9:49 ` [PATCH RESEND v5 3/8] dt-bindings: mfd: Add compatible for the MediaTek MT6359 PMIC Hsin-Hsiung Wang
2021-02-05 22:04 ` Rob Herring
2021-01-29 9:49 ` [PATCH RESEND v5 4/8] dt-bindings: regulator: Add document for MT6359 regulator Hsin-Hsiung Wang
2021-01-30 17:23 ` Rob Herring
2021-01-29 9:49 ` [PATCH RESEND v5 6/8] regulator: mt6359: Add support " Hsin-Hsiung Wang
2021-01-29 9:49 ` [PATCH RESEND v5 8/8] arm64: dts: mt6359: add PMIC MT6359 related nodes Hsin-Hsiung Wang
[not found] ` <1cbf58f1-376c-fa93-98a2-53a41fa24273@gmail.com>
2021-02-02 3:51 ` Tzung-Bi Shih [this message]
2021-02-07 18:48 ` Matthias Brugger
[not found] ` <1611913781-23460-6-git-send-email-hsin-hsiung.wang@mediatek.com>
2021-03-01 10:20 ` [PATCH RESEND v5 5/8] mfd: Add support for the MediaTek MT6359 PMIC Lee Jones
2021-03-12 16:13 ` Hsin-hsiung Wang
[not found] ` <1611913781-23460-8-git-send-email-hsin-hsiung.wang@mediatek.com>
2021-03-01 10:21 ` [PATCH RESEND v5 7/8] regulator: mt6359: Add support for MT6359P regulator Lee Jones
2021-03-12 16:20 ` Hsin-hsiung Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+Px+wXP2vrFbou+SCRZuXYr4XPPxYHZfk+oSM7_GPXZSD24UQ@mail.gmail.com \
--to=tzungbi@google.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=fshao@chromium.org \
--cc=hsin-hsiung.wang@mediatek.com \
--cc=jiaxin.yu@mediatek.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=ran.bi@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=wen.su@mediatek.com \
--cc=yuchen.huang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).