From: Chuhong Yuan <hslester96@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-rtc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: [PATCH] rtc: rv3028: Add missed check for devm_regmap_init_i2c()
Date: Thu, 28 May 2020 18:21:29 +0800 [thread overview]
Message-ID: <CANhBUQ0_do+=MZsj0NKEfAAVeuWy8V+hvQuVBBB2o+u+H9s1qA@mail.gmail.com> (raw)
In-Reply-To: <6eb98232-bc84-0854-243a-e54b91f2bda6@web.de>
On Thu, May 28, 2020 at 5:17 PM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > rv3028_probe() misses a check for devm_regmap_init_i2c().
>
> Such information is helpful.
>
>
> > Add the missed check
>
> Thanks for another completion of the exception handling.
>
>
> > to fix it.
>
> I suggest to replace this wording by the tag “Fixes” for the commit message.
> How do you think about to take this possibility into account
> for any more patches?
>
I got it. I have added fixes tags in my newly sent patches.
Regards,
Chuhong
> Regards,
> Markus
prev parent reply other threads:[~2020-05-28 10:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 9:17 [PATCH] rtc: rv3028: Add missed check for devm_regmap_init_i2c() Markus Elfring
2020-05-28 10:21 ` Chuhong Yuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANhBUQ0_do+=MZsj0NKEfAAVeuWy8V+hvQuVBBB2o+u+H9s1qA@mail.gmail.com' \
--to=hslester96@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).