* Re: [PATCH] rtc: rv3028: Add missed check for devm_regmap_init_i2c()
@ 2020-05-28 9:17 Markus Elfring
2020-05-28 10:21 ` Chuhong Yuan
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-05-28 9:17 UTC (permalink / raw)
To: Chuhong Yuan, linux-rtc; +Cc: linux-kernel, Alexandre Belloni, Alessandro Zummo
> rv3028_probe() misses a check for devm_regmap_init_i2c().
Such information is helpful.
> Add the missed check
Thanks for another completion of the exception handling.
> to fix it.
I suggest to replace this wording by the tag “Fixes” for the commit message.
How do you think about to take this possibility into account
for any more patches?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: rv3028: Add missed check for devm_regmap_init_i2c()
2020-05-28 9:17 [PATCH] rtc: rv3028: Add missed check for devm_regmap_init_i2c() Markus Elfring
@ 2020-05-28 10:21 ` Chuhong Yuan
0 siblings, 0 replies; 2+ messages in thread
From: Chuhong Yuan @ 2020-05-28 10:21 UTC (permalink / raw)
To: Markus Elfring; +Cc: linux-rtc, LKML, Alexandre Belloni, Alessandro Zummo
On Thu, May 28, 2020 at 5:17 PM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > rv3028_probe() misses a check for devm_regmap_init_i2c().
>
> Such information is helpful.
>
>
> > Add the missed check
>
> Thanks for another completion of the exception handling.
>
>
> > to fix it.
>
> I suggest to replace this wording by the tag “Fixes” for the commit message.
> How do you think about to take this possibility into account
> for any more patches?
>
I got it. I have added fixes tags in my newly sent patches.
Regards,
Chuhong
> Regards,
> Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-28 10:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 9:17 [PATCH] rtc: rv3028: Add missed check for devm_regmap_init_i2c() Markus Elfring
2020-05-28 10:21 ` Chuhong Yuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).