From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Biju Das <biju.das@bp.renesas.com>
Cc: Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
linux-rtc@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2] nvmem: check invalid number of bytes in nvmem_{read,write}()
Date: Mon, 10 Dec 2018 18:34:09 +0000 [thread overview]
Message-ID: <eb72f5b7-2920-b3b5-8387-d2b6b2d310cd@linaro.org> (raw)
In-Reply-To: <1544455701-5720-1-git-send-email-biju.das@bp.renesas.com>
On 10/12/18 15:28, Biju Das wrote:
> + /* Stop the user from writing */
> + if (offset >= nvmem->size)
> + return -ENOSPC;
> +
This should be "return -EFBIG" to make utilities like dd or sh happy.
Look at 38b0774c0598c ("nvmem: core: return EFBIG on out-of-range
write") for more info.
other than that, patch looks fine to me!
--srini
next prev parent reply other threads:[~2018-12-10 18:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 15:28 [PATCH v2] nvmem: check invalid number of bytes in nvmem_{read,write}() Biju Das
2018-12-10 18:34 ` Srinivas Kandagatla [this message]
2018-12-11 8:16 ` Biju Das
2018-12-11 9:31 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb72f5b7-2920-b3b5-8387-d2b6b2d310cd@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=Chris.Paterson2@renesas.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=biju.das@bp.renesas.com \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).