* [kvm-unit-tests PATCH] s390x: Remove sthyi partition number check
@ 2021-02-18 8:24 Janosch Frank
2021-02-18 8:32 ` David Hildenbrand
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Janosch Frank @ 2021-02-18 8:24 UTC (permalink / raw)
To: kvm; +Cc: linux-s390, imbrenda, david, thuth
Turns out that partition numbers start from 0 and not from 1 so a 0
check doesn't make sense here.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
s390x/sthyi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/s390x/sthyi.c b/s390x/sthyi.c
index d8dfc854..db90b56f 100644
--- a/s390x/sthyi.c
+++ b/s390x/sthyi.c
@@ -128,7 +128,6 @@ static void test_fcode0_par(struct sthyi_par_sctn *par)
report(sum, "core counts");
if (par->INFPVAL1 & PART_STSI_SUC) {
- report(par->INFPPNUM, "number");
report(memcmp(par->INFPPNAM, null_buf, sizeof(par->INFPPNAM)),
"name");
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] s390x: Remove sthyi partition number check
2021-02-18 8:24 [kvm-unit-tests PATCH] s390x: Remove sthyi partition number check Janosch Frank
@ 2021-02-18 8:32 ` David Hildenbrand
2021-02-18 8:51 ` Cornelia Huck
2021-02-18 14:54 ` Claudio Imbrenda
2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2021-02-18 8:32 UTC (permalink / raw)
To: Janosch Frank, kvm; +Cc: linux-s390, imbrenda, thuth
On 18.02.21 09:24, Janosch Frank wrote:
> Turns out that partition numbers start from 0 and not from 1 so a 0
> check doesn't make sense here.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> s390x/sthyi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/s390x/sthyi.c b/s390x/sthyi.c
> index d8dfc854..db90b56f 100644
> --- a/s390x/sthyi.c
> +++ b/s390x/sthyi.c
> @@ -128,7 +128,6 @@ static void test_fcode0_par(struct sthyi_par_sctn *par)
> report(sum, "core counts");
>
> if (par->INFPVAL1 & PART_STSI_SUC) {
> - report(par->INFPPNUM, "number");
> report(memcmp(par->INFPPNAM, null_buf, sizeof(par->INFPPNAM)),
> "name");
> }
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] s390x: Remove sthyi partition number check
2021-02-18 8:24 [kvm-unit-tests PATCH] s390x: Remove sthyi partition number check Janosch Frank
2021-02-18 8:32 ` David Hildenbrand
@ 2021-02-18 8:51 ` Cornelia Huck
2021-02-18 14:54 ` Claudio Imbrenda
2 siblings, 0 replies; 4+ messages in thread
From: Cornelia Huck @ 2021-02-18 8:51 UTC (permalink / raw)
To: Janosch Frank; +Cc: kvm, linux-s390, imbrenda, david, thuth
On Thu, 18 Feb 2021 03:24:49 -0500
Janosch Frank <frankja@linux.ibm.com> wrote:
> Turns out that partition numbers start from 0 and not from 1 so a 0
> check doesn't make sense here.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> s390x/sthyi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/s390x/sthyi.c b/s390x/sthyi.c
> index d8dfc854..db90b56f 100644
> --- a/s390x/sthyi.c
> +++ b/s390x/sthyi.c
> @@ -128,7 +128,6 @@ static void test_fcode0_par(struct sthyi_par_sctn *par)
> report(sum, "core counts");
>
> if (par->INFPVAL1 & PART_STSI_SUC) {
> - report(par->INFPPNUM, "number");
> report(memcmp(par->INFPPNAM, null_buf, sizeof(par->INFPPNAM)),
> "name");
> }
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] s390x: Remove sthyi partition number check
2021-02-18 8:24 [kvm-unit-tests PATCH] s390x: Remove sthyi partition number check Janosch Frank
2021-02-18 8:32 ` David Hildenbrand
2021-02-18 8:51 ` Cornelia Huck
@ 2021-02-18 14:54 ` Claudio Imbrenda
2 siblings, 0 replies; 4+ messages in thread
From: Claudio Imbrenda @ 2021-02-18 14:54 UTC (permalink / raw)
To: Janosch Frank; +Cc: kvm, linux-s390, david, thuth
On Thu, 18 Feb 2021 03:24:49 -0500
Janosch Frank <frankja@linux.ibm.com> wrote:
> Turns out that partition numbers start from 0 and not from 1 so a 0
> check doesn't make sense here.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> s390x/sthyi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/s390x/sthyi.c b/s390x/sthyi.c
> index d8dfc854..db90b56f 100644
> --- a/s390x/sthyi.c
> +++ b/s390x/sthyi.c
> @@ -128,7 +128,6 @@ static void test_fcode0_par(struct sthyi_par_sctn
> *par) report(sum, "core counts");
>
> if (par->INFPVAL1 & PART_STSI_SUC) {
> - report(par->INFPPNUM, "number");
> report(memcmp(par->INFPPNAM, null_buf,
> sizeof(par->INFPPNAM)), "name");
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-18 17:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-18 8:24 [kvm-unit-tests PATCH] s390x: Remove sthyi partition number check Janosch Frank
2021-02-18 8:32 ` David Hildenbrand
2021-02-18 8:51 ` Cornelia Huck
2021-02-18 14:54 ` Claudio Imbrenda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).