From: Thomas Huth <thuth@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
pmorel@linux.ibm.com, david@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 8/8] s390x: Remove SAVE/RESTORE_stack
Date: Wed, 17 Feb 2021 17:18:34 +0100 [thread overview]
Message-ID: <4fd224a2-1c4d-1663-6615-685eadcf81f6@redhat.com> (raw)
In-Reply-To: <20210217144116.3368-9-frankja@linux.ibm.com>
On 17/02/2021 15.41, Janosch Frank wrote:
> There are no more users.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
> ---
> s390x/macros.S | 29 -----------------------------
> 1 file changed, 29 deletions(-)
>
> diff --git a/s390x/macros.S b/s390x/macros.S
> index 212a3823..399a87c6 100644
> --- a/s390x/macros.S
> +++ b/s390x/macros.S
> @@ -28,35 +28,6 @@
> lpswe \old_psw
> .endm
>
> - .macro SAVE_REGS
> - /* save grs 0-15 */
> - stmg %r0, %r15, GEN_LC_SW_INT_GRS
> - /* save crs 0-15 */
> - stctg %c0, %c15, GEN_LC_SW_INT_CRS
> - /* load a cr0 that has the AFP control bit which enables all FPRs */
> - larl %r1, initial_cr0
> - lctlg %c0, %c0, 0(%r1)
> - /* save fprs 0-15 + fpc */
> - la %r1, GEN_LC_SW_INT_FPRS
> - .irp i, 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15
> - std \i, \i * 8(%r1)
> - .endr
> - stfpc GEN_LC_SW_INT_FPC
> - .endm
> -
> - .macro RESTORE_REGS
> - /* restore fprs 0-15 + fpc */
> - la %r1, GEN_LC_SW_INT_FPRS
> - .irp i, 0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15
> - ld \i, \i * 8(%r1)
> - .endr
> - lfpc GEN_LC_SW_INT_FPC
Could we now also remove the sw_int_fprs and sw_int_fpc from the lowcore?
Thomas
next prev parent reply other threads:[~2021-02-17 16:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 14:41 [kvm-unit-tests PATCH v2 0/8] s390x: Cleanup exception register save/restore and implement backtrace Janosch Frank
2021-02-17 14:41 ` [kvm-unit-tests PATCH v2 1/8] s390x: Fix fpc store address in RESTORE_REGS_STACK Janosch Frank
2021-02-17 14:41 ` [kvm-unit-tests PATCH v2 2/8] s390x: Fully commit to stack save area for exceptions Janosch Frank
2021-02-17 15:35 ` Thomas Huth
2021-02-17 16:54 ` Janosch Frank
2021-02-17 14:41 ` [kvm-unit-tests PATCH v2 3/8] RFC: s390x: Define STACK_FRAME_INT_SIZE macro Janosch Frank
2021-02-17 15:38 ` Thomas Huth
2021-02-17 16:08 ` Janosch Frank
2021-02-17 16:10 ` Thomas Huth
2021-02-17 14:41 ` [kvm-unit-tests PATCH v2 4/8] s390x: Introduce and use CALL_INT_HANDLER macro Janosch Frank
2021-02-17 15:49 ` Thomas Huth
2021-02-17 15:55 ` Thomas Huth
2021-02-17 16:22 ` Janosch Frank
2021-02-17 17:03 ` Thomas Huth
2021-02-18 9:16 ` Janosch Frank
2021-02-17 14:41 ` [kvm-unit-tests PATCH v2 5/8] s390x: Provide preliminary backtrace support Janosch Frank
2021-02-17 16:01 ` Thomas Huth
2021-02-17 16:12 ` Janosch Frank
2021-02-17 14:41 ` [kvm-unit-tests PATCH v2 6/8] s390x: Print more information on program exceptions Janosch Frank
2021-02-17 14:41 ` [kvm-unit-tests PATCH v2 7/8] s390x: Move diag308_load_reset to stack saving Janosch Frank
2021-02-17 14:41 ` [kvm-unit-tests PATCH v2 8/8] s390x: Remove SAVE/RESTORE_stack Janosch Frank
2021-02-17 16:18 ` Thomas Huth [this message]
2021-02-17 16:46 ` Janosch Frank
2021-02-17 16:50 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fd224a2-1c4d-1663-6615-685eadcf81f6@redhat.com \
--to=thuth@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pmorel@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).