From: Tony Lu <tonylu@linux.alibaba.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
kgraul@linux.ibm.com, kuba@kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Re: [RFC PATCH net-next 0/6] net/smc: Spread workload over multiple cores
Date: Thu, 27 Jan 2022 15:59:36 +0800 [thread overview]
Message-ID: <YfJQ6AwYMA/i4HvH@TonyMac-Alibaba> (raw)
In-Reply-To: <YfI50xqsv20KDpz9@unreal>
On Thu, Jan 27, 2022 at 08:21:07AM +0200, Leon Romanovsky wrote:
> On Thu, Jan 27, 2022 at 11:14:37AM +0800, Tony Lu wrote:
> > On Wed, Jan 26, 2022 at 11:28:06AM -0400, Jason Gunthorpe wrote:
> > > On Wed, Jan 26, 2022 at 03:23:22PM +0800, Tony Lu wrote:
> > > > On Sun, Jan 16, 2022 at 11:00:33AM +0200, Leon Romanovsky wrote:
> > > > >
> > > > > Please CC RDMA mailing list next time.
> > > > >
> > > > > Why didn't you use already existed APIs in drivers/infiniband/core/cq.c?
> > > > > ib_cq_pool_get() will do most if not all of your open-coded CQ spreading
> > > > > logic.
> > > >
> > > > I am working on replacing with ib_cq_pool_get(), this need ib_poll_context
> > > > to indicate the poller which provides by ib_poll_handler(). It's okay
> > > > for now, but for the callback function. When it polled a ib_wc, it
> > > > would call wc->wr_cqe->done(cq, wc), which is the union with wr_id. The
> > > > wr_id is heavily used in SMC.
> > >
> > > Part of using the new interface is converting to use wr_cqe, you
> > > should just do that work instead of trying to duplicate a core API in
> > > a driver.
> >
> > Thanks for your advice. This patch set aims to improve performance with
> > current API in SMC protocol, which is more urgent.
>
> This code existed from 2017, it is hard to agree with "urgent" claim.
Yes, I agree with you that the code is old. I think there are two
problems, one for performance issue, the other one for API refactor.
We are running into the performance issues mentioned in patches in our
cloud environment. So I think it is more urgent for a real world issue.
The current modification is less intrusive to the code. This makes
changes simpler. And current implement works for now, this is why I put
refactor behind.
Thank you,
Tony Lu
next prev parent reply other threads:[~2022-01-27 7:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 5:48 [RFC PATCH net-next 0/6] net/smc: Spread workload over multiple cores Tony Lu
2022-01-14 5:48 ` [RFC PATCH net-next 1/6] net/smc: Spread CQs to differents completion vectors Tony Lu
2022-01-14 5:48 ` [RFC PATCH net-next 2/6] net/smc: Prepare for multiple CQs per IB devices Tony Lu
2022-01-14 5:48 ` [RFC PATCH net-next 3/6] net/smc: Introduce smc_ib_cq to bind link and cq Tony Lu
2022-01-14 5:48 ` [RFC PATCH net-next 4/6] net/smc: Multiple CQs per IB devices Tony Lu
2022-01-14 5:48 ` [RFC PATCH net-next 5/6] net/smc: Unbind buffer size from clcsock and make it tunable Tony Lu
2022-01-14 5:48 ` [RFC PATCH net-next 6/6] net/smc: Introduce tunable linkgroup max connections Tony Lu
2022-01-16 9:00 ` [RFC PATCH net-next 0/6] net/smc: Spread workload over multiple cores Leon Romanovsky
2022-01-16 17:47 ` Tony Lu
2022-01-26 7:23 ` Tony Lu
2022-01-26 15:28 ` Jason Gunthorpe
2022-01-27 3:14 ` Tony Lu
2022-01-27 6:21 ` Leon Romanovsky
2022-01-27 7:59 ` Tony Lu [this message]
2022-01-27 8:47 ` Leon Romanovsky
2022-01-27 9:14 ` Tony Lu
2022-01-27 9:25 ` Leon Romanovsky
2022-01-27 9:50 ` Tony Lu
2022-01-27 14:52 ` Karsten Graul
2022-01-28 6:55 ` Tony Lu
2022-02-01 16:50 ` Karsten Graul
2022-02-09 9:49 ` Tony Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfJQ6AwYMA/i4HvH@TonyMac-Alibaba \
--to=tonylu@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=jgg@ziepe.ca \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).