* [PATCH] agp: amd64: remove unneeded initialization
@ 2020-10-23 20:26 Lukas Bulwahn
0 siblings, 0 replies; 4+ messages in thread
From: Lukas Bulwahn @ 2020-10-23 20:26 UTC (permalink / raw)
To: linux-safety; +Cc: Lukas Bulwahn
make clang-analyzer on x86_64 defconfig caught my attention with:
drivers/char/agp/amd64-agp.c:336:2: warning: \
Value stored to 'i' is never read [clang-analyzer-deadcode.DeadStores]
i = 0;
^
Remove this unneeded initialization to make clang-analyzer happy.
Commit a32073bffc65 ("x86_64: Clean and enhance up K8 northbridge access
code") refactored cache_nbs() and introduced this unneeded dead-store
initialization.
As compilers will detect this unneeded assignment and optimize this anyway,
the resulting binary is identical before and after this change.
No functional change. No change in binary code.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/char/agp/amd64-agp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
index b40edae32817..0413b3136541 100644
--- a/drivers/char/agp/amd64-agp.c
+++ b/drivers/char/agp/amd64-agp.c
@@ -333,7 +333,6 @@ static int cache_nbs(struct pci_dev *pdev, u32 cap_ptr)
if (!amd_nb_has_feature(AMD_NB_GART))
return -ENODEV;
- i = 0;
for (i = 0; i < amd_nb_num(); i++) {
struct pci_dev *dev = node_to_amd_nb(i)->misc;
if (fix_northbridge(dev, pdev, cap_ptr) < 0) {
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] agp: amd64: remove unneeded initialization
@ 2020-10-28 13:31 Lukas Bulwahn
2020-10-28 14:02 ` Tom Rix
2020-10-29 2:37 ` Nathan Chancellor
0 siblings, 2 replies; 4+ messages in thread
From: Lukas Bulwahn @ 2020-10-28 13:31 UTC (permalink / raw)
To: David Airlie
Cc: Nathan Chancellor, Nick Desaulniers, Tom Rix, clang-built-linux,
linux-kernel, kernel-janitors, linux-safety, Lukas Bulwahn
make clang-analyzer on x86_64 defconfig caught my attention with:
drivers/char/agp/amd64-agp.c:336:2: warning: \
Value stored to 'i' is never read [clang-analyzer-deadcode.DeadStores]
i = 0;
^
Remove this unneeded initialization to make clang-analyzer happy.
Commit a32073bffc65 ("x86_64: Clean and enhance up K8 northbridge access
code") refactored cache_nbs() and introduced this unneeded dead-store
initialization.
As compilers will detect this unneeded assignment and optimize this anyway,
the resulting binary is identical before and after this change.
No functional change. No change in binary code.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
applies cleanly on current master and next-20201028
David, please pick this minor non-urgent clean-up patch.
drivers/char/agp/amd64-agp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
index b40edae32817..0413b3136541 100644
--- a/drivers/char/agp/amd64-agp.c
+++ b/drivers/char/agp/amd64-agp.c
@@ -333,7 +333,6 @@ static int cache_nbs(struct pci_dev *pdev, u32 cap_ptr)
if (!amd_nb_has_feature(AMD_NB_GART))
return -ENODEV;
- i = 0;
for (i = 0; i < amd_nb_num(); i++) {
struct pci_dev *dev = node_to_amd_nb(i)->misc;
if (fix_northbridge(dev, pdev, cap_ptr) < 0) {
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] agp: amd64: remove unneeded initialization
2020-10-28 13:31 Lukas Bulwahn
@ 2020-10-28 14:02 ` Tom Rix
2020-10-29 2:37 ` Nathan Chancellor
1 sibling, 0 replies; 4+ messages in thread
From: Tom Rix @ 2020-10-28 14:02 UTC (permalink / raw)
To: Lukas Bulwahn, David Airlie
Cc: Nathan Chancellor, Nick Desaulniers, clang-built-linux,
linux-kernel, kernel-janitors, linux-safety
On 10/28/20 6:31 AM, Lukas Bulwahn wrote:
> make clang-analyzer on x86_64 defconfig caught my attention with:
>
> drivers/char/agp/amd64-agp.c:336:2: warning: \
> Value stored to 'i' is never read [clang-analyzer-deadcode.DeadStores]
> i = 0;
> ^
>
> Remove this unneeded initialization to make clang-analyzer happy.
>
> Commit a32073bffc65 ("x86_64: Clean and enhance up K8 northbridge access
> code") refactored cache_nbs() and introduced this unneeded dead-store
> initialization.
>
> As compilers will detect this unneeded assignment and optimize this anyway,
> the resulting binary is identical before and after this change.
>
> No functional change. No change in binary code.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> applies cleanly on current master and next-20201028
>
> David, please pick this minor non-urgent clean-up patch.
>
> drivers/char/agp/amd64-agp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
> index b40edae32817..0413b3136541 100644
> --- a/drivers/char/agp/amd64-agp.c
> +++ b/drivers/char/agp/amd64-agp.c
> @@ -333,7 +333,6 @@ static int cache_nbs(struct pci_dev *pdev, u32 cap_ptr)
> if (!amd_nb_has_feature(AMD_NB_GART))
> return -ENODEV;
>
> - i = 0;
> for (i = 0; i < amd_nb_num(); i++) {
> struct pci_dev *dev = node_to_amd_nb(i)->misc;
> if (fix_northbridge(dev, pdev, cap_ptr) < 0) {
Looks ok to me.
Reviewed-by: Tom Rix <trix@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] agp: amd64: remove unneeded initialization
2020-10-28 13:31 Lukas Bulwahn
2020-10-28 14:02 ` Tom Rix
@ 2020-10-29 2:37 ` Nathan Chancellor
1 sibling, 0 replies; 4+ messages in thread
From: Nathan Chancellor @ 2020-10-29 2:37 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: David Airlie, Nick Desaulniers, Tom Rix, clang-built-linux,
linux-kernel, kernel-janitors, linux-safety
On Wed, Oct 28, 2020 at 02:31:06PM +0100, Lukas Bulwahn wrote:
> make clang-analyzer on x86_64 defconfig caught my attention with:
>
> drivers/char/agp/amd64-agp.c:336:2: warning: \
> Value stored to 'i' is never read [clang-analyzer-deadcode.DeadStores]
> i = 0;
> ^
>
> Remove this unneeded initialization to make clang-analyzer happy.
>
> Commit a32073bffc65 ("x86_64: Clean and enhance up K8 northbridge access
> code") refactored cache_nbs() and introduced this unneeded dead-store
> initialization.
>
> As compilers will detect this unneeded assignment and optimize this anyway,
> the resulting binary is identical before and after this change.
>
> No functional change. No change in binary code.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Seems obvious :)
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> applies cleanly on current master and next-20201028
>
> David, please pick this minor non-urgent clean-up patch.
>
> drivers/char/agp/amd64-agp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
> index b40edae32817..0413b3136541 100644
> --- a/drivers/char/agp/amd64-agp.c
> +++ b/drivers/char/agp/amd64-agp.c
> @@ -333,7 +333,6 @@ static int cache_nbs(struct pci_dev *pdev, u32 cap_ptr)
> if (!amd_nb_has_feature(AMD_NB_GART))
> return -ENODEV;
>
> - i = 0;
> for (i = 0; i < amd_nb_num(); i++) {
> struct pci_dev *dev = node_to_amd_nb(i)->misc;
> if (fix_northbridge(dev, pdev, cap_ptr) < 0) {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-29 2:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-23 20:26 [PATCH] agp: amd64: remove unneeded initialization Lukas Bulwahn
2020-10-28 13:31 Lukas Bulwahn
2020-10-28 14:02 ` Tom Rix
2020-10-29 2:37 ` Nathan Chancellor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).