* [PATCH v4 0/5] Fix the parse_dt of exynos dsi and remove the OF graph [not found] <CGME20170306044231epcas5p3ecbd44359ebb1eb35f8cf0b1a614afcb@epcas5p3.samsung.com> @ 2017-03-06 4:42 ` Hoegeun Kwon [not found] ` <CGME20170306044233epcas1p20b5e6c764a7752290e5ed25cc13a69af@epcas1p2.samsung.com> ` (4 more replies) 0 siblings, 5 replies; 13+ messages in thread From: Hoegeun Kwon @ 2017-03-06 4:42 UTC (permalink / raw) To: inki.dae, jy0922.shim, sw0312.kim, airlied, kgene, krzk, robh+dt, mark.rutland, catalin.marinas, will.deacon Cc: devicetree, linux-samsung-soc, linux-kernel, dri-devel, javier, Hoegeun Kwon, linux-arm-kernel Hi All, The dsi + panel is a parental relationship, so OF grpah is not needed. Therefore, the current dsi_parse_dt function will throw an error, because there is no linked OF graph for case such as fimd + dsi + panel. So the 1/5 patch parse the Pll, burst and esc clock frequency properties in dsi_parse_dt and modified to create a bridge_node only if there is an OF graph associated with dsi. Also fixed the dts, which depend on the 1/5 patch. So removed the ports node and move burst and esc clock frequency properties to the parent (DSI node). Changes for V4: - Squashed patch 2, 3 and 4. - Added Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> on all patches. Changes for V3: - Split the patches considering the bisectability problem. Changes for V2: - Added the clear explanation for commit. (1/5 patch) - Fixed it to the same subject as the actual work. (2/5 ~ 5/5 patches) Best Regards, Hoegeun Hoegeun Kwon (5): arm64: dts: exynos: Add the burst and esc clock frequency properties to DSI node arm: dts: Add the burst and esc clock frequency properties to DSI node drm/exynos: dsi: Fix the parse_dt function arm64: dts: exynos: Remove the OF graph from DSI node arm: dts: Remove the OF graph from DSI node arch/arm/boot/dts/exynos3250-rinato.dts | 23 ++-------------- arch/arm/boot/dts/exynos4210-trats.dts | 23 ++-------------- arch/arm/boot/dts/exynos4412-trats2.dts | 23 ++-------------- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 16 ++--------- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 32 ++++++---------------- 5 files changed, 16 insertions(+), 101 deletions(-) -- 1.9.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <CGME20170306044233epcas1p20b5e6c764a7752290e5ed25cc13a69af@epcas1p2.samsung.com>]
* [PATCH v4 1/5] arm64: dts: exynos: Add the burst and esc clock frequency properties to DSI node [not found] ` <CGME20170306044233epcas1p20b5e6c764a7752290e5ed25cc13a69af@epcas1p2.samsung.com> @ 2017-03-06 4:42 ` Hoegeun Kwon 2017-03-06 4:49 ` Andi Shyti 0 siblings, 1 reply; 13+ messages in thread From: Hoegeun Kwon @ 2017-03-06 4:42 UTC (permalink / raw) To: inki.dae, jy0922.shim, sw0312.kim, airlied, kgene, krzk, robh+dt, mark.rutland, catalin.marinas, will.deacon Cc: devicetree, linux-samsung-soc, linux-kernel, dri-devel, javier, Hoegeun Kwon, linux-arm-kernel The OF graph is not needed because the panel is a child of dsi. Add the burst and esc clock frequency properties to the parent (DSI node). Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi index 6ce93a3..e31e20c 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi @@ -298,6 +298,8 @@ status = "okay"; vddcore-supply = <&ldo6_reg>; vddio-supply = <&ldo7_reg>; + samsung,burst-clock-frequency = <512000000>; + samsung,esc-clock-frequency = <16000000>; samsung,pll-clock-frequency = <24000000>; pinctrl-names = "default"; pinctrl-0 = <&te_irq>; -- 1.9.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v4 1/5] arm64: dts: exynos: Add the burst and esc clock frequency properties to DSI node 2017-03-06 4:42 ` [PATCH v4 1/5] arm64: dts: exynos: Add the burst and esc clock frequency properties to DSI node Hoegeun Kwon @ 2017-03-06 4:49 ` Andi Shyti 2017-03-06 4:55 ` Hoegeun Kwon 0 siblings, 1 reply; 13+ messages in thread From: Andi Shyti @ 2017-03-06 4:49 UTC (permalink / raw) To: Hoegeun Kwon Cc: mark.rutland, devicetree, linux-samsung-soc, jy0922.shim, javier, airlied, catalin.marinas, sw0312.kim, linux-kernel, krzk, inki.dae, robh+dt, kgene, dri-devel, will.deacon, linux-arm-kernel Hi Hoegeun, On Mon, Mar 06, 2017 at 01:42:19PM +0900, Hoegeun Kwon wrote: > The OF graph is not needed because the panel is a child of dsi. Add > the burst and esc clock frequency properties to the parent (DSI node). > > Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> you forgot to put me in Cc and add my Reviewed-by: Andi Shyti <andi.shyti@samsung.com> Andi ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v4 1/5] arm64: dts: exynos: Add the burst and esc clock frequency properties to DSI node 2017-03-06 4:49 ` Andi Shyti @ 2017-03-06 4:55 ` Hoegeun Kwon 0 siblings, 0 replies; 13+ messages in thread From: Hoegeun Kwon @ 2017-03-06 4:55 UTC (permalink / raw) To: Andi Shyti Cc: mark.rutland, devicetree, linux-samsung-soc, javier, catalin.marinas, sw0312.kim, linux-kernel, krzk, robh+dt, kgene, dri-devel, will.deacon, Hoegeun Kwon, linux-arm-kernel On 03/06/2017 01:49 PM, Andi Shyti wrote: > Hi Hoegeun, > > On Mon, Mar 06, 2017 at 01:42:19PM +0900, Hoegeun Kwon wrote: >> The OF graph is not needed because the panel is a child of dsi. Add >> the burst and esc clock frequency properties to the parent (DSI node). >> >> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> >> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> > you forgot to put me in Cc and add my > > Reviewed-by: Andi Shyti <andi.shyti@samsung.com> Sorry Andi, I mistake... :( Thanks for all your review. Best Regards, Hoegeun > > Andi > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <CGME20170306044234epcas1p22e9481182e11330cea0d169ce0ad2666@epcas1p2.samsung.com>]
* [PATCH v4 2/5] arm: dts: Add the burst and esc clock frequency properties to DSI node [not found] ` <CGME20170306044234epcas1p22e9481182e11330cea0d169ce0ad2666@epcas1p2.samsung.com> @ 2017-03-06 4:42 ` Hoegeun Kwon 2017-03-06 4:49 ` Andi Shyti [not found] ` <1488775343-6236-3-git-send-email-hoegeun.kwon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 0 siblings, 2 replies; 13+ messages in thread From: Hoegeun Kwon @ 2017-03-06 4:42 UTC (permalink / raw) To: inki.dae, jy0922.shim, sw0312.kim, airlied, kgene, krzk, robh+dt, mark.rutland, catalin.marinas, will.deacon Cc: devicetree, linux-samsung-soc, linux-kernel, dri-devel, javier, Hoegeun Kwon, linux-arm-kernel The OF graph is not needed because the panel is a child of dsi. Add the burst and esc clock frequency properties to the parent (DSI node). Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> --- arch/arm/boot/dts/exynos3250-rinato.dts | 2 ++ arch/arm/boot/dts/exynos4210-trats.dts | 2 ++ arch/arm/boot/dts/exynos4412-trats2.dts | 2 ++ 3 files changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts index 548413e..c9f191c 100644 --- a/arch/arm/boot/dts/exynos3250-rinato.dts +++ b/arch/arm/boot/dts/exynos3250-rinato.dts @@ -215,6 +215,8 @@ &dsi_0 { vddcore-supply = <&ldo6_reg>; vddio-supply = <&ldo6_reg>; + samsung,burst-clock-frequency = <250000000>; + samsung,esc-clock-frequency = <20000000>; samsung,pll-clock-frequency = <24000000>; status = "okay"; diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts index 0ca1b4d..1743ca8 100644 --- a/arch/arm/boot/dts/exynos4210-trats.dts +++ b/arch/arm/boot/dts/exynos4210-trats.dts @@ -197,6 +197,8 @@ &dsi_0 { vddcore-supply = <&vusb_reg>; vddio-supply = <&vmipi_reg>; + samsung,burst-clock-frequency = <500000000>; + samsung,esc-clock-frequency = <20000000>; samsung,pll-clock-frequency = <24000000>; status = "okay"; diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts index 41ecd6d..82221a0 100644 --- a/arch/arm/boot/dts/exynos4412-trats2.dts +++ b/arch/arm/boot/dts/exynos4412-trats2.dts @@ -385,6 +385,8 @@ &dsi_0 { vddcore-supply = <&ldo8_reg>; vddio-supply = <&ldo10_reg>; + samsung,burst-clock-frequency = <500000000>; + samsung,esc-clock-frequency = <20000000>; samsung,pll-clock-frequency = <24000000>; status = "okay"; -- 1.9.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v4 2/5] arm: dts: Add the burst and esc clock frequency properties to DSI node 2017-03-06 4:42 ` [PATCH v4 2/5] arm: dts: " Hoegeun Kwon @ 2017-03-06 4:49 ` Andi Shyti [not found] ` <1488775343-6236-3-git-send-email-hoegeun.kwon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 1 sibling, 0 replies; 13+ messages in thread From: Andi Shyti @ 2017-03-06 4:49 UTC (permalink / raw) To: Hoegeun Kwon Cc: mark.rutland, devicetree, linux-samsung-soc, jy0922.shim, javier, airlied, catalin.marinas, sw0312.kim, linux-kernel, krzk, inki.dae, robh+dt, kgene, dri-devel, will.deacon, linux-arm-kernel Hi Hoegeun, On Mon, Mar 06, 2017 at 01:42:20PM +0900, Hoegeun Kwon wrote: > The OF graph is not needed because the panel is a child of dsi. Add > the burst and esc clock frequency properties to the parent (DSI node). > > Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> Andi ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <1488775343-6236-3-git-send-email-hoegeun.kwon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH v4 2/5] arm: dts: Add the burst and esc clock frequency properties to DSI node [not found] ` <1488775343-6236-3-git-send-email-hoegeun.kwon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> @ 2017-03-06 8:38 ` Lothar Waßmann 0 siblings, 0 replies; 13+ messages in thread From: Lothar Waßmann @ 2017-03-06 8:38 UTC (permalink / raw) To: Hoegeun Kwon Cc: inki.dae-Sze3O3UU22JBDgjK7y7TUQ, jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ, sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ, airlied-cv59FeDIM0c, kgene-DgEjT+Ai2ygdnm+yROfE0A, krzk-DgEjT+Ai2ygdnm+yROfE0A, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, catalin.marinas-5wv7dgnIgG8, will.deacon-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, javier-JPH+aEBZ4P+UEJcrhfAQsw, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Hi, On Mon, 06 Mar 2017 13:42:20 +0900 Hoegeun Kwon wrote: > The OF graph is not needed because the panel is a child of dsi. Add > This is obviously from your patch #5 and doesn't make sense in this context. > the burst and esc clock frequency properties to the parent (DSI node). > > Signed-off-by: Hoegeun Kwon <hoegeun.kwon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > Reviewed-by: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > --- > arch/arm/boot/dts/exynos3250-rinato.dts | 2 ++ > arch/arm/boot/dts/exynos4210-trats.dts | 2 ++ > arch/arm/boot/dts/exynos4412-trats2.dts | 2 ++ > 3 files changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts > index 548413e..c9f191c 100644 > --- a/arch/arm/boot/dts/exynos3250-rinato.dts > +++ b/arch/arm/boot/dts/exynos3250-rinato.dts > @@ -215,6 +215,8 @@ > &dsi_0 { > vddcore-supply = <&ldo6_reg>; > vddio-supply = <&ldo6_reg>; > + samsung,burst-clock-frequency = <250000000>; > + samsung,esc-clock-frequency = <20000000>; > samsung,pll-clock-frequency = <24000000>; > status = "okay"; > > diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts > index 0ca1b4d..1743ca8 100644 > --- a/arch/arm/boot/dts/exynos4210-trats.dts > +++ b/arch/arm/boot/dts/exynos4210-trats.dts > @@ -197,6 +197,8 @@ > &dsi_0 { > vddcore-supply = <&vusb_reg>; > vddio-supply = <&vmipi_reg>; > + samsung,burst-clock-frequency = <500000000>; > + samsung,esc-clock-frequency = <20000000>; > samsung,pll-clock-frequency = <24000000>; > status = "okay"; > > diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts > index 41ecd6d..82221a0 100644 > --- a/arch/arm/boot/dts/exynos4412-trats2.dts > +++ b/arch/arm/boot/dts/exynos4412-trats2.dts > @@ -385,6 +385,8 @@ > &dsi_0 { > vddcore-supply = <&ldo8_reg>; > vddio-supply = <&ldo10_reg>; > + samsung,burst-clock-frequency = <500000000>; > + samsung,esc-clock-frequency = <20000000>; > samsung,pll-clock-frequency = <24000000>; > status = "okay"; > Lothar Waßmann -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <CGME20170306044236epcas5p326440b0139bee5a33fd6545d0400bb57@epcas5p3.samsung.com>]
* [PATCH v4 3/5] drm/exynos: dsi: Fix the parse_dt function [not found] ` <CGME20170306044236epcas5p326440b0139bee5a33fd6545d0400bb57@epcas5p3.samsung.com> @ 2017-03-06 4:42 ` Hoegeun Kwon 2017-03-06 4:49 ` Andi Shyti 0 siblings, 1 reply; 13+ messages in thread From: Hoegeun Kwon @ 2017-03-06 4:42 UTC (permalink / raw) To: inki.dae, jy0922.shim, sw0312.kim, airlied, kgene, krzk, robh+dt, mark.rutland, catalin.marinas, will.deacon Cc: devicetree, linux-samsung-soc, linux-kernel, dri-devel, javier, Hoegeun Kwon, linux-arm-kernel The dsi + panel is a parental relationship, so OF grpah is not needed. Therefore, the current dsi_parse_dt function will throw an error, because there is no linked OF graph for case such as fimd + dsi + panel. So this patch parse the Pll, burst and esc clock frequency properties in dsi_parse_dt and modified to create a bridge_node only if there is an OF graph associated with dsi. So I think the ABI breakage is needed. Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 32 ++++++++------------------------ 1 file changed, 8 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index f5c04d0..2d4e118 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1652,39 +1652,23 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi) if (ret < 0) return ret; - ep = of_graph_get_endpoint_by_regs(node, DSI_PORT_OUT, 0); - if (!ep) { - dev_err(dev, "no output port with endpoint specified\n"); - return -EINVAL; - } - - ret = exynos_dsi_of_read_u32(ep, "samsung,burst-clock-frequency", + ret = exynos_dsi_of_read_u32(node, "samsung,burst-clock-frequency", &dsi->burst_clk_rate); if (ret < 0) - goto end; + return ret; - ret = exynos_dsi_of_read_u32(ep, "samsung,esc-clock-frequency", + ret = exynos_dsi_of_read_u32(node, "samsung,esc-clock-frequency", &dsi->esc_clk_rate); if (ret < 0) - goto end; - - of_node_put(ep); + return ret; ep = of_graph_get_next_endpoint(node, NULL); - if (!ep) { - ret = -EINVAL; - goto end; - } - - dsi->bridge_node = of_graph_get_remote_port_parent(ep); - if (!dsi->bridge_node) { - ret = -EINVAL; - goto end; + if (ep) { + dsi->bridge_node = of_graph_get_remote_port_parent(ep); + of_node_put(ep); } -end: - of_node_put(ep); - return ret; + return 0; } static int exynos_dsi_bind(struct device *dev, struct device *master, -- 1.9.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v4 3/5] drm/exynos: dsi: Fix the parse_dt function 2017-03-06 4:42 ` [PATCH v4 3/5] drm/exynos: dsi: Fix the parse_dt function Hoegeun Kwon @ 2017-03-06 4:49 ` Andi Shyti 0 siblings, 0 replies; 13+ messages in thread From: Andi Shyti @ 2017-03-06 4:49 UTC (permalink / raw) To: Hoegeun Kwon Cc: mark.rutland, devicetree, linux-samsung-soc, jy0922.shim, javier, airlied, catalin.marinas, sw0312.kim, linux-kernel, krzk, inki.dae, robh+dt, kgene, dri-devel, will.deacon, linux-arm-kernel Hi Hoegeun, On Mon, Mar 06, 2017 at 01:42:21PM +0900, Hoegeun Kwon wrote: > The dsi + panel is a parental relationship, so OF grpah is not needed. > Therefore, the current dsi_parse_dt function will throw an error, > because there is no linked OF graph for case such as fimd + dsi + > panel. So this patch parse the Pll, burst and esc clock frequency > properties in dsi_parse_dt and modified to create a bridge_node only > if there is an OF graph associated with dsi. > So I think the ABI breakage is needed. > > Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> Andi ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <CGME20170306044237epcas5p35d955ba5e849a8ebcf13007ab1b377dc@epcas5p3.samsung.com>]
* [PATCH v4 4/5] arm64: dts: exynos: Remove the OF graph from DSI node [not found] ` <CGME20170306044237epcas5p35d955ba5e849a8ebcf13007ab1b377dc@epcas5p3.samsung.com> @ 2017-03-06 4:42 ` Hoegeun Kwon 2017-03-06 4:50 ` Andi Shyti 0 siblings, 1 reply; 13+ messages in thread From: Hoegeun Kwon @ 2017-03-06 4:42 UTC (permalink / raw) To: inki.dae, jy0922.shim, sw0312.kim, airlied, kgene, krzk, robh+dt, mark.rutland, catalin.marinas, will.deacon Cc: devicetree, linux-samsung-soc, linux-kernel, dri-devel, javier, Hoegeun Kwon, linux-arm-kernel The OF graph is not needed because the panel is a child of dsi. Remove the ports node in DSI node. Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi index e31e20c..77ba238 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi @@ -303,20 +303,6 @@ samsung,pll-clock-frequency = <24000000>; pinctrl-names = "default"; pinctrl-0 = <&te_irq>; - - ports { - #address-cells = <1>; - #size-cells = <0>; - - port@1 { - reg = <1>; - - dsi_out: endpoint { - samsung,burst-clock-frequency = <512000000>; - samsung,esc-clock-frequency = <16000000>; - }; - }; - }; }; &hdmi { -- 1.9.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v4 4/5] arm64: dts: exynos: Remove the OF graph from DSI node 2017-03-06 4:42 ` [PATCH v4 4/5] arm64: dts: exynos: Remove the OF graph from DSI node Hoegeun Kwon @ 2017-03-06 4:50 ` Andi Shyti 0 siblings, 0 replies; 13+ messages in thread From: Andi Shyti @ 2017-03-06 4:50 UTC (permalink / raw) To: Hoegeun Kwon Cc: mark.rutland, devicetree, linux-samsung-soc, jy0922.shim, javier, airlied, catalin.marinas, sw0312.kim, linux-kernel, krzk, inki.dae, robh+dt, kgene, dri-devel, will.deacon, linux-arm-kernel Hi Hoegeun, On Mon, Mar 06, 2017 at 01:42:22PM +0900, Hoegeun Kwon wrote: > The OF graph is not needed because the panel is a child of dsi. Remove > the ports node in DSI node. > > Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> Andi ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <CGME20170306044239epcas1p2cf8ad82b218e72119af0a35af249148f@epcas1p2.samsung.com>]
* [PATCH v4 5/5] arm: dts: Remove the OF graph from DSI node [not found] ` <CGME20170306044239epcas1p2cf8ad82b218e72119af0a35af249148f@epcas1p2.samsung.com> @ 2017-03-06 4:42 ` Hoegeun Kwon 2017-03-06 4:50 ` Andi Shyti 0 siblings, 1 reply; 13+ messages in thread From: Hoegeun Kwon @ 2017-03-06 4:42 UTC (permalink / raw) To: inki.dae, jy0922.shim, sw0312.kim, airlied, kgene, krzk, robh+dt, mark.rutland, catalin.marinas, will.deacon Cc: devicetree, linux-samsung-soc, linux-kernel, dri-devel, javier, Hoegeun Kwon, linux-arm-kernel The OF graph is not needed because the panel is a child of dsi. Remove the ports node in DSI node, and port node in panel node. Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> --- arch/arm/boot/dts/exynos3250-rinato.dts | 21 --------------------- arch/arm/boot/dts/exynos4210-trats.dts | 21 --------------------- arch/arm/boot/dts/exynos4412-trats2.dts | 21 --------------------- 3 files changed, 63 deletions(-) diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts index c9f191c..82e676a 100644 --- a/arch/arm/boot/dts/exynos3250-rinato.dts +++ b/arch/arm/boot/dts/exynos3250-rinato.dts @@ -220,21 +220,6 @@ samsung,pll-clock-frequency = <24000000>; status = "okay"; - ports { - #address-cells = <1>; - #size-cells = <0>; - - port@1 { - reg = <1>; - - dsi_out: endpoint { - remote-endpoint = <&dsi_in>; - samsung,burst-clock-frequency = <250000000>; - samsung,esc-clock-frequency = <20000000>; - }; - }; - }; - panel@0 { compatible = "samsung,s6e63j0x03"; reg = <0>; @@ -264,12 +249,6 @@ vsync-len = <2>; }; }; - - port { - dsi_in: endpoint { - remote-endpoint = <&dsi_out>; - }; - }; }; }; diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts index 1743ca8..9452bed 100644 --- a/arch/arm/boot/dts/exynos4210-trats.dts +++ b/arch/arm/boot/dts/exynos4210-trats.dts @@ -202,21 +202,6 @@ samsung,pll-clock-frequency = <24000000>; status = "okay"; - ports { - #address-cells = <1>; - #size-cells = <0>; - - port@1 { - reg = <1>; - - dsi_out: endpoint { - remote-endpoint = <&dsi_in>; - samsung,burst-clock-frequency = <500000000>; - samsung,esc-clock-frequency = <20000000>; - }; - }; - }; - panel@0 { reg = <0>; compatible = "samsung,s6e8aa0"; @@ -244,12 +229,6 @@ vsync-len = <2>; }; }; - - port { - dsi_in: endpoint { - remote-endpoint = <&dsi_out>; - }; - }; }; }; diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts index 82221a0..86ce5e5 100644 --- a/arch/arm/boot/dts/exynos4412-trats2.dts +++ b/arch/arm/boot/dts/exynos4412-trats2.dts @@ -390,21 +390,6 @@ samsung,pll-clock-frequency = <24000000>; status = "okay"; - ports { - #address-cells = <1>; - #size-cells = <0>; - - port@1 { - reg = <1>; - - dsi_out: endpoint { - remote-endpoint = <&dsi_in>; - samsung,burst-clock-frequency = <500000000>; - samsung,esc-clock-frequency = <20000000>; - }; - }; - }; - panel@0 { compatible = "samsung,s6e8aa0"; reg = <0>; @@ -432,12 +417,6 @@ vsync-len = <2>; }; }; - - port { - dsi_in: endpoint { - remote-endpoint = <&dsi_out>; - }; - }; }; }; -- 1.9.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v4 5/5] arm: dts: Remove the OF graph from DSI node 2017-03-06 4:42 ` [PATCH v4 5/5] arm: dts: " Hoegeun Kwon @ 2017-03-06 4:50 ` Andi Shyti 0 siblings, 0 replies; 13+ messages in thread From: Andi Shyti @ 2017-03-06 4:50 UTC (permalink / raw) To: Hoegeun Kwon Cc: inki.dae, jy0922.shim, sw0312.kim, airlied, kgene, krzk, robh+dt, mark.rutland, catalin.marinas, will.deacon, javier, dri-devel, linux-arm-kernel, linux-samsung-soc, linux-kernel, devicetree Hi Hoegeun, On Mon, Mar 06, 2017 at 01:42:23PM +0900, Hoegeun Kwon wrote: > The OF graph is not needed because the panel is a child of dsi. Remove > the ports node in DSI node, and port node in panel node. > > Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com> > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> Reviewed-by: Andi Shyti <andi.shyti@samsung.com> Andi ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2017-03-06 8:38 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <CGME20170306044231epcas5p3ecbd44359ebb1eb35f8cf0b1a614afcb@epcas5p3.samsung.com> 2017-03-06 4:42 ` [PATCH v4 0/5] Fix the parse_dt of exynos dsi and remove the OF graph Hoegeun Kwon [not found] ` <CGME20170306044233epcas1p20b5e6c764a7752290e5ed25cc13a69af@epcas1p2.samsung.com> 2017-03-06 4:42 ` [PATCH v4 1/5] arm64: dts: exynos: Add the burst and esc clock frequency properties to DSI node Hoegeun Kwon 2017-03-06 4:49 ` Andi Shyti 2017-03-06 4:55 ` Hoegeun Kwon [not found] ` <CGME20170306044234epcas1p22e9481182e11330cea0d169ce0ad2666@epcas1p2.samsung.com> 2017-03-06 4:42 ` [PATCH v4 2/5] arm: dts: " Hoegeun Kwon 2017-03-06 4:49 ` Andi Shyti [not found] ` <1488775343-6236-3-git-send-email-hoegeun.kwon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2017-03-06 8:38 ` Lothar Waßmann [not found] ` <CGME20170306044236epcas5p326440b0139bee5a33fd6545d0400bb57@epcas5p3.samsung.com> 2017-03-06 4:42 ` [PATCH v4 3/5] drm/exynos: dsi: Fix the parse_dt function Hoegeun Kwon 2017-03-06 4:49 ` Andi Shyti [not found] ` <CGME20170306044237epcas5p35d955ba5e849a8ebcf13007ab1b377dc@epcas5p3.samsung.com> 2017-03-06 4:42 ` [PATCH v4 4/5] arm64: dts: exynos: Remove the OF graph from DSI node Hoegeun Kwon 2017-03-06 4:50 ` Andi Shyti [not found] ` <CGME20170306044239epcas1p2cf8ad82b218e72119af0a35af249148f@epcas1p2.samsung.com> 2017-03-06 4:42 ` [PATCH v4 5/5] arm: dts: " Hoegeun Kwon 2017-03-06 4:50 ` Andi Shyti
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).