* [PATCH] clk: samsung: gs101: drop unused HSI2 clock parent data
@ 2024-05-07 5:59 Krzysztof Kozlowski
2024-05-07 9:43 ` Peter Griffin
2024-05-07 9:49 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-05-07 5:59 UTC (permalink / raw)
To: Peter Griffin, Krzysztof Kozlowski, Sylwester Nawrocki,
Chanwoo Choi, Alim Akhtar, Michael Turquette, Stephen Boyd,
André Draszik, linux-arm-kernel, linux-samsung-soc,
linux-clk, linux-kernel
Cc: Krzysztof Kozlowski
Drop static const arrays with HSI2 clocks parent data which are not
referenced by any clock. This might cause -Werror=unused-const-variable
warnings.
Reported-by: Stephen Boyd <sboyd@kernel.org>
Closes: https://lore.kernel.org/all/8bf65df598680f0785c3d6db70acfb9a.sboyd@kernel.org/
Fixes: 093c290084a4 ("clk: samsung: gs101: add support for cmu_hsi2")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/clk/samsung/clk-gs101.c | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c
index e2a6a1992505..ba9570f7a5fa 100644
--- a/drivers/clk/samsung/clk-gs101.c
+++ b/drivers/clk/samsung/clk-gs101.c
@@ -2601,21 +2601,6 @@ static const unsigned long cmu_hsi2_clk_regs[] __initconst = {
QUEUE_CTRL_REG_BLK_HSI2_CMU_HSI2,
};
-PNAME(mout_hsi2_ufs_embd_p) = { "oscclk", "dout_cmu_shared0_div4",
- "dout_cmu_shared2_div2", "fout_spare_pll" };
-
-PNAME(mout_hsi2_pcie_p) = { "oscclk", "dout_cmu_shared2_div2" };
-
-PNAME(mout_hsi2_bus_p) = { "dout_cmu_shared0_div4",
- "dout_cmu_shared1_div4",
- "dout_cmu_shared2_div2",
- "dout_cmu_shared3_div2",
- "fout_spare_pll", "oscclk", "oscclk",
- "oscclk" };
-
-PNAME(mout_hsi2_mmc_card_p) = { "fout_shared2_pll", "fout_shared3_pll",
- "dout_cmu_shared0_div4", "fout_spare_pll" };
-
PNAME(mout_hsi2_bus_user_p) = { "oscclk", "dout_cmu_hsi2_bus" };
PNAME(mout_hsi2_mmc_card_user_p) = { "oscclk", "dout_cmu_hsi2_mmc_card" };
PNAME(mout_hsi2_pcie_user_p) = { "oscclk", "dout_cmu_hsi2_pcie" };
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: samsung: gs101: drop unused HSI2 clock parent data
2024-05-07 5:59 [PATCH] clk: samsung: gs101: drop unused HSI2 clock parent data Krzysztof Kozlowski
@ 2024-05-07 9:43 ` Peter Griffin
2024-05-07 9:49 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Peter Griffin @ 2024-05-07 9:43 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, Sylwester Nawrocki, Chanwoo Choi,
Alim Akhtar, Michael Turquette, Stephen Boyd, André Draszik,
linux-arm-kernel, linux-samsung-soc, linux-clk, linux-kernel
Hi Krzysztof,
On Tue, 7 May 2024 at 06:59, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Drop static const arrays with HSI2 clocks parent data which are not
> referenced by any clock. This might cause -Werror=unused-const-variable
> warnings.
>
> Reported-by: Stephen Boyd <sboyd@kernel.org>
> Closes: https://lore.kernel.org/all/8bf65df598680f0785c3d6db70acfb9a.sboyd@kernel.org/
> Fixes: 093c290084a4 ("clk: samsung: gs101: add support for cmu_hsi2")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Thanks for the fix! These are actually the cmu_top parents and
shouldn't be defined here. They already have their own definitions in
the cmu_top section.
Reviewed-by: Peter Griffin <peter.griffin@linaro.org>
Peter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: samsung: gs101: drop unused HSI2 clock parent data
2024-05-07 5:59 [PATCH] clk: samsung: gs101: drop unused HSI2 clock parent data Krzysztof Kozlowski
2024-05-07 9:43 ` Peter Griffin
@ 2024-05-07 9:49 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-05-07 9:49 UTC (permalink / raw)
To: Peter Griffin, Krzysztof Kozlowski, Sylwester Nawrocki,
Chanwoo Choi, Alim Akhtar, Michael Turquette, Stephen Boyd,
André Draszik, linux-arm-kernel, linux-samsung-soc,
linux-clk, linux-kernel, Krzysztof Kozlowski
On Tue, 07 May 2024 07:59:48 +0200, Krzysztof Kozlowski wrote:
> Drop static const arrays with HSI2 clocks parent data which are not
> referenced by any clock. This might cause -Werror=unused-const-variable
> warnings.
>
>
Applied, thanks!
[1/1] clk: samsung: gs101: drop unused HSI2 clock parent data
https://git.kernel.org/krzk/linux/c/7c18b0a5aa46cc7e5d3a7ef3f9f8e3aa91bb780f
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-07 9:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-07 5:59 [PATCH] clk: samsung: gs101: drop unused HSI2 clock parent data Krzysztof Kozlowski
2024-05-07 9:43 ` Peter Griffin
2024-05-07 9:49 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).