linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: samsung: exynos-audss: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-07  8:50 ` Cai Huoqing
  2021-09-07 12:27   ` Krzysztof Kozlowski
  2021-09-13 16:10   ` Sylwester Nawrocki
  0 siblings, 2 replies; 3+ messages in thread
From: Cai Huoqing @ 2021-09-07  8:50 UTC (permalink / raw)
  To: caihuoqing
  Cc: Sylwester Nawrocki, Tomasz Figa, Chanwoo Choi, Michael Turquette,
	Stephen Boyd, Krzysztof Kozlowski, linux-samsung-soc, linux-clk,
	linux-arm-kernel, linux-kernel

Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/clk/samsung/clk-exynos-audss.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clk/samsung/clk-exynos-audss.c b/drivers/clk/samsung/clk-exynos-audss.c
index 42b5d32c6cc7..9cc127a162ad 100644
--- a/drivers/clk/samsung/clk-exynos-audss.c
+++ b/drivers/clk/samsung/clk-exynos-audss.c
@@ -129,7 +129,6 @@ static int exynos_audss_clk_probe(struct platform_device *pdev)
 	struct clk *pll_ref, *pll_in, *cdclk, *sclk_audio, *sclk_pcm_in;
 	const struct exynos_audss_clk_drvdata *variant;
 	struct clk_hw **clk_table;
-	struct resource *res;
 	struct device *dev = &pdev->dev;
 	int i, ret = 0;
 
@@ -137,8 +136,7 @@ static int exynos_audss_clk_probe(struct platform_device *pdev)
 	if (!variant)
 		return -EINVAL;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	reg_base = devm_ioremap_resource(dev, res);
+	reg_base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(reg_base))
 		return PTR_ERR(reg_base);
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: samsung: exynos-audss: Make use of the helper function devm_platform_ioremap_resource()
  2021-09-07  8:50 ` [PATCH] clk: samsung: exynos-audss: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
@ 2021-09-07 12:27   ` Krzysztof Kozlowski
  2021-09-13 16:10   ` Sylwester Nawrocki
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-07 12:27 UTC (permalink / raw)
  To: Cai Huoqing
  Cc: Sylwester Nawrocki, Tomasz Figa, Chanwoo Choi, Michael Turquette,
	Stephen Boyd, linux-samsung-soc, linux-clk, linux-arm-kernel,
	linux-kernel

On 07/09/2021 10:50, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
>  drivers/clk/samsung/clk-exynos-audss.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 

Just send it as a series (git format-patch -4 HEAD), not one-by-one.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: samsung: exynos-audss: Make use of the helper function devm_platform_ioremap_resource()
  2021-09-07  8:50 ` [PATCH] clk: samsung: exynos-audss: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
  2021-09-07 12:27   ` Krzysztof Kozlowski
@ 2021-09-13 16:10   ` Sylwester Nawrocki
  1 sibling, 0 replies; 3+ messages in thread
From: Sylwester Nawrocki @ 2021-09-13 16:10 UTC (permalink / raw)
  To: Cai Huoqing
  Cc: Tomasz Figa, Chanwoo Choi, Michael Turquette, Stephen Boyd,
	Krzysztof Kozlowski, linux-samsung-soc, linux-clk,
	linux-arm-kernel, linux-kernel

On 07.09.2021 10:50, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

Thanks for the patch. I have applied it with summary line changed to 
"clk: samsung: exynos-audss: Make use of devm_platform_ioremap_resource()"
so it doesn't exceed 75 characters.

> ---
>  drivers/clk/samsung/clk-exynos-audss.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/clk/samsung/clk-exynos-audss.c b/drivers/clk/samsung/clk-exynos-audss.c
> index 42b5d32c6cc7..9cc127a162ad 100644
> --- a/drivers/clk/samsung/clk-exynos-audss.c
> +++ b/drivers/clk/samsung/clk-exynos-audss.c
> @@ -129,7 +129,6 @@ static int exynos_audss_clk_probe(struct platform_device *pdev)
>  	struct clk *pll_ref, *pll_in, *cdclk, *sclk_audio, *sclk_pcm_in;
>  	const struct exynos_audss_clk_drvdata *variant;
>  	struct clk_hw **clk_table;
> -	struct resource *res;
>  	struct device *dev = &pdev->dev;
>  	int i, ret = 0;
>  
> @@ -137,8 +136,7 @@ static int exynos_audss_clk_probe(struct platform_device *pdev)
>  	if (!variant)
>  		return -EINVAL;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	reg_base = devm_ioremap_resource(dev, res);
> +	reg_base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(reg_base))
>  		return PTR_ERR(reg_base);
-- 
Regards,
Sylwester

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-13 16:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20210907085111eucas1p12e14f7d5f4ec4cebfbde4f26e68754c3@eucas1p1.samsung.com>
2021-09-07  8:50 ` [PATCH] clk: samsung: exynos-audss: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-07 12:27   ` Krzysztof Kozlowski
2021-09-13 16:10   ` Sylwester Nawrocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).