* [PATCH] cpufreq: s3c64xx: remove incorrect __init annotation
@ 2016-12-16 9:06 Arnd Bergmann
2016-12-16 16:54 ` Krzysztof Kozlowski
2017-01-02 7:09 ` Viresh Kumar
0 siblings, 2 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-12-16 9:06 UTC (permalink / raw)
To: Viresh Kumar
Cc: linux-samsung-soc, Arnd Bergmann, linux-pm, Rafael J. Wysocki,
linux-kernel, Krzysztof Kozlowski, Javier Martinez Canillas,
Kukjin Kim, linux-arm-kernel
s3c64xx_cpufreq_config_regulator is incorrectly annotated
as __init, since the caller is also not init:
WARNING: vmlinux.o(.text+0x92fe1c): Section mismatch in reference from the function s3c64xx_cpufreq_driver_init() to the function .init.text:s3c64xx_cpufreq_config_regulator()
With modern gcc versions, the function gets inline, so we don't
see the warning, this only happens with gcc-4.6 and older.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/cpufreq/s3c64xx-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/s3c64xx-cpufreq.c b/drivers/cpufreq/s3c64xx-cpufreq.c
index 176e84cc3991..0cb9040eca49 100644
--- a/drivers/cpufreq/s3c64xx-cpufreq.c
+++ b/drivers/cpufreq/s3c64xx-cpufreq.c
@@ -107,7 +107,7 @@ static int s3c64xx_cpufreq_set_target(struct cpufreq_policy *policy,
}
#ifdef CONFIG_REGULATOR
-static void __init s3c64xx_cpufreq_config_regulator(void)
+static void s3c64xx_cpufreq_config_regulator(void)
{
int count, v, i, found;
struct cpufreq_frequency_table *freq;
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] cpufreq: s3c64xx: remove incorrect __init annotation
2016-12-16 9:06 [PATCH] cpufreq: s3c64xx: remove incorrect __init annotation Arnd Bergmann
@ 2016-12-16 16:54 ` Krzysztof Kozlowski
2017-01-02 7:09 ` Viresh Kumar
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2016-12-16 16:54 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Viresh Kumar, Kukjin Kim, Krzysztof Kozlowski,
Javier Martinez Canillas, Rafael J. Wysocki, linux-arm-kernel,
linux-samsung-soc, linux-pm, linux-kernel
On Fri, Dec 16, 2016 at 10:06:15AM +0100, Arnd Bergmann wrote:
> s3c64xx_cpufreq_config_regulator is incorrectly annotated
> as __init, since the caller is also not init:
>
> WARNING: vmlinux.o(.text+0x92fe1c): Section mismatch in reference from the function s3c64xx_cpufreq_driver_init() to the function .init.text:s3c64xx_cpufreq_config_regulator()
>
> With modern gcc versions, the function gets inline, so we don't
> see the warning, this only happens with gcc-4.6 and older.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/cpufreq/s3c64xx-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cpufreq: s3c64xx: remove incorrect __init annotation
2016-12-16 9:06 [PATCH] cpufreq: s3c64xx: remove incorrect __init annotation Arnd Bergmann
2016-12-16 16:54 ` Krzysztof Kozlowski
@ 2017-01-02 7:09 ` Viresh Kumar
2017-01-02 17:36 ` Krzysztof Kozlowski
1 sibling, 1 reply; 6+ messages in thread
From: Viresh Kumar @ 2017-01-02 7:09 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas,
Rafael J. Wysocki, linux-arm-kernel, linux-samsung-soc, linux-pm,
linux-kernel
On 16-12-16, 10:06, Arnd Bergmann wrote:
> s3c64xx_cpufreq_config_regulator is incorrectly annotated
> as __init, since the caller is also not init:
>
> WARNING: vmlinux.o(.text+0x92fe1c): Section mismatch in reference from the function s3c64xx_cpufreq_driver_init() to the function .init.text:s3c64xx_cpufreq_config_regulator()
>
> With modern gcc versions, the function gets inline, so we don't
> see the warning, this only happens with gcc-4.6 and older.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/cpufreq/s3c64xx-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/s3c64xx-cpufreq.c b/drivers/cpufreq/s3c64xx-cpufreq.c
> index 176e84cc3991..0cb9040eca49 100644
> --- a/drivers/cpufreq/s3c64xx-cpufreq.c
> +++ b/drivers/cpufreq/s3c64xx-cpufreq.c
> @@ -107,7 +107,7 @@ static int s3c64xx_cpufreq_set_target(struct cpufreq_policy *policy,
> }
>
> #ifdef CONFIG_REGULATOR
> -static void __init s3c64xx_cpufreq_config_regulator(void)
> +static void s3c64xx_cpufreq_config_regulator(void)
> {
> int count, v, i, found;
> struct cpufreq_frequency_table *freq;
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cpufreq: s3c64xx: remove incorrect __init annotation
2017-01-02 7:09 ` Viresh Kumar
@ 2017-01-02 17:36 ` Krzysztof Kozlowski
2017-01-02 21:19 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2017-01-02 17:36 UTC (permalink / raw)
To: Viresh Kumar, Rafael J. Wysocki
Cc: Arnd Bergmann, Kukjin Kim, Krzysztof Kozlowski,
Javier Martinez Canillas, linux-arm-kernel, linux-samsung-soc,
linux-pm, linux-kernel
On Mon, Jan 02, 2017 at 12:39:03PM +0530, Viresh Kumar wrote:
> On 16-12-16, 10:06, Arnd Bergmann wrote:
> > s3c64xx_cpufreq_config_regulator is incorrectly annotated
> > as __init, since the caller is also not init:
> >
> > WARNING: vmlinux.o(.text+0x92fe1c): Section mismatch in reference from the function s3c64xx_cpufreq_driver_init() to the function .init.text:s3c64xx_cpufreq_config_regulator()
> >
> > With modern gcc versions, the function gets inline, so we don't
> > see the warning, this only happens with gcc-4.6 and older.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > drivers/cpufreq/s3c64xx-cpufreq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/s3c64xx-cpufreq.c b/drivers/cpufreq/s3c64xx-cpufreq.c
> > index 176e84cc3991..0cb9040eca49 100644
> > --- a/drivers/cpufreq/s3c64xx-cpufreq.c
> > +++ b/drivers/cpufreq/s3c64xx-cpufreq.c
> > @@ -107,7 +107,7 @@ static int s3c64xx_cpufreq_set_target(struct cpufreq_policy *policy,
> > }
> >
> > #ifdef CONFIG_REGULATOR
> > -static void __init s3c64xx_cpufreq_config_regulator(void)
> > +static void s3c64xx_cpufreq_config_regulator(void)
> > {
> > int count, v, i, found;
> > struct cpufreq_frequency_table *freq;
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Rafael,
Are you going to pick it up?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cpufreq: s3c64xx: remove incorrect __init annotation
2017-01-02 17:36 ` Krzysztof Kozlowski
@ 2017-01-02 21:19 ` Rafael J. Wysocki
2017-01-03 19:20 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2017-01-02 21:19 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Linux Samsung SoC, Arnd Bergmann, Linux PM, Viresh Kumar,
Rafael J. Wysocki, Linux Kernel Mailing List,
Javier Martinez Canillas, Kukjin Kim, linux-arm-kernel
On Mon, Jan 2, 2017 at 6:36 PM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Mon, Jan 02, 2017 at 12:39:03PM +0530, Viresh Kumar wrote:
>> On 16-12-16, 10:06, Arnd Bergmann wrote:
>> > s3c64xx_cpufreq_config_regulator is incorrectly annotated
>> > as __init, since the caller is also not init:
>> >
>> > WARNING: vmlinux.o(.text+0x92fe1c): Section mismatch in reference from the function s3c64xx_cpufreq_driver_init() to the function .init.text:s3c64xx_cpufreq_config_regulator()
>> >
>> > With modern gcc versions, the function gets inline, so we don't
>> > see the warning, this only happens with gcc-4.6 and older.
>> >
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> > ---
>> > drivers/cpufreq/s3c64xx-cpufreq.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/cpufreq/s3c64xx-cpufreq.c b/drivers/cpufreq/s3c64xx-cpufreq.c
>> > index 176e84cc3991..0cb9040eca49 100644
>> > --- a/drivers/cpufreq/s3c64xx-cpufreq.c
>> > +++ b/drivers/cpufreq/s3c64xx-cpufreq.c
>> > @@ -107,7 +107,7 @@ static int s3c64xx_cpufreq_set_target(struct cpufreq_policy *policy,
>> > }
>> >
>> > #ifdef CONFIG_REGULATOR
>> > -static void __init s3c64xx_cpufreq_config_regulator(void)
>> > +static void s3c64xx_cpufreq_config_regulator(void)
>> > {
>> > int count, v, i, found;
>> > struct cpufreq_frequency_table *freq;
>>
>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Rafael,
> Are you going to pick it up?
I thought I did, didn't I?
Thanks,
Rafael
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cpufreq: s3c64xx: remove incorrect __init annotation
2017-01-02 21:19 ` Rafael J. Wysocki
@ 2017-01-03 19:20 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2017-01-03 19:20 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Krzysztof Kozlowski, Viresh Kumar, Rafael J. Wysocki,
Arnd Bergmann, Kukjin Kim, Javier Martinez Canillas,
linux-arm-kernel, Linux Samsung SoC, Linux PM,
Linux Kernel Mailing List
On Mon, Jan 02, 2017 at 10:19:29PM +0100, Rafael J. Wysocki wrote:
> On Mon, Jan 2, 2017 at 6:36 PM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > On Mon, Jan 02, 2017 at 12:39:03PM +0530, Viresh Kumar wrote:
> >> On 16-12-16, 10:06, Arnd Bergmann wrote:
> >> > s3c64xx_cpufreq_config_regulator is incorrectly annotated
> >> > as __init, since the caller is also not init:
> >> >
> >> > WARNING: vmlinux.o(.text+0x92fe1c): Section mismatch in reference from the function s3c64xx_cpufreq_driver_init() to the function .init.text:s3c64xx_cpufreq_config_regulator()
> >> >
> >> > With modern gcc versions, the function gets inline, so we don't
> >> > see the warning, this only happens with gcc-4.6 and older.
> >> >
> >> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> > ---
> >> > drivers/cpufreq/s3c64xx-cpufreq.c | 2 +-
> >> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/drivers/cpufreq/s3c64xx-cpufreq.c b/drivers/cpufreq/s3c64xx-cpufreq.c
> >> > index 176e84cc3991..0cb9040eca49 100644
> >> > --- a/drivers/cpufreq/s3c64xx-cpufreq.c
> >> > +++ b/drivers/cpufreq/s3c64xx-cpufreq.c
> >> > @@ -107,7 +107,7 @@ static int s3c64xx_cpufreq_set_target(struct cpufreq_policy *policy,
> >> > }
> >> >
> >> > #ifdef CONFIG_REGULATOR
> >> > -static void __init s3c64xx_cpufreq_config_regulator(void)
> >> > +static void s3c64xx_cpufreq_config_regulator(void)
> >> > {
> >> > int count, v, i, found;
> >> > struct cpufreq_frequency_table *freq;
> >>
> >> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
> > Rafael,
> > Are you going to pick it up?
>
> I thought I did, didn't I?
Right, you did. I missed that. Thanks!
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-01-03 19:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-16 9:06 [PATCH] cpufreq: s3c64xx: remove incorrect __init annotation Arnd Bergmann
2016-12-16 16:54 ` Krzysztof Kozlowski
2017-01-02 7:09 ` Viresh Kumar
2017-01-02 17:36 ` Krzysztof Kozlowski
2017-01-02 21:19 ` Rafael J. Wysocki
2017-01-03 19:20 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).