* [PATCH v6] dt-bindings: arm: samsung: Update the CHIPID binding for ASV
[not found] <CGME20191017092953eucas1p259c1e03eb2cb4d19aa48eaa2e3cca2dc@eucas1p2.samsung.com>
@ 2019-10-17 9:29 ` Sylwester Nawrocki
2019-10-17 14:18 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Sylwester Nawrocki @ 2019-10-17 9:29 UTC (permalink / raw)
To: robh+dt
Cc: krzk, linux-pm, linux-arm-kernel, linux-samsung-soc, devicetree,
b.zolnierkie, m.szyprowski, Sylwester Nawrocki
This patch adds documentation of new optional "samsung,asv-bin"
property in the chipid device node and documents requirement of
"syscon" compatible string. These additions are needed to support
Exynos ASV (Adaptive Supply Voltage) feature.
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
Depends on patch ("8d0daa4c89c9 dt-bindings: arm: samsung: Convert
Exynos Chipid bindings to json-schema") already applied to Rob's
dt/next.
Changes since v5:
- removed uneeded allOf from 'compatible' property section
Changes since v4:
- converted to YAML
Changes since v3:
- none
Changes since v2:
- corrected patch summary line prefix, the patch moved in the
sequence
Changes since v1 (RFC):
- new patch
---
.../bindings/arm/samsung/exynos-chipid.yaml | 26 ++++++++++++++++++-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
index 9c573ad7dc7d..c7f06aa1963c 100644
--- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
+++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
@@ -9,17 +9,41 @@ title: Samsung Exynos SoC series Chipid driver
maintainers:
- Krzysztof Kozlowski <krzk@kernel.org>
+# Custom select to avoid matching all nodes with 'syscon'
+select:
+ properties:
+ compatible:
+ contains:
+ const: samsung,exynos4210-chipid
+ required:
+ - compatible
+
properties:
compatible:
items:
- const: samsung,exynos4210-chipid
+ - const: syscon
reg:
maxItems: 1
+ samsung,asv-bin:
+ description:
+ Adaptive Supply Voltage bin selection. This can be used
+ to determine the ASV bin of an SoC if respective information
+ is missing in the CHIPID registers or in the OTP memory.
+ allOf:
+ - $ref: /schemas/types.yaml#/definitions/uint32
+ - enum: [ 0, 1, 2, 3 ]
+
+required:
+ - compatible
+ - reg
+
examples:
- |
chipid@10000000 {
- compatible = "samsung,exynos4210-chipid";
+ compatible = "samsung,exynos4210-chipid", "syscon";
reg = <0x10000000 0x100>;
+ samsung,asv-bin = <2>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v6] dt-bindings: arm: samsung: Update the CHIPID binding for ASV
2019-10-17 9:29 ` [PATCH v6] dt-bindings: arm: samsung: Update the CHIPID binding for ASV Sylwester Nawrocki
@ 2019-10-17 14:18 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2019-10-17 14:18 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: robh+dt, krzk, linux-pm, linux-arm-kernel, linux-samsung-soc,
devicetree, b.zolnierkie, m.szyprowski, Sylwester Nawrocki
On Thu, 17 Oct 2019 11:29:39 +0200, Sylwester Nawrocki wrote:
> This patch adds documentation of new optional "samsung,asv-bin"
> property in the chipid device node and documents requirement of
> "syscon" compatible string. These additions are needed to support
> Exynos ASV (Adaptive Supply Voltage) feature.
>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
> Depends on patch ("8d0daa4c89c9 dt-bindings: arm: samsung: Convert
> Exynos Chipid bindings to json-schema") already applied to Rob's
> dt/next.
>
> Changes since v5:
> - removed uneeded allOf from 'compatible' property section
>
> Changes since v4:
> - converted to YAML
>
> Changes since v3:
> - none
>
> Changes since v2:
> - corrected patch summary line prefix, the patch moved in the
> sequence
>
> Changes since v1 (RFC):
> - new patch
> ---
> .../bindings/arm/samsung/exynos-chipid.yaml | 26 ++++++++++++++++++-
> 1 file changed, 25 insertions(+), 1 deletion(-)
>
Applied, thanks.
I dropped 'select' because I fixed the tooling to ignore 'syscon'.
Rob
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-17 14:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20191017092953eucas1p259c1e03eb2cb4d19aa48eaa2e3cca2dc@eucas1p2.samsung.com>
2019-10-17 9:29 ` [PATCH v6] dt-bindings: arm: samsung: Update the CHIPID binding for ASV Sylwester Nawrocki
2019-10-17 14:18 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).