* [PATCH resend] drm/exynos: gsc: add missed component_del @ 2019-12-05 16:05 ` Chuhong Yuan 2019-12-13 4:05 ` Inki Dae 0 siblings, 1 reply; 2+ messages in thread From: Chuhong Yuan @ 2019-12-05 16:05 UTC (permalink / raw) Cc: Inki Dae, Joonyoung Shim, Seung-Woo Kim, Kyungmin Park, David Airlie, Daniel Vetter, Kukjin Kim, Krzysztof Kozlowski, dri-devel, linux-arm-kernel, linux-samsung-soc, linux-kernel, Chuhong Yuan The driver forgets to call component_del in remove to match component_add in probe. Add the missed call to fix it. Signed-off-by: Chuhong Yuan <hslester96@gmail.com> --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c index 7ae087b0504d..88b6fcaa20be 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c @@ -1313,6 +1313,7 @@ static int gsc_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; + component_del(dev, &gsc_component_ops); pm_runtime_dont_use_autosuspend(dev); pm_runtime_disable(dev); -- 2.24.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH resend] drm/exynos: gsc: add missed component_del 2019-12-05 16:05 ` [PATCH resend] drm/exynos: gsc: add missed component_del Chuhong Yuan @ 2019-12-13 4:05 ` Inki Dae 0 siblings, 0 replies; 2+ messages in thread From: Inki Dae @ 2019-12-13 4:05 UTC (permalink / raw) To: Chuhong Yuan Cc: Joonyoung Shim, Seung-Woo Kim, Kyungmin Park, David Airlie, Daniel Vetter, Kukjin Kim, Krzysztof Kozlowski, dri-devel, linux-arm-kernel, linux-samsung-soc, linux-kernel You don't need to resend this. Already merged to exynos-drm-fixes three weeks ago. Thanks, Inki Dae 19. 12. 6. 오전 1:05에 Chuhong Yuan 이(가) 쓴 글: > The driver forgets to call component_del in remove to match component_add > in probe. > Add the missed call to fix it. > > Signed-off-by: Chuhong Yuan <hslester96@gmail.com> > --- > drivers/gpu/drm/exynos/exynos_drm_gsc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c > index 7ae087b0504d..88b6fcaa20be 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c > @@ -1313,6 +1313,7 @@ static int gsc_remove(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > > + component_del(dev, &gsc_component_ops); > pm_runtime_dont_use_autosuspend(dev); > pm_runtime_disable(dev); > > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-13 4:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20191205160538epcas1p4575fbc2874d04486bc38cae3472f4b5a@epcas1p4.samsung.com>
2019-12-05 16:05 ` [PATCH resend] drm/exynos: gsc: add missed component_del Chuhong Yuan
2019-12-13 4:05 ` Inki Dae
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).