From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hyunki Koo <hyunki00.koo@gmail.com>
Cc: linux@armlinux.org.uk, kgene@kernel.org, tglx@linutronix.de,
jason@lakedaemon.net, maz@kernel.org,
linux-arm-kernel@lists.infradead.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel-team@android.com, Hyunki Koo <hyunki00.koo@samsung.com>
Subject: Re: [PATCH 1/2] irqchip: define EXYNOS_IRQ_COMBINER
Date: Mon, 9 Dec 2019 09:41:15 +0100 [thread overview]
Message-ID: <20191209084115.GA6375@pi3> (raw)
In-Reply-To: <e6c3661e-36df-5ae8-eedb-1961063bcabb@gmail.com>
On Sun, Dec 08, 2019 at 07:24:49AM +0900, Hyunki Koo wrote:
>
> On 19. 12. 7. 오후 10:37, Krzysztof Kozlowski wrote:
> > On Sat, 7 Dec 2019 at 14:28, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > > On Sat, Dec 07, 2019 at 10:00:48PM +0900, Hyunki Koo wrote:
> > > > From: Hyunki Koo <hyunki00.koo@samsung.com>
> > > >
> > > > Not all exynos device have IRQ_COMBINER.
> > > > Thus add the config for EXYNOS_IRQ_COMBINER.
> > > >
> > > > Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com>
> > > > ---
> > > > drivers/irqchip/Kconfig | 7 +++++++
> > > > drivers/irqchip/Makefile | 2 +-
> > > > 2 files changed, 8 insertions(+), 1 deletion(-)
> > > >
> > > Hi,
> > >
> > > There is no changelog and versioning of this patch so I do not
> > > understand how it differs with previous. It's a resend? v2? It brings
> > > the confusion and looks like you're ignoring previous comments.
> > >
> > > Looks the same and looks like breaking Exynos platforms in the same way.
> > >
> > > If you not want to skip combiner on ARMv8, it makes sense, then please
> > > follow the approach we did for Pinctrl drivers (PINCTRL_EXYNOS_ARM and
> > > PINCTRL_EXYNOS_ARM64).
> > >
> > > Best regards,
> > > Krzysztof
> > Ah, now I see the second patch. Still you break bisect which requires
> > specific ordering of patches or squashing them into one. Optionally
> > this could be default=y if ARCH_EXYNOS && ARM. I prefer just squashing
> > both into one patch in this case.
>
> you mean squashing two files arch/arm/mach-exynos/Kconfig and
> arch/arm/mach-exynos/Kconfig into one patch
>
> or squashing into only one file like blow?
>
> +config EXYNOS_IRQ_COMBINER
> + bool "Samsung Exynos IRQ combiner support"
> + depends on (ARCH_EXYNOS && ARM) || COMPILE_TEST
> + default y
>
> I prefer first one (squashing two files into one patch)
Squashing two patches into one.
>
> >
> > > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> > > > index ba152954324b..3ed7b7f2ae26 100644
> > > > --- a/drivers/irqchip/Kconfig
> > > > +++ b/drivers/irqchip/Kconfig
> > > > @@ -499,4 +499,11 @@ config SIFIVE_PLIC
> > > >
> > > > If you don't know what to do here, say Y.
> > > >
> > > > +config EXYNOS_IRQ_COMBINER
> > > > + bool "Samsung Exynos IRQ combiner support"
> > Now point it to be visible. Only for COMPILE_TEST
Typo from my side. I wanted to say "No point" - this should not be
selectable by user.
> >
> > > > + depends on ARCH_EXYNOS
> > Since you make it a separate option, make it COMPILE_TEST.
>
> Is this good ?
Not entirely. The bool should be also with "if COMPILE TEST" so:
config EXYNOS_IRQ_COMBINER
bool "Samsung Exynos IRQ combiner support" if COMPILE_TEST
depends on (ARCH_EXYNOS && ARM) || COMPILE_TEST
Best regards,
Krzysztof
next prev parent reply other threads:[~2019-12-09 8:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-07 13:00 [PATCH 0/2] remove direct dependancy between irq and exynos Hyunki Koo
2019-12-07 13:00 ` [PATCH 1/2] irqchip: define EXYNOS_IRQ_COMBINER Hyunki Koo
2019-12-07 13:28 ` Krzysztof Kozlowski
2019-12-07 13:37 ` Krzysztof Kozlowski
2019-12-07 22:24 ` Hyunki Koo
2019-12-09 8:41 ` Krzysztof Kozlowski [this message]
2019-12-07 13:00 ` [PATCH 2/2] ARM: exynos: add select EXYNOS_IRQ_COMBINER Hyunki Koo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209084115.GA6375@pi3 \
--to=krzk@kernel.org \
--cc=hyunki00.koo@gmail.com \
--cc=hyunki00.koo@samsung.com \
--cc=jason@lakedaemon.net \
--cc=kernel-team@android.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).