* [PATCH 06/25] pinctrl: samsung: pinctrl-samsung: Demote obvious misuse of kerneldoc to standard comment blocks
[not found] <20200713144930.1034632-1-lee.jones@linaro.org>
@ 2020-07-13 14:49 ` Lee Jones
2020-07-20 14:27 ` Krzysztof Kozlowski
2020-07-13 14:49 ` [PATCH 07/25] pinctrl: samsung: pinctrl-s3c24xx: Fix formatting issues Lee Jones
2020-07-13 14:49 ` [PATCH 08/25] pinctrl: samsung: pinctrl-s3c64xx: " Lee Jones
2 siblings, 1 reply; 13+ messages in thread
From: Lee Jones @ 2020-07-13 14:49 UTC (permalink / raw)
To: linus.walleij
Cc: linux-kernel, linux-gpio, Lee Jones, Tomasz Figa,
Krzysztof Kozlowski, Sylwester Nawrocki, Thomas Abraham,
linux-samsung-soc
No attempt has been made to document either of the demoted functions here.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/samsung/pinctrl-samsung.c:1149: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_suspend'
drivers/pinctrl/samsung/pinctrl-samsung.c:1199: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_resume'
Cc: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Thomas Abraham <thomas.ab@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
index f26574ef234ab..608eb5a07248e 100644
--- a/drivers/pinctrl/samsung/pinctrl-samsung.c
+++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
@@ -1140,7 +1140,7 @@ static int samsung_pinctrl_probe(struct platform_device *pdev)
return 0;
}
-/**
+/*
* samsung_pinctrl_suspend - save pinctrl state for suspend
*
* Save data for all banks handled by this device.
@@ -1187,7 +1187,7 @@ static int __maybe_unused samsung_pinctrl_suspend(struct device *dev)
return 0;
}
-/**
+/*
* samsung_pinctrl_resume - restore pinctrl state from suspend
*
* Restore one of the banks that was saved during suspend.
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 06/25] pinctrl: samsung: pinctrl-samsung: Demote obvious misuse of kerneldoc to standard comment blocks
2020-07-13 14:49 ` [PATCH 06/25] pinctrl: samsung: pinctrl-samsung: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
@ 2020-07-20 14:27 ` Krzysztof Kozlowski
2020-07-20 14:49 ` Lee Jones
0 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-07-20 14:27 UTC (permalink / raw)
To: Lee Jones
Cc: linus.walleij, linux-kernel, linux-gpio, Tomasz Figa,
Sylwester Nawrocki, Thomas Abraham, linux-samsung-soc
On Mon, Jul 13, 2020 at 03:49:11PM +0100, Lee Jones wrote:
> No attempt has been made to document either of the demoted functions here.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/pinctrl/samsung/pinctrl-samsung.c:1149: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_suspend'
> drivers/pinctrl/samsung/pinctrl-samsung.c:1199: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_resume'
>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Cc: Thomas Abraham <thomas.ab@samsung.com>
> Cc: linux-samsung-soc@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++--
Thanks, applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 06/25] pinctrl: samsung: pinctrl-samsung: Demote obvious misuse of kerneldoc to standard comment blocks
2020-07-20 14:27 ` Krzysztof Kozlowski
@ 2020-07-20 14:49 ` Lee Jones
2020-07-20 14:52 ` Krzysztof Kozlowski
0 siblings, 1 reply; 13+ messages in thread
From: Lee Jones @ 2020-07-20 14:49 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linus.walleij, linux-kernel, linux-gpio, Tomasz Figa,
Sylwester Nawrocki, Thomas Abraham, linux-samsung-soc
On Mon, 20 Jul 2020, Krzysztof Kozlowski wrote:
> On Mon, Jul 13, 2020 at 03:49:11PM +0100, Lee Jones wrote:
> > No attempt has been made to document either of the demoted functions here.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/pinctrl/samsung/pinctrl-samsung.c:1149: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_suspend'
> > drivers/pinctrl/samsung/pinctrl-samsung.c:1199: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_resume'
> >
> > Cc: Tomasz Figa <tomasz.figa@gmail.com>
> > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> > Cc: Thomas Abraham <thomas.ab@samsung.com>
> > Cc: linux-samsung-soc@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++--
>
> Thanks, applied.
Same as the others. Already in -next.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 06/25] pinctrl: samsung: pinctrl-samsung: Demote obvious misuse of kerneldoc to standard comment blocks
2020-07-20 14:49 ` Lee Jones
@ 2020-07-20 14:52 ` Krzysztof Kozlowski
2020-07-23 8:43 ` Linus Walleij
0 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-07-20 14:52 UTC (permalink / raw)
To: Lee Jones
Cc: linus.walleij, linux-kernel, linux-gpio, Tomasz Figa,
Sylwester Nawrocki, Thomas Abraham, linux-samsung-soc
On Mon, Jul 20, 2020 at 03:49:55PM +0100, Lee Jones wrote:
> On Mon, 20 Jul 2020, Krzysztof Kozlowski wrote:
>
> > On Mon, Jul 13, 2020 at 03:49:11PM +0100, Lee Jones wrote:
> > > No attempt has been made to document either of the demoted functions here.
> > >
> > > Fixes the following W=1 kernel build warning(s):
> > >
> > > drivers/pinctrl/samsung/pinctrl-samsung.c:1149: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_suspend'
> > > drivers/pinctrl/samsung/pinctrl-samsung.c:1199: warning: Function parameter or member 'dev' not described in 'samsung_pinctrl_resume'
> > >
> > > Cc: Tomasz Figa <tomasz.figa@gmail.com>
> > > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> > > Cc: Thomas Abraham <thomas.ab@samsung.com>
> > > Cc: linux-samsung-soc@vger.kernel.org
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > ---
> > > drivers/pinctrl/samsung/pinctrl-samsung.c | 4 ++--
> >
> > Thanks, applied.
>
> Same as the others. Already in -next.
Thanks for letting me know. I dropped all of them.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 06/25] pinctrl: samsung: pinctrl-samsung: Demote obvious misuse of kerneldoc to standard comment blocks
2020-07-20 14:52 ` Krzysztof Kozlowski
@ 2020-07-23 8:43 ` Linus Walleij
2020-07-23 8:45 ` Krzysztof Kozlowski
0 siblings, 1 reply; 13+ messages in thread
From: Linus Walleij @ 2020-07-23 8:43 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, linux-kernel, open list:GPIO SUBSYSTEM, Tomasz Figa,
Sylwester Nawrocki, Thomas Abraham, linux-samsung-soc
On Mon, Jul 20, 2020 at 4:52 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Mon, Jul 20, 2020 at 03:49:55PM +0100, Lee Jones wrote:
> > > Thanks, applied.
> >
> > Same as the others. Already in -next.
>
> Thanks for letting me know. I dropped all of them.
It's a bit tricky at times with clean-up topics, I want submaintainers to pick
it up if possible so sorry about this, it's just too much to coordinate
sometimes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 06/25] pinctrl: samsung: pinctrl-samsung: Demote obvious misuse of kerneldoc to standard comment blocks
2020-07-23 8:43 ` Linus Walleij
@ 2020-07-23 8:45 ` Krzysztof Kozlowski
0 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-07-23 8:45 UTC (permalink / raw)
To: Linus Walleij
Cc: Lee Jones, linux-kernel, open list:GPIO SUBSYSTEM, Tomasz Figa,
Sylwester Nawrocki, Thomas Abraham, linux-samsung-soc
On Thu, 23 Jul 2020 at 10:44, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Mon, Jul 20, 2020 at 4:52 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > On Mon, Jul 20, 2020 at 03:49:55PM +0100, Lee Jones wrote:
>
> > > > Thanks, applied.
> > >
> > > Same as the others. Already in -next.
> >
> > Thanks for letting me know. I dropped all of them.
>
> It's a bit tricky at times with clean-up topics, I want submaintainers to pick
> it up if possible so sorry about this, it's just too much to coordinate
> sometimes.
No worries. Recently Samsung pinctrl driver is not that active so I
could just provide you only a review. Maybe there is too much hustle
to apply to sub-maintainer tree.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 07/25] pinctrl: samsung: pinctrl-s3c24xx: Fix formatting issues
[not found] <20200713144930.1034632-1-lee.jones@linaro.org>
2020-07-13 14:49 ` [PATCH 06/25] pinctrl: samsung: pinctrl-samsung: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
@ 2020-07-13 14:49 ` Lee Jones
2020-07-14 18:30 ` Heiko Stuebner
2020-07-20 14:27 ` Krzysztof Kozlowski
2020-07-13 14:49 ` [PATCH 08/25] pinctrl: samsung: pinctrl-s3c64xx: " Lee Jones
2 siblings, 2 replies; 13+ messages in thread
From: Lee Jones @ 2020-07-13 14:49 UTC (permalink / raw)
To: linus.walleij
Cc: linux-kernel, linux-gpio, Lee Jones, Kukjin Kim,
Krzysztof Kozlowski, Tomasz Figa, Sylwester Nawrocki,
Heiko Stuebner, linux-samsung-soc
Kerneldoc struct titles must be followed by whitespace. Also attributes
need to be in the format '@.*: ' else the checker gets confused.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/samsung/pinctrl-s3c24xx.c:100: warning: cannot understand function prototype: 'struct s3c24xx_eint_domain_data '
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-samsung-soc@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
index 9bd0a3de101dd..5e24838a582f5 100644
--- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
+++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
@@ -80,7 +80,7 @@ static const struct samsung_pin_bank_type bank_type_2bit = {
}
/**
- * struct s3c24xx_eint_data: EINT common data
+ * struct s3c24xx_eint_data - EINT common data
* @drvdata: pin controller driver data
* @domains: IRQ domains of particular EINT interrupts
* @parents: mapped parent irqs in the main interrupt controller
@@ -92,10 +92,10 @@ struct s3c24xx_eint_data {
};
/**
- * struct s3c24xx_eint_domain_data: per irq-domain data
+ * struct s3c24xx_eint_domain_data - per irq-domain data
* @bank: pin bank related to the domain
* @eint_data: common data
- * eint0_3_parent_only: live eints 0-3 only in the main intc
+ * @eint0_3_parent_only: live eints 0-3 only in the main intc
*/
struct s3c24xx_eint_domain_data {
struct samsung_pin_bank *bank;
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 07/25] pinctrl: samsung: pinctrl-s3c24xx: Fix formatting issues
2020-07-13 14:49 ` [PATCH 07/25] pinctrl: samsung: pinctrl-s3c24xx: Fix formatting issues Lee Jones
@ 2020-07-14 18:30 ` Heiko Stuebner
2020-07-20 14:27 ` Krzysztof Kozlowski
1 sibling, 0 replies; 13+ messages in thread
From: Heiko Stuebner @ 2020-07-14 18:30 UTC (permalink / raw)
To: Lee Jones
Cc: linus.walleij, linux-kernel, linux-gpio, Kukjin Kim,
Krzysztof Kozlowski, Tomasz Figa, Sylwester Nawrocki,
linux-samsung-soc
Am Montag, 13. Juli 2020, 16:49:12 CEST schrieb Lee Jones:
> Kerneldoc struct titles must be followed by whitespace. Also attributes
> need to be in the format '@.*: ' else the checker gets confused.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/pinctrl/samsung/pinctrl-s3c24xx.c:100: warning: cannot understand function prototype: 'struct s3c24xx_eint_domain_data '
>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-samsung-soc@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> index 9bd0a3de101dd..5e24838a582f5 100644
> --- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> +++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> @@ -80,7 +80,7 @@ static const struct samsung_pin_bank_type bank_type_2bit = {
> }
>
> /**
> - * struct s3c24xx_eint_data: EINT common data
> + * struct s3c24xx_eint_data - EINT common data
> * @drvdata: pin controller driver data
> * @domains: IRQ domains of particular EINT interrupts
> * @parents: mapped parent irqs in the main interrupt controller
> @@ -92,10 +92,10 @@ struct s3c24xx_eint_data {
> };
>
> /**
> - * struct s3c24xx_eint_domain_data: per irq-domain data
> + * struct s3c24xx_eint_domain_data - per irq-domain data
> * @bank: pin bank related to the domain
> * @eint_data: common data
> - * eint0_3_parent_only: live eints 0-3 only in the main intc
> + * @eint0_3_parent_only: live eints 0-3 only in the main intc
> */
> struct s3c24xx_eint_domain_data {
> struct samsung_pin_bank *bank;
>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 07/25] pinctrl: samsung: pinctrl-s3c24xx: Fix formatting issues
2020-07-13 14:49 ` [PATCH 07/25] pinctrl: samsung: pinctrl-s3c24xx: Fix formatting issues Lee Jones
2020-07-14 18:30 ` Heiko Stuebner
@ 2020-07-20 14:27 ` Krzysztof Kozlowski
2020-07-20 14:49 ` Lee Jones
1 sibling, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-07-20 14:27 UTC (permalink / raw)
To: Lee Jones
Cc: linus.walleij, linux-kernel, linux-gpio, Kukjin Kim, Tomasz Figa,
Sylwester Nawrocki, Heiko Stuebner, linux-samsung-soc
On Mon, Jul 13, 2020 at 03:49:12PM +0100, Lee Jones wrote:
> Kerneldoc struct titles must be followed by whitespace. Also attributes
> need to be in the format '@.*: ' else the checker gets confused.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/pinctrl/samsung/pinctrl-s3c24xx.c:100: warning: cannot understand function prototype: 'struct s3c24xx_eint_domain_data '
>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-samsung-soc@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 +++---
Thanks, applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 07/25] pinctrl: samsung: pinctrl-s3c24xx: Fix formatting issues
2020-07-20 14:27 ` Krzysztof Kozlowski
@ 2020-07-20 14:49 ` Lee Jones
0 siblings, 0 replies; 13+ messages in thread
From: Lee Jones @ 2020-07-20 14:49 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linus.walleij, linux-kernel, linux-gpio, Kukjin Kim, Tomasz Figa,
Sylwester Nawrocki, Heiko Stuebner, linux-samsung-soc
On Mon, 20 Jul 2020, Krzysztof Kozlowski wrote:
> On Mon, Jul 13, 2020 at 03:49:12PM +0100, Lee Jones wrote:
> > Kerneldoc struct titles must be followed by whitespace. Also attributes
> > need to be in the format '@.*: ' else the checker gets confused.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/pinctrl/samsung/pinctrl-s3c24xx.c:100: warning: cannot understand function prototype: 'struct s3c24xx_eint_domain_data '
> >
> > Cc: Kukjin Kim <kgene@kernel.org>
> > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > Cc: Tomasz Figa <tomasz.figa@gmail.com>
> > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> > Cc: Heiko Stuebner <heiko@sntech.de>
> > Cc: linux-samsung-soc@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 +++---
>
> Thanks, applied.
This has already been applied and resides in -next.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 08/25] pinctrl: samsung: pinctrl-s3c64xx: Fix formatting issues
[not found] <20200713144930.1034632-1-lee.jones@linaro.org>
2020-07-13 14:49 ` [PATCH 06/25] pinctrl: samsung: pinctrl-samsung: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-13 14:49 ` [PATCH 07/25] pinctrl: samsung: pinctrl-s3c24xx: Fix formatting issues Lee Jones
@ 2020-07-13 14:49 ` Lee Jones
2020-07-20 14:28 ` Krzysztof Kozlowski
2 siblings, 1 reply; 13+ messages in thread
From: Lee Jones @ 2020-07-13 14:49 UTC (permalink / raw)
To: linus.walleij
Cc: linux-kernel, linux-gpio, Lee Jones, Tomasz Figa,
Krzysztof Kozlowski, Sylwester Nawrocki, linux-samsung-soc
Kerneldoc struct titles must be followed by whitespace else the
checker gets confused.
Fixes the following W=1 kernel build warning(s):
drivers/pinctrl/samsung/pinctrl-s3c64xx.c:212: warning: cannot understand function prototype: 'struct s3c64xx_eint0_domain_data '
Cc: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/samsung/pinctrl-s3c64xx.c b/drivers/pinctrl/samsung/pinctrl-s3c64xx.c
index f97f8179f2b1b..b8166e3fe4cef 100644
--- a/drivers/pinctrl/samsung/pinctrl-s3c64xx.c
+++ b/drivers/pinctrl/samsung/pinctrl-s3c64xx.c
@@ -193,7 +193,7 @@ static const struct samsung_pin_bank_type bank_type_2bit_alive = {
}
/**
- * struct s3c64xx_eint0_data: EINT0 common data
+ * struct s3c64xx_eint0_data - EINT0 common data
* @drvdata: pin controller driver data
* @domains: IRQ domains of particular EINT0 interrupts
* @pins: pin offsets inside of banks of particular EINT0 interrupts
@@ -205,7 +205,7 @@ struct s3c64xx_eint0_data {
};
/**
- * struct s3c64xx_eint0_domain_data: EINT0 per-domain data
+ * struct s3c64xx_eint0_domain_data - EINT0 per-domain data
* @bank: pin bank related to the domain
* @eints: EINT0 interrupts related to the domain
*/
@@ -215,7 +215,7 @@ struct s3c64xx_eint0_domain_data {
};
/**
- * struct s3c64xx_eint_gpio_data: GPIO EINT data
+ * struct s3c64xx_eint_gpio_data - GPIO EINT data
* @drvdata: pin controller driver data
* @domains: array of domains related to EINT interrupt groups
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 08/25] pinctrl: samsung: pinctrl-s3c64xx: Fix formatting issues
2020-07-13 14:49 ` [PATCH 08/25] pinctrl: samsung: pinctrl-s3c64xx: " Lee Jones
@ 2020-07-20 14:28 ` Krzysztof Kozlowski
2020-07-20 14:48 ` Lee Jones
0 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2020-07-20 14:28 UTC (permalink / raw)
To: Lee Jones
Cc: linus.walleij, linux-kernel, linux-gpio, Tomasz Figa,
Sylwester Nawrocki, linux-samsung-soc
On Mon, Jul 13, 2020 at 03:49:13PM +0100, Lee Jones wrote:
> Kerneldoc struct titles must be followed by whitespace else the
> checker gets confused.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/pinctrl/samsung/pinctrl-s3c64xx.c:212: warning: cannot understand function prototype: 'struct s3c64xx_eint0_domain_data '
>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Cc: linux-samsung-soc@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 6 +++---
Thanks, squashed with s3c24xx since these are similar issues and only
documentation is affected.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 08/25] pinctrl: samsung: pinctrl-s3c64xx: Fix formatting issues
2020-07-20 14:28 ` Krzysztof Kozlowski
@ 2020-07-20 14:48 ` Lee Jones
0 siblings, 0 replies; 13+ messages in thread
From: Lee Jones @ 2020-07-20 14:48 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linus.walleij, linux-kernel, linux-gpio, Tomasz Figa,
Sylwester Nawrocki, linux-samsung-soc
On Mon, 20 Jul 2020, Krzysztof Kozlowski wrote:
> On Mon, Jul 13, 2020 at 03:49:13PM +0100, Lee Jones wrote:
> > Kerneldoc struct titles must be followed by whitespace else the
> > checker gets confused.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/pinctrl/samsung/pinctrl-s3c64xx.c:212: warning: cannot understand function prototype: 'struct s3c64xx_eint0_domain_data '
> >
> > Cc: Tomasz Figa <tomasz.figa@gmail.com>
> > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> > Cc: linux-samsung-soc@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/pinctrl/samsung/pinctrl-s3c64xx.c | 6 +++---
>
> Thanks, squashed with s3c24xx since these are similar issues and only
> documentation is affected.
This is already in -next.
Seems like an odd decision to squash them too.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 13+ messages in thread