* [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings
@ 2020-09-08 9:39 Julia Lawall
2020-09-08 10:04 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2020-09-08 9:39 UTC (permalink / raw)
To: Brian Kim
Cc: kbuild-all, Dongjin Kim, memeka, Yang Deokgyu, Arnd Bergmann,
Greg Kroah-Hartman, Kukjin Kim, Krzysztof Kozlowski,
linux-arm-kernel, linux-samsung-soc
No need to set .owner here. The core will do it.
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Fixes: be904257f8a9 ("ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access")
CC: Brian Kim <brian.kim@hardkernel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
I received some other warnings about this file, but with no details:
>> drivers/char/exynos-gpiomem.c:231:15-18: ERROR: inst is NULL but
dereferenced.
--
>> drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by
free on line 229
tree: https://github.com/tobetter/linux odroid-5.9.y
head: 1118f1d60573bfbf1eb7ef079fa879a498ba4313
commit: be904257f8a9bd689b360fa98d3ffc85bdbeb560 [53/69] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago
exynos-gpiomem.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/char/exynos-gpiomem.c
+++ b/drivers/char/exynos-gpiomem.c
@@ -255,7 +255,6 @@ MODULE_DEVICE_TABLE(of, exynos_gpiomem_o
static struct platform_driver exynos_gpiomem_driver = {
.driver = {
.name = DRIVER_NAME,
- .owner = THIS_MODULE,
.of_match_table = exynos_gpiomem_of_match,
},
.probe = exynos_gpiomem_probe,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings
2020-09-08 9:39 [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings Julia Lawall
@ 2020-09-08 10:04 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-08 10:04 UTC (permalink / raw)
To: Julia Lawall
Cc: Brian Kim, kbuild-all, Dongjin Kim, memeka, Yang Deokgyu,
Arnd Bergmann, Greg Kroah-Hartman, Kukjin Kim, linux-arm-kernel,
linux-samsung-soc
On Tue, Sep 08, 2020 at 11:39:51AM +0200, Julia Lawall wrote:
> No need to set .owner here. The core will do it.
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Fixes: be904257f8a9 ("ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access")
> CC: Brian Kim <brian.kim@hardkernel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
Hi,
This is a downstream tree with certain non-upstreamable patches, so
nothing to do here for me.
Best regards,
Krzysztof
> ---
>
> I received some other warnings about this file, but with no details:
>
> >> drivers/char/exynos-gpiomem.c:231:15-18: ERROR: inst is NULL but
> dereferenced.
> --
> >> drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by
> free on line 229
>
>
> tree: https://github.com/tobetter/linux odroid-5.9.y
> head: 1118f1d60573bfbf1eb7ef079fa879a498ba4313
> commit: be904257f8a9bd689b360fa98d3ffc85bdbeb560 [53/69] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
> :::::: branch date: 4 hours ago
> :::::: commit date: 4 hours ago
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-08 10:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-08 9:39 [PATCH] ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings Julia Lawall
2020-09-08 10:04 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).