linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: switch atmel mxt reset gpio to active low
@ 2020-11-20 16:00 Martin Jücker
  2020-11-22 11:38 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Jücker @ 2020-11-20 16:00 UTC (permalink / raw)
  To: linux-samsung-soc; +Cc: krzk, devicetree, Martin Jücker

The reset gpio logic of the atmel driver was changed to be active low at
around the same time this device tree was accepted into the kernel.
Adjust the configuration so that the touchscreen is in a usable state.

Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
---
 arch/arm/boot/dts/exynos4412-p4note.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos4412-p4note.dtsi b/arch/arm/boot/dts/exynos4412-p4note.dtsi
index 0f8d4164a977..b2f9d5448a18 100644
--- a/arch/arm/boot/dts/exynos4412-p4note.dtsi
+++ b/arch/arm/boot/dts/exynos4412-p4note.dtsi
@@ -307,7 +307,7 @@ touchscreen@4a {
 		pinctrl-names = "default";
 		interrupt-parent = <&gpm2>;
 		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
-		reset-gpios = <&gpm0 4 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpm0 4 GPIO_ACTIVE_LOW>;
 	};
 };
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: switch atmel mxt reset gpio to active low
  2020-11-20 16:00 [PATCH] ARM: dts: switch atmel mxt reset gpio to active low Martin Jücker
@ 2020-11-22 11:38 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-22 11:38 UTC (permalink / raw)
  To: Martin Jücker; +Cc: linux-samsung-soc, devicetree

On Fri, Nov 20, 2020 at 05:00:54PM +0100, Martin Jücker wrote:
> The reset gpio logic of the atmel driver was changed to be active low at
> around the same time this device tree was accepted into the kernel.
> Adjust the configuration so that the touchscreen is in a usable state.
> 
> Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
> ---
>  arch/arm/boot/dts/exynos4412-p4note.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Please use proper subsystem prefix in the title, so "ARM: dts: exynos:".
Also capitalize names (Atmel) and acronyms (GPIO, not
gpio).

Thanks, applied.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-22 11:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-20 16:00 [PATCH] ARM: dts: switch atmel mxt reset gpio to active low Martin Jücker
2020-11-22 11:38 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).