* [PATCH v2] hwrng: exynos: Use pm_runtime_resume_and_get() to replace open coding
@ 2021-05-24 11:53 Tian Tao
2021-05-25 11:23 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tian Tao @ 2021-05-24 11:53 UTC (permalink / raw)
To: l.stelmach, krzysztof.kozlowski
Cc: linux-samsung-soc, linux-crypto, linux-arm-kernel, Tian Tao
use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
pm_runtime_put_noidle. this change is just to simplify the code, no
actual functional changes.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
v2: drop unnecessary change about if condition.
---
drivers/char/hw_random/exynos-trng.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c
index c8db62b..9cc3d54 100644
--- a/drivers/char/hw_random/exynos-trng.c
+++ b/drivers/char/hw_random/exynos-trng.c
@@ -196,10 +196,9 @@ static int __maybe_unused exynos_trng_resume(struct device *dev)
{
int ret;
- ret = pm_runtime_get_sync(dev);
+ ret = pm_runtime_resume_and_get(dev);
if (ret < 0) {
dev_err(dev, "Could not get runtime PM.\n");
- pm_runtime_put_noidle(dev);
return ret;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] hwrng: exynos: Use pm_runtime_resume_and_get() to replace open coding
2021-05-24 11:53 [PATCH v2] hwrng: exynos: Use pm_runtime_resume_and_get() to replace open coding Tian Tao
@ 2021-05-25 11:23 ` Krzysztof Kozlowski
[not found] ` <CGME20210525144338eucas1p1ffe21ffce47146203dd1f6211a0e5408@eucas1p1.samsung.com>
2021-06-03 12:29 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2021-05-25 11:23 UTC (permalink / raw)
To: Tian Tao, l.stelmach; +Cc: linux-samsung-soc, linux-crypto, linux-arm-kernel
On 24/05/2021 07:53, Tian Tao wrote:
> use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
> pm_runtime_put_noidle. this change is just to simplify the code, no
> actual functional changes.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> v2: drop unnecessary change about if condition.
> ---
> drivers/char/hw_random/exynos-trng.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] hwrng: exynos: Use pm_runtime_resume_and_get() to replace open coding
[not found] ` <CGME20210525144338eucas1p1ffe21ffce47146203dd1f6211a0e5408@eucas1p1.samsung.com>
@ 2021-05-25 14:43 ` Lukasz Stelmach
0 siblings, 0 replies; 4+ messages in thread
From: Lukasz Stelmach @ 2021-05-25 14:43 UTC (permalink / raw)
To: Tian Tao
Cc: krzysztof.kozlowski, linux-samsung-soc, linux-crypto, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]
It was <2021-05-24 pon 19:53>, when Tian Tao wrote:
> use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
> pm_runtime_put_noidle. this change is just to simplify the code, no
> actual functional changes.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> v2: drop unnecessary change about if condition.
> ---
> drivers/char/hw_random/exynos-trng.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Acked-by: Łukasz Stelmach <l.stelmach@samsung.com>
> diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c
> index c8db62b..9cc3d54 100644
> --- a/drivers/char/hw_random/exynos-trng.c
> +++ b/drivers/char/hw_random/exynos-trng.c
> @@ -196,10 +196,9 @@ static int __maybe_unused exynos_trng_resume(struct device *dev)
> {
> int ret;
>
> - ret = pm_runtime_get_sync(dev);
> + ret = pm_runtime_resume_and_get(dev);
> if (ret < 0) {
> dev_err(dev, "Could not get runtime PM.\n");
> - pm_runtime_put_noidle(dev);
> return ret;
> }
--
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] hwrng: exynos: Use pm_runtime_resume_and_get() to replace open coding
2021-05-24 11:53 [PATCH v2] hwrng: exynos: Use pm_runtime_resume_and_get() to replace open coding Tian Tao
2021-05-25 11:23 ` Krzysztof Kozlowski
[not found] ` <CGME20210525144338eucas1p1ffe21ffce47146203dd1f6211a0e5408@eucas1p1.samsung.com>
@ 2021-06-03 12:29 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2021-06-03 12:29 UTC (permalink / raw)
To: Tian Tao
Cc: l.stelmach, krzysztof.kozlowski, linux-samsung-soc, linux-crypto,
linux-arm-kernel, tiantao6
Tian Tao <tiantao6@hisilicon.com> wrote:
> use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
> pm_runtime_put_noidle. this change is just to simplify the code, no
> actual functional changes.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> v2: drop unnecessary change about if condition.
> ---
> drivers/char/hw_random/exynos-trng.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-03 12:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24 11:53 [PATCH v2] hwrng: exynos: Use pm_runtime_resume_and_get() to replace open coding Tian Tao
2021-05-25 11:23 ` Krzysztof Kozlowski
[not found] ` <CGME20210525144338eucas1p1ffe21ffce47146203dd1f6211a0e5408@eucas1p1.samsung.com>
2021-05-25 14:43 ` Lukasz Stelmach
2021-06-03 12:29 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).