[PATCH -next] drm/exynos: g2d: fix missing unlock on error in g2d_runqueue_worker()

* [PATCH -next] drm/exynos: g2d: fix missing unlock on error in g2d_runqueue_worker()
@ 2021-06-15 17:21 Wei Yongjun
  0 siblings, 0 replies; only message in thread
From: Wei Yongjun @ 2021-06-15 17:21 UTC (permalink / raw)
  To: weiyongjun1, Inki Dae, Joonyoung Shim, Seung-Woo Kim,
	Kyungmin Park, David Airlie, Daniel Vetter, Krzysztof Kozlowski
  Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, kernel-janitors,
	Hulk Robot

Add the missing unlock before return from function g2d_runqueue_worker()
in the error handling case.

Fixes: 445d3bed75de ("drm/exynos: use pm_runtime_resume_and_get()")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
index cab4d2c370a7..0ed665501ac4 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
@@ -897,13 +897,14 @@ static void g2d_runqueue_worker(struct work_struct *work)
 			ret = pm_runtime_resume_and_get(g2d->dev);
 			if (ret < 0) {
 				dev_err(g2d->dev, "failed to enable G2D device.\n");
-				return;
+				goto out;
 			}
 
 			g2d_dma_start(g2d, g2d->runqueue_node);
 		}
 	}
 
+out:
 	mutex_unlock(&g2d->runqueue_mutex);
 }
 


^ permalink raw reply related	[flat|nested] only message in thread