From: Chanho Park <chanho61.park@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Can Guo <cang@codeaurora.org>, Jaegeuk Kim <jaegeuk@kernel.org>,
Kiwoong Kim <kwmad.kim@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Christoph Hellwig <hch@infradead.org>,
Bart Van Assche <bvanassche@acm.org>,
jongmin jeong <jjmin.jeong@samsung.com>,
Gyunghoon Kwon <goodjob.kwon@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org,
Chanho Park <chanho61.park@samsung.com>
Subject: [PATCH v2 07/15] scsi: ufs: ufs-exynos: add setup_clocks callback
Date: Wed, 14 Jul 2021 16:11:23 +0900 [thread overview]
Message-ID: <20210714071131.101204-8-chanho61.park@samsung.com> (raw)
In-Reply-To: <20210714071131.101204-1-chanho61.park@samsung.com>
This patch adds setup_clocks callback to control/gate clocks by ufshcd.
To avoid calling before initialization, it needs to check whether ufs is
null or not and call it initially from pre_link callback.
Signed-off-by: Chanho Park <chanho61.park@samsung.com>
---
drivers/scsi/ufs/ufs-exynos.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/drivers/scsi/ufs/ufs-exynos.c b/drivers/scsi/ufs/ufs-exynos.c
index 78cc5bda0a1f..530dab500d11 100644
--- a/drivers/scsi/ufs/ufs-exynos.c
+++ b/drivers/scsi/ufs/ufs-exynos.c
@@ -795,6 +795,27 @@ static void exynos_ufs_config_intr(struct exynos_ufs *ufs, u32 errs, u8 index)
}
}
+static int exynos_ufs_setup_clocks(struct ufs_hba *hba, bool on,
+ enum ufs_notify_change_status status)
+{
+ struct exynos_ufs *ufs = ufshcd_get_variant(hba);
+
+ if (!ufs)
+ return 0;
+
+ if (on) {
+ if (ufs->opts & EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL)
+ exynos_ufs_disable_auto_ctrl_hcc(ufs);
+ exynos_ufs_ungate_clks(ufs);
+ } else {
+ exynos_ufs_gate_clks(ufs);
+ if (ufs->opts & EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL)
+ exynos_ufs_enable_auto_ctrl_hcc(ufs);
+ }
+
+ return 0;
+}
+
static int exynos_ufs_pre_link(struct ufs_hba *hba)
{
struct exynos_ufs *ufs = ufshcd_get_variant(hba);
@@ -813,6 +834,8 @@ static int exynos_ufs_pre_link(struct ufs_hba *hba)
exynos_ufs_config_phy_time_attr(ufs);
exynos_ufs_config_phy_cap_attr(ufs);
+ exynos_ufs_setup_clocks(hba, true, POST_CHANGE);
+
if (ufs->drv_data->pre_link)
ufs->drv_data->pre_link(ufs);
@@ -1203,6 +1226,7 @@ static struct ufs_hba_variant_ops ufs_hba_exynos_ops = {
.hce_enable_notify = exynos_ufs_hce_enable_notify,
.link_startup_notify = exynos_ufs_link_startup_notify,
.pwr_change_notify = exynos_ufs_pwr_change_notify,
+ .setup_clocks = exynos_ufs_setup_clocks,
.setup_xfer_req = exynos_ufs_specify_nexus_t_xfer_req,
.setup_task_mgmt = exynos_ufs_specify_nexus_t_tm_req,
.hibern8_notify = exynos_ufs_hibern8_notify,
--
2.32.0
next prev parent reply other threads:[~2021-07-14 7:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210714071158epcas2p1a7b98fd67b9bcaaa634e59fc224761b1@epcas2p1.samsung.com>
2021-07-14 7:11 ` [PATCH v2 00/15] introduce exynosauto v9 ufs driver Chanho Park
[not found] ` <CGME20210714071158epcas2p261e6c9157056fafca0f55aaf05cd68ef@epcas2p2.samsung.com>
2021-07-14 7:11 ` [PATCH v2 01/15] scsi: ufs: add quirk to handle broken UIC command Chanho Park
[not found] ` <CGME20210714071158epcas2p29900b577a489b760a1e67eba976fb815@epcas2p2.samsung.com>
2021-07-14 7:11 ` [PATCH v2 02/15] scsi: ufs: add quirk to enable host controller without ph configuration Chanho Park
[not found] ` <CGME20210714071159epcas2p36dc12e150a84ef4fa2516bc98169725b@epcas2p3.samsung.com>
2021-07-14 7:11 ` [PATCH v2 03/15] scsi: ufs: ufs-exynos: change pclk available max value Chanho Park
[not found] ` <CGME20210714071159epcas2p3fa23ac2a670e1c31deeac1c9332f76fe@epcas2p3.samsung.com>
2021-07-14 7:11 ` [PATCH v2 04/15] scsi: ufs: ufs-exynos: simplify drv_data retrieval Chanho Park
[not found] ` <CGME20210714071159epcas2p2ae981fb3b91b0eba23060de5de104ec0@epcas2p2.samsung.com>
2021-07-14 7:11 ` [PATCH v2 05/15] scsi: ufs: ufs-exynos: get sysreg regmap for io-coherency Chanho Park
[not found] ` <CGME20210714071159epcas2p3d39f7e5cbd9a2b8addaa496a396213af@epcas2p3.samsung.com>
2021-07-14 7:11 ` [PATCH v2 06/15] scsi: ufs: ufs-exynos: add refclkout_stop control Chanho Park
[not found] ` <CGME20210714071159epcas2p4c4eabf50abdaa46567fc5356bce8942b@epcas2p4.samsung.com>
2021-07-14 7:11 ` Chanho Park [this message]
[not found] ` <CGME20210714071159epcas2p24b7be0cad31af09bc71c608f9b03fe36@epcas2p2.samsung.com>
2021-07-14 7:11 ` [PATCH v2 08/15] scsi: ufs: ufs-exynos: correct timeout value setting registers Chanho Park
[not found] ` <CGME20210714071159epcas2p4edc8104aad36d4d7a5bedb8328c0ab39@epcas2p4.samsung.com>
2021-07-14 7:11 ` [PATCH v2 09/15] scsi: ufs: ufs-exynos: support custom version of ufs_hba_variant_ops Chanho Park
[not found] ` <CGME20210714071159epcas2p24323976939fa21a5ed44d81649b33d85@epcas2p2.samsung.com>
2021-07-14 7:11 ` [PATCH v2 10/15] scsi: ufs: ufs-exynos: add EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR option Chanho Park
[not found] ` <CGME20210714071159epcas2p176be9a1310f8de27cfb3786fe86630d6@epcas2p1.samsung.com>
2021-07-14 7:11 ` [PATCH v2 11/15] scsi: ufs: ufs-exynos: factor out priv data init Chanho Park
[not found] ` <CGME20210714071159epcas2p428292c7d0e97533de65d92a029eece93@epcas2p4.samsung.com>
2021-07-14 7:11 ` [PATCH v2 12/15] scsi: ufs: ufs-exynos: add pre/post_hce_enable drv callbacks Chanho Park
[not found] ` <CGME20210714071200epcas2p199f4f7b209e565c9a87440af319acda1@epcas2p1.samsung.com>
2021-07-14 7:11 ` [PATCH v2 13/15] scsi: ufs: ufs-exynos: support exynosauto v9 ufs driver Chanho Park
[not found] ` <CGME20210714071200epcas2p3f76e68f6bbb4755574dba2055a8130ab@epcas2p3.samsung.com>
2021-07-14 7:11 ` [PATCH v2 14/15] scsi: ufs: ufs-exynos: multi-host configuration for exynosauto Chanho Park
2021-07-26 9:08 ` Bean Huo
2021-07-26 10:40 ` Chanho Park
2021-07-26 21:58 ` Bean Huo
2021-07-27 10:14 ` Chanho Park
2021-07-27 19:36 ` Bean Huo
2021-07-28 1:39 ` Chanho Park
2021-07-29 21:10 ` Bean Huo
2021-07-26 22:06 ` Bean Huo
2021-07-27 9:05 ` Chanho Park
[not found] ` <CGME20210714071200epcas2p413ca643dc459ee75ec7e5e4f8a6c05d7@epcas2p4.samsung.com>
2021-07-14 7:11 ` [PATCH v2 15/15] scsi: ufs: ufs-exynos: introduce exynosauto v9 virtual host Chanho Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714071131.101204-8-chanho61.park@samsung.com \
--to=chanho61.park@samsung.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=goodjob.kwon@samsung.com \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=jjmin.jeong@samsung.com \
--cc=krzk@kernel.org \
--cc=kwmad.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).