From: Jagan Teki <jagan@amarulasolutions.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
Inki Dae <inki.dae@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Fancy Fang <chen.fang@nxp.com>,
Tim Harvey <tharvey@gateworks.com>,
Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
Adam Ford <aford173@gmail.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Tommaso Merciai <tommaso.merciai@amarulasolutions.com>,
Marek Vasut <marex@denx.de>
Cc: Matteo Lisi <matteo.lisi@engicam.com>,
dri-devel@lists.freedesktop.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
NXP Linux Team <linux-imx@nxp.com>,
linux-amarula <linux-amarula@amarulasolutions.com>,
Jagan Teki <jagan@amarulasolutions.com>
Subject: [PATCH v4 04/12] drm: bridge: samsung-dsim: Handle platform init via driver_data
Date: Tue, 30 Aug 2022 00:10:23 +0530 [thread overview]
Message-ID: <20220829184031.1863663-5-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20220829184031.1863663-1-jagan@amarulasolutions.com>
In order to make a common Samsung DSIM bridge driver some platform
specific glue code needs to maintain separately as it is hard to
maintain platform specific glue and conventional component_ops on
the drm bridge drivers side.
This patch is trying to support that glue code initialization based
on the DSIM_QUIRK_PLAT_DATA set from respective driver_data.
So, the platforms which enable DSIM_QUIRK_PLAT_DATA flags will handle
all platform specific initialization via samsung_dsim_plat_probe.
The platform probe is responsible to
- initialize samsung_dsim_plat_data and install hooks
- initialize component_ops
- preserve samsung_dsim structure pointer
v4:
* none
v3:
* update samsung_dsim_plat_probe return value
* add plat_data quirk to handle platform init
v2:
* fix samsung_dsim_plat_probe return pointer
v1:
* use platform_init instead of exynos_specific
* handle component_ops in glue code
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
drivers/gpu/drm/bridge/samsung-dsim.c | 16 ++++++++++++++--
include/drm/bridge/samsung-dsim.h | 5 +++++
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index 8130845750ac..76dc7687857a 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -369,6 +369,7 @@ static const struct samsung_dsim_driver_data exynos3_dsi_driver_data = {
.wait_for_reset = 1,
.num_bits_resol = 11,
.reg_values = reg_values,
+ .quirks = DSIM_QUIRK_PLAT_DATA,
};
static const struct samsung_dsim_driver_data exynos4_dsi_driver_data = {
@@ -381,6 +382,7 @@ static const struct samsung_dsim_driver_data exynos4_dsi_driver_data = {
.wait_for_reset = 1,
.num_bits_resol = 11,
.reg_values = reg_values,
+ .quirks = DSIM_QUIRK_PLAT_DATA,
};
static const struct samsung_dsim_driver_data exynos5_dsi_driver_data = {
@@ -391,6 +393,7 @@ static const struct samsung_dsim_driver_data exynos5_dsi_driver_data = {
.wait_for_reset = 1,
.num_bits_resol = 11,
.reg_values = reg_values,
+ .quirks = DSIM_QUIRK_PLAT_DATA,
};
static const struct samsung_dsim_driver_data exynos5433_dsi_driver_data = {
@@ -402,6 +405,7 @@ static const struct samsung_dsim_driver_data exynos5433_dsi_driver_data = {
.wait_for_reset = 0,
.num_bits_resol = 12,
.reg_values = exynos5433_reg_values,
+ .quirks = DSIM_QUIRK_PLAT_DATA,
};
static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = {
@@ -413,6 +417,7 @@ static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = {
.wait_for_reset = 1,
.num_bits_resol = 12,
.reg_values = exynos5422_reg_values,
+ .quirks = DSIM_QUIRK_PLAT_DATA,
};
static const struct of_device_id samsung_dsim_of_match[] = {
@@ -1609,7 +1614,11 @@ static int samsung_dsim_probe(struct platform_device *pdev)
dsi->bridge.of_node = dev->of_node;
dsi->bridge.type = DRM_MODE_CONNECTOR_DSI;
- ret = samsung_dsim_plat_probe(dsi);
+ if (dsi->driver_data->quirks & DSIM_QUIRK_PLAT_DATA)
+ ret = samsung_dsim_plat_probe(dsi);
+ else
+ ret = mipi_dsi_host_register(&dsi->dsi_host);
+
if (ret)
goto err_disable_runtime;
@@ -1627,7 +1636,10 @@ static int samsung_dsim_remove(struct platform_device *pdev)
pm_runtime_disable(&pdev->dev);
- samsung_dsim_plat_remove(dsi);
+ if (dsi->driver_data->quirks & DSIM_QUIRK_PLAT_DATA)
+ samsung_dsim_plat_remove(dsi);
+ else
+ mipi_dsi_host_unregister(&dsi->dsi_host);
return 0;
}
diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h
index 2e245bffd1b6..97fdee5ef5df 100644
--- a/include/drm/bridge/samsung-dsim.h
+++ b/include/drm/bridge/samsung-dsim.h
@@ -33,6 +33,10 @@ struct samsung_dsim_transfer {
u16 rx_done;
};
+enum samsung_dsim_quirks {
+ DSIM_QUIRK_PLAT_DATA = BIT(0),
+};
+
struct samsung_dsim_driver_data {
const unsigned int *reg_ofs;
unsigned int plltmr_reg;
@@ -43,6 +47,7 @@ struct samsung_dsim_driver_data {
unsigned int wait_for_reset;
unsigned int num_bits_resol;
const unsigned int *reg_values;
+ enum samsung_dsim_quirks quirks;
};
struct samsung_dsim_host_ops {
--
2.25.1
next prev parent reply other threads:[~2022-08-29 18:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 18:40 [PATCH v4 00/12] drm: bridge: Add Samsung MIPI DSIM bridge Jagan Teki
2022-08-29 18:40 ` [PATCH v4 01/12] drm: exynos: dsi: Restore proper bridge chain order Jagan Teki
2022-08-29 18:40 ` [PATCH v4 03/12] drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices Jagan Teki
2022-08-29 18:40 ` Jagan Teki [this message]
2022-08-29 18:40 ` [PATCH v4 05/12] drm: bridge: samsung-dsim: Mark PHY as optional Jagan Teki
2022-08-29 18:40 ` [PATCH v4 06/12] drm: bridge: samsung-dsim: Handle proper DSI host initialization Jagan Teki
2022-08-29 18:40 ` [PATCH v4 07/12] drm: bridge: samsung-dsim: Fix PLL_P (PMS_P) offset Jagan Teki
2022-08-29 19:42 ` Adam Ford
2022-09-14 8:22 ` Jagan Teki
2022-08-29 18:40 ` [PATCH v4 08/12] drm: bridge: samsung-dsim: Add atomic_check Jagan Teki
2022-08-29 18:40 ` [PATCH v4 09/12] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts Jagan Teki
2022-08-29 18:40 ` [PATCH v4 10/12] drm: bridge: samsung-dsim: Add input_bus_flags Jagan Teki
2022-08-29 18:40 ` [PATCH v4 11/12] dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support Jagan Teki
2022-08-29 18:40 ` [PATCH v4 12/12] drm: bridge: samsung-dsim: Add " Jagan Teki
[not found] ` <CGME20220829184118eucas1p2cda47fa166cafcb904800a55a5f66180@eucas1p2.samsung.com>
[not found] ` <20220829184031.1863663-3-jagan@amarulasolutions.com>
2022-09-02 10:47 ` [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver Marek Szyprowski
2022-09-05 11:24 ` Marek Szyprowski
2022-09-06 19:07 ` Jagan Teki
2022-09-07 10:04 ` Marek Szyprowski
2022-09-12 14:52 ` Frieder Schrempf
2022-09-13 17:29 ` Jagan Teki
2022-09-14 9:21 ` Marek Szyprowski
2022-09-14 9:39 ` Jagan Teki
2022-09-16 8:28 ` Marek Szyprowski
2022-09-16 10:21 ` Jagan Teki
2022-09-19 6:22 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220829184031.1863663-5-jagan@amarulasolutions.com \
--to=jagan@amarulasolutions.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=aford173@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=chen.fang@nxp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=frieder.schrempf@kontron.de \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=marex@denx.de \
--cc=matteo.lisi@engicam.com \
--cc=michael@amarulasolutions.com \
--cc=narmstrong@baylibre.com \
--cc=robert.foss@linaro.org \
--cc=sw0312.kim@samsung.com \
--cc=tharvey@gateworks.com \
--cc=tommaso.merciai@amarulasolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).