linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] samsung: Sort Makefile
@ 2023-11-08  9:01 Petr Vorel
  2023-11-09 16:38 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 7+ messages in thread
From: Petr Vorel @ 2023-11-08  9:01 UTC (permalink / raw)
  To: linux-samsung-soc; +Cc: Petr Vorel

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 drivers/clk/samsung/Makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile
index ebbeacabe88f..8a678ed05181 100644
--- a/drivers/clk/samsung/Makefile
+++ b/drivers/clk/samsung/Makefile
@@ -7,20 +7,20 @@ obj-$(CONFIG_COMMON_CLK)	+= clk.o clk-pll.o clk-cpu.o
 obj-$(CONFIG_EXYNOS_3250_COMMON_CLK)	+= clk-exynos3250.o
 obj-$(CONFIG_EXYNOS_4_COMMON_CLK)	+= clk-exynos4.o
 obj-$(CONFIG_EXYNOS_4_COMMON_CLK)	+= clk-exynos4412-isp.o
-obj-$(CONFIG_EXYNOS_5250_COMMON_CLK)	+= clk-exynos5250.o
 obj-$(CONFIG_EXYNOS_5250_COMMON_CLK)	+= clk-exynos5-subcmu.o
+obj-$(CONFIG_EXYNOS_5250_COMMON_CLK)	+= clk-exynos5250.o
 obj-$(CONFIG_EXYNOS_5260_COMMON_CLK)	+= clk-exynos5260.o
 obj-$(CONFIG_EXYNOS_5410_COMMON_CLK)	+= clk-exynos5410.o
-obj-$(CONFIG_EXYNOS_5420_COMMON_CLK)	+= clk-exynos5420.o
 obj-$(CONFIG_EXYNOS_5420_COMMON_CLK)	+= clk-exynos5-subcmu.o
-obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK)	+= clk-exynos5433.o
-obj-$(CONFIG_EXYNOS_AUDSS_CLK_CON) += clk-exynos-audss.o
-obj-$(CONFIG_EXYNOS_CLKOUT)	+= clk-exynos-clkout.o
+obj-$(CONFIG_EXYNOS_5420_COMMON_CLK)	+= clk-exynos5420.o
 obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK)	+= clk-exynos-arm64.o
+obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK)	+= clk-exynos5433.o
 obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK)	+= clk-exynos7.o
 obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK)	+= clk-exynos7885.o
 obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK)	+= clk-exynos850.o
 obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK)	+= clk-exynosautov9.o
+obj-$(CONFIG_EXYNOS_AUDSS_CLK_CON) += clk-exynos-audss.o
+obj-$(CONFIG_EXYNOS_CLKOUT)	+= clk-exynos-clkout.o
 obj-$(CONFIG_S3C64XX_COMMON_CLK)	+= clk-s3c64xx.o
 obj-$(CONFIG_S5PV210_COMMON_CLK)	+= clk-s5pv210.o clk-s5pv210-audss.o
 obj-$(CONFIG_TESLA_FSD_COMMON_CLK)	+= clk-fsd.o
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] samsung: Sort Makefile
  2023-11-08  9:01 [PATCH 1/1] samsung: Sort Makefile Petr Vorel
@ 2023-11-09 16:38 ` Krzysztof Kozlowski
  2023-11-09 16:39   ` Krzysztof Kozlowski
  2023-11-10  6:25   ` Petr Vorel
  0 siblings, 2 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-09 16:38 UTC (permalink / raw)
  To: Petr Vorel, linux-samsung-soc

On 08/11/2023 10:01, Petr Vorel wrote:
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  drivers/clk/samsung/Makefile | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] samsung: Sort Makefile
  2023-11-09 16:38 ` Krzysztof Kozlowski
@ 2023-11-09 16:39   ` Krzysztof Kozlowski
  2023-11-10  6:34     ` Petr Vorel
  2023-11-10  6:25   ` Petr Vorel
  1 sibling, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-09 16:39 UTC (permalink / raw)
  To: Petr Vorel, linux-samsung-soc

On 09/11/2023 17:38, Krzysztof Kozlowski wrote:
> On 08/11/2023 10:01, Petr Vorel wrote:
>> Signed-off-by: Petr Vorel <pvorel@suse.cz>
>> ---

You also lack commit msg explaining why doing this.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] samsung: Sort Makefile
  2023-11-09 16:38 ` Krzysztof Kozlowski
  2023-11-09 16:39   ` Krzysztof Kozlowski
@ 2023-11-10  6:25   ` Petr Vorel
  1 sibling, 0 replies; 7+ messages in thread
From: Petr Vorel @ 2023-11-10  6:25 UTC (permalink / raw)
  To: Krzysztof Kozlowski; +Cc: linux-samsung-soc

Hi Krzysztof,

> On 08/11/2023 10:01, Petr Vorel wrote:
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> >  drivers/clk/samsung/Makefile | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)

> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC (and consider --no-git-fallback argument). It might
> happen, that command when run on an older kernel, gives you outdated
> entries. Therefore please be sure you base your patches on recent Linux
> kernel.

Sure, I'll do next time.

Kind regards,
Petr

> Best regards,
> Krzysztof


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] samsung: Sort Makefile
  2023-11-09 16:39   ` Krzysztof Kozlowski
@ 2023-11-10  6:34     ` Petr Vorel
  2023-11-10  8:06       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 7+ messages in thread
From: Petr Vorel @ 2023-11-10  6:34 UTC (permalink / raw)
  To: Krzysztof Kozlowski; +Cc: linux-samsung-soc

Hi Krzysztof,

> On 09/11/2023 17:38, Krzysztof Kozlowski wrote:
> > On 08/11/2023 10:01, Petr Vorel wrote:
> >> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> >> ---

> You also lack commit msg explaining why doing this.
I'm sorry, I thought the reason is obvious - readability.

Some Makefiles are tried to be sorted (e.g. drivers/clk/qcom/Makefile),
but lots of them are not (drivers/net/Makefile). Anyway, it's up to you (and
other maintainers) to judge if it's useful or not. If considered useful, I'll
send v2.

> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching.

Ah, I'm sorry.  I did this actually (do that each time I send patch for kernel),
but I somehow overlooked "clk: ".

Kind regards,
Petr

> Best regards,
> Krzysztof


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] samsung: Sort Makefile
  2023-11-10  6:34     ` Petr Vorel
@ 2023-11-10  8:06       ` Krzysztof Kozlowski
  2023-11-10  9:46         ` Petr Vorel
  0 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-10  8:06 UTC (permalink / raw)
  To: Petr Vorel; +Cc: linux-samsung-soc

On 10/11/2023 07:34, Petr Vorel wrote:
> Hi Krzysztof,
> 
>> On 09/11/2023 17:38, Krzysztof Kozlowski wrote:
>>> On 08/11/2023 10:01, Petr Vorel wrote:
>>>> Signed-off-by: Petr Vorel <pvorel@suse.cz>
>>>> ---
> 
>> You also lack commit msg explaining why doing this.
> I'm sorry, I thought the reason is obvious - readability.
> 
> Some Makefiles are tried to be sorted (e.g. drivers/clk/qcom/Makefile),
> but lots of them are not (drivers/net/Makefile). Anyway, it's up to you (and
> other maintainers) to judge if it's useful or not. If considered useful, I'll
> send v2.
> 

The commit should come with message justifying it. It's also not clear
what do you sort - entries are sorted by Kconfig, but you move
CONFIG_EXYNOS_5250_COMMON_CLK.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] samsung: Sort Makefile
  2023-11-10  8:06       ` Krzysztof Kozlowski
@ 2023-11-10  9:46         ` Petr Vorel
  0 siblings, 0 replies; 7+ messages in thread
From: Petr Vorel @ 2023-11-10  9:46 UTC (permalink / raw)
  To: Krzysztof Kozlowski; +Cc: linux-samsung-soc

> On 10/11/2023 07:34, Petr Vorel wrote:
> > Hi Krzysztof,

> >> On 09/11/2023 17:38, Krzysztof Kozlowski wrote:
> >>> On 08/11/2023 10:01, Petr Vorel wrote:
> >>>> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> >>>> ---

> >> You also lack commit msg explaining why doing this.
> > I'm sorry, I thought the reason is obvious - readability.

> > Some Makefiles are tried to be sorted (e.g. drivers/clk/qcom/Makefile),
> > but lots of them are not (drivers/net/Makefile). Anyway, it's up to you (and
> > other maintainers) to judge if it's useful or not. If considered useful, I'll
> > send v2.


> The commit should come with message justifying it. It's also not clear
Sure.

> what do you sort - entries are sorted by Kconfig, but you move
> CONFIG_EXYNOS_5250_COMMON_CLK.

All entries are sorted, i.e. by obj-$() and then by it's entries (items behind +=).

At least CONFIG_EXYNOS_ARM64_COMMON_CLK is not sorted.

But anyway, feel free to reject this idea immediately, it's not worth of such in
depth discussion.

Kind regards,
Petr

> Best regards,
> Krzysztof


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-11-10 19:20 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-08  9:01 [PATCH 1/1] samsung: Sort Makefile Petr Vorel
2023-11-09 16:38 ` Krzysztof Kozlowski
2023-11-09 16:39   ` Krzysztof Kozlowski
2023-11-10  6:34     ` Petr Vorel
2023-11-10  8:06       ` Krzysztof Kozlowski
2023-11-10  9:46         ` Petr Vorel
2023-11-10  6:25   ` Petr Vorel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).