linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] media: platform: exynos4-is: return callee's error code rather than -ENXIO
@ 2023-11-15  8:57 Su Hui
  0 siblings, 0 replies; only message in thread
From: Su Hui @ 2023-11-15  8:57 UTC (permalink / raw)
  To: s.nawrocki, mchehab, krzysztof.kozlowski, alim.akhtar, nathan,
	ndesaulniers, trix
  Cc: Su Hui, linux-media, linux-arm-kernel, linux-samsung-soc,
	linux-kernel, llvm, kernel-janitors

Clang static analyzer complains that value stored to 'ret' is never read.
Return the callee's error code to fix this.

Signed-off-by: Su Hui <suhui@nfschina.com>
---
 drivers/media/platform/samsung/exynos4-is/fimc-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-core.c b/drivers/media/platform/samsung/exynos4-is/fimc-core.c
index 97908778e1c8..0be687b01ce5 100644
--- a/drivers/media/platform/samsung/exynos4-is/fimc-core.c
+++ b/drivers/media/platform/samsung/exynos4-is/fimc-core.c
@@ -814,7 +814,7 @@ static int fimc_clk_get(struct fimc_dev *fimc)
 	fimc_clk_put(fimc);
 	dev_err(&fimc->pdev->dev, "failed to get clock: %s\n",
 		fimc_clocks[i]);
-	return -ENXIO;
+	return ret;
 }
 
 #ifdef CONFIG_PM
-- 
2.30.2


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-11-15  8:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-15  8:57 [PATCH] media: platform: exynos4-is: return callee's error code rather than -ENXIO Su Hui

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).