linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: samsung: exynos-sysreg: gs101-peric0 requires a clock
@ 2024-01-25 14:01 André Draszik
  2024-01-25 14:01 ` [PATCH 2/2] arm64: dts: exynos: gs101: sysreg_peric1 needs " André Draszik
  0 siblings, 1 reply; 5+ messages in thread
From: André Draszik @ 2024-01-25 14:01 UTC (permalink / raw)
  To: linux-kernel, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	alim.akhtar, peter.griffin
  Cc: kernel-team, tudor.ambarus, willmcvicker, daniel.lezcano, tglx,
	devicetree, linux-arm-kernel, linux-samsung-soc

... otherwise it won't be accessible.

Update the schema to make this obvious.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 .../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml   | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
index 1794e3799f21..33d837ae4f45 100644
--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -72,6 +72,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - google,gs101-peric0-sysreg
               - samsung,exynos850-cmgp-sysreg
               - samsung,exynos850-peri-sysreg
               - samsung,exynos850-sysreg
-- 
2.43.0.429.g432eaa2c6b-goog


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] arm64: dts: exynos: gs101: sysreg_peric1 needs a clock
  2024-01-25 14:01 [PATCH 1/2] dt-bindings: samsung: exynos-sysreg: gs101-peric0 requires a clock André Draszik
@ 2024-01-25 14:01 ` André Draszik
  2024-01-25 14:06   ` [PATCH v2] arm64: dts: exynos: gs101: sysreg_peric0 " André Draszik
  2024-01-25 14:10   ` [PATCH 2/2] arm64: dts: exynos: gs101: sysreg_peric1 " André Draszik
  0 siblings, 2 replies; 5+ messages in thread
From: André Draszik @ 2024-01-25 14:01 UTC (permalink / raw)
  To: linux-kernel, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	alim.akhtar, peter.griffin
  Cc: kernel-team, tudor.ambarus, willmcvicker, daniel.lezcano, tglx,
	devicetree, linux-arm-kernel, linux-samsung-soc

Without the clock running, we can not access its registers, and now
that we have it, we should add it here so that it gets enabled as
and when needed.

Update the DTSI accordingly.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 arch/arm64/boot/dts/exynos/google/gs101.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
index 412d2866dca7..aaac04df5e65 100644
--- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
+++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
@@ -364,6 +364,7 @@ cmu_peric0: clock-controller@10800000 {
 		sysreg_peric0: syscon@10820000 {
 			compatible = "google,gs101-peric0-sysreg", "syscon";
 			reg = <0x10820000 0x10000>;
+			clocks = <&cmu_peric0 CLK_GOUT_PERIC0_SYSREG_PERIC0_PCLK>;
 		};
 
 		pinctrl_peric0: pinctrl@10840000 {
-- 
2.43.0.429.g432eaa2c6b-goog


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2] arm64: dts: exynos: gs101: sysreg_peric0 needs a clock
  2024-01-25 14:01 ` [PATCH 2/2] arm64: dts: exynos: gs101: sysreg_peric1 needs " André Draszik
@ 2024-01-25 14:06   ` André Draszik
  2024-01-25 14:10   ` [PATCH 2/2] arm64: dts: exynos: gs101: sysreg_peric1 " André Draszik
  1 sibling, 0 replies; 5+ messages in thread
From: André Draszik @ 2024-01-25 14:06 UTC (permalink / raw)
  To: linux-kernel, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	alim.akhtar, peter.griffin
  Cc: kernel-team, tudor.ambarus, willmcvicker, daniel.lezcano, tglx,
	devicetree, linux-arm-kernel, linux-samsung-soc

Without the clock running, we can not access its registers, and now
that we have it, we should add it here so that it gets enabled as
and when needed.

Update the DTSI accordingly.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 arch/arm64/boot/dts/exynos/google/gs101.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
index 412d2866dca7..aaac04df5e65 100644
--- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
+++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
@@ -364,6 +364,7 @@ cmu_peric0: clock-controller@10800000 {
 		sysreg_peric0: syscon@10820000 {
 			compatible = "google,gs101-peric0-sysreg", "syscon";
 			reg = <0x10820000 0x10000>;
+			clocks = <&cmu_peric0 CLK_GOUT_PERIC0_SYSREG_PERIC0_PCLK>;
 		};
 
 		pinctrl_peric0: pinctrl@10840000 {
-- 
2.43.0.429.g432eaa2c6b-goog


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] arm64: dts: exynos: gs101: sysreg_peric1 needs a clock
  2024-01-25 14:01 ` [PATCH 2/2] arm64: dts: exynos: gs101: sysreg_peric1 needs " André Draszik
  2024-01-25 14:06   ` [PATCH v2] arm64: dts: exynos: gs101: sysreg_peric0 " André Draszik
@ 2024-01-25 14:10   ` André Draszik
  2024-01-26 10:35     ` Krzysztof Kozlowski
  1 sibling, 1 reply; 5+ messages in thread
From: André Draszik @ 2024-01-25 14:10 UTC (permalink / raw)
  To: linux-kernel, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	alim.akhtar, peter.griffin
  Cc: kernel-team, tudor.ambarus, willmcvicker, daniel.lezcano, tglx,
	devicetree, linux-arm-kernel, linux-samsung-soc

> [PATCH v2] arm64: dts: exynos: gs101: sysreg_peric0 needs a clock

Sorry for copy/paste error in the subject :-(

I've sent an update in https://lore.kernel.org/all/20240125140644.3617587-1-andre.draszik@linaro.org/

Cheers,
Andre'



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] arm64: dts: exynos: gs101: sysreg_peric1 needs a clock
  2024-01-25 14:10   ` [PATCH 2/2] arm64: dts: exynos: gs101: sysreg_peric1 " André Draszik
@ 2024-01-26 10:35     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-26 10:35 UTC (permalink / raw)
  To: André Draszik, linux-kernel, robh+dt,
	krzysztof.kozlowski+dt, conor+dt, alim.akhtar, peter.griffin
  Cc: kernel-team, tudor.ambarus, willmcvicker, daniel.lezcano, tglx,
	devicetree, linux-arm-kernel, linux-samsung-soc

On 25/01/2024 15:10, André Draszik wrote:
>> [PATCH v2] arm64: dts: exynos: gs101: sysreg_peric0 needs a clock
> 
> Sorry for copy/paste error in the subject :-(
> 
> I've sent an update in https://lore.kernel.org/all/20240125140644.3617587-1-andre.draszik@linaro.org/

Which makes it impossible to apply (at least with usual workflow):

Grabbing thread from
lore.kernel.org/all/20240125140139.3616119-1-andre.draszik@linaro.org/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 4 messages in the thread
Will use the latest revision: v2
You can pick other revisions using the -vN flag
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH v2] arm64: dts: exynos: gs101: sysreg_peric0 needs a clock
    + Link:
https://lore.kernel.org/r/20240125140644.3617587-1-andre.draszik@linaro.org
    + Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  ---
  ✓ Signed: DKIM/linaro.org
---
Total patches: 1
---
Applying: arm64: dts: exynos: gs101: sysreg_peric0 needs a clock
---
Patchwork: setting state on patchwork.kernel.org/linux-samsung-soc
 -> under-review : [v2] arm64: dts: exynos: gs101: sysreg_peric0 needs a
clock

Please do not invent your own workflows of handling patches. Each
submission must be:
1. In separate thread, not linked to something else,
2. Complete.

I await for v3.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-01-26 10:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-25 14:01 [PATCH 1/2] dt-bindings: samsung: exynos-sysreg: gs101-peric0 requires a clock André Draszik
2024-01-25 14:01 ` [PATCH 2/2] arm64: dts: exynos: gs101: sysreg_peric1 needs " André Draszik
2024-01-25 14:06   ` [PATCH v2] arm64: dts: exynos: gs101: sysreg_peric0 " André Draszik
2024-01-25 14:10   ` [PATCH 2/2] arm64: dts: exynos: gs101: sysreg_peric1 " André Draszik
2024-01-26 10:35     ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).