From: Kishon Vijay Abraham I <kishon@ti.com>
To: Jaehoon Chung <jh80.chung@samsung.com>, linux-kernel@vger.kernel.org
Cc: krzk@kernel.org, kgene@kernel.org, javier@osg.samsung.com,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] phy: phy-exynos-pcie: fix the wrong error return
Date: Thu, 9 Mar 2017 13:43:47 +0530 [thread overview]
Message-ID: <58C10EBB.1030107@ti.com> (raw)
In-Reply-To: <20170308082242.15915-1-jh80.chung@samsung.com>
On Wednesday 08 March 2017 01:52 PM, Jaehoon Chung wrote:
> When it doesn't get the blk_base's resource, it was returned
> the error about phy_base, not blk_base.
> This patch is for fixing the wrong error return about blk_base.
>
> Fixes: cf0adb8e281b ("phy: phy-exynos-pcie: Add support for Exynos PCIe PHY")
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
merged, thanks.
-Kishon
> ---
> drivers/phy/phy-exynos-pcie.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/phy-exynos-pcie.c b/drivers/phy/phy-exynos-pcie.c
> index 4f60b83..60baf25 100644
> --- a/drivers/phy/phy-exynos-pcie.c
> +++ b/drivers/phy/phy-exynos-pcie.c
> @@ -254,8 +254,8 @@ static int exynos_pcie_phy_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> exynos_phy->blk_base = devm_ioremap_resource(dev, res);
> - if (IS_ERR(exynos_phy->phy_base))
> - return PTR_ERR(exynos_phy->phy_base);
> + if (IS_ERR(exynos_phy->blk_base))
> + return PTR_ERR(exynos_phy->blk_base);
>
> exynos_phy->drv_data = drv_data;
>
>
prev parent reply other threads:[~2017-03-09 8:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170308082244epcas1p4e6509812a97b0bc9912b3deb296bae38@epcas1p4.samsung.com>
2017-03-08 8:22 ` [PATCH] phy: phy-exynos-pcie: fix the wrong error return Jaehoon Chung
2017-03-09 8:13 ` Kishon Vijay Abraham I [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58C10EBB.1030107@ti.com \
--to=kishon@ti.com \
--cc=javier@osg.samsung.com \
--cc=jh80.chung@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).