linux-samsung-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] phy: phy-exynos-pcie: fix the wrong error return
       [not found] <CGME20170308082244epcas1p4e6509812a97b0bc9912b3deb296bae38@epcas1p4.samsung.com>
@ 2017-03-08  8:22 ` Jaehoon Chung
  2017-03-09  8:13   ` Kishon Vijay Abraham I
  0 siblings, 1 reply; 2+ messages in thread
From: Jaehoon Chung @ 2017-03-08  8:22 UTC (permalink / raw)
  To: linux-kernel
  Cc: kishon, krzk, kgene, javier, linux-samsung-soc, Jaehoon Chung

When it doesn't get the blk_base's resource, it was returned
the error about phy_base, not blk_base.
This patch is for fixing the wrong error return about blk_base.

Fixes: cf0adb8e281b ("phy: phy-exynos-pcie: Add support for Exynos PCIe PHY")

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
 drivers/phy/phy-exynos-pcie.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/phy-exynos-pcie.c b/drivers/phy/phy-exynos-pcie.c
index 4f60b83..60baf25 100644
--- a/drivers/phy/phy-exynos-pcie.c
+++ b/drivers/phy/phy-exynos-pcie.c
@@ -254,8 +254,8 @@ static int exynos_pcie_phy_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
 	exynos_phy->blk_base = devm_ioremap_resource(dev, res);
-	if (IS_ERR(exynos_phy->phy_base))
-		return PTR_ERR(exynos_phy->phy_base);
+	if (IS_ERR(exynos_phy->blk_base))
+		return PTR_ERR(exynos_phy->blk_base);
 
 	exynos_phy->drv_data = drv_data;
 
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] phy: phy-exynos-pcie: fix the wrong error return
  2017-03-08  8:22 ` [PATCH] phy: phy-exynos-pcie: fix the wrong error return Jaehoon Chung
@ 2017-03-09  8:13   ` Kishon Vijay Abraham I
  0 siblings, 0 replies; 2+ messages in thread
From: Kishon Vijay Abraham I @ 2017-03-09  8:13 UTC (permalink / raw)
  To: Jaehoon Chung, linux-kernel; +Cc: krzk, kgene, javier, linux-samsung-soc



On Wednesday 08 March 2017 01:52 PM, Jaehoon Chung wrote:
> When it doesn't get the blk_base's resource, it was returned
> the error about phy_base, not blk_base.
> This patch is for fixing the wrong error return about blk_base.
> 
> Fixes: cf0adb8e281b ("phy: phy-exynos-pcie: Add support for Exynos PCIe PHY")
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>

merged, thanks.

-Kishon
> ---
>  drivers/phy/phy-exynos-pcie.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/phy-exynos-pcie.c b/drivers/phy/phy-exynos-pcie.c
> index 4f60b83..60baf25 100644
> --- a/drivers/phy/phy-exynos-pcie.c
> +++ b/drivers/phy/phy-exynos-pcie.c
> @@ -254,8 +254,8 @@ static int exynos_pcie_phy_probe(struct platform_device *pdev)
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>  	exynos_phy->blk_base = devm_ioremap_resource(dev, res);
> -	if (IS_ERR(exynos_phy->phy_base))
> -		return PTR_ERR(exynos_phy->phy_base);
> +	if (IS_ERR(exynos_phy->blk_base))
> +		return PTR_ERR(exynos_phy->blk_base);
>  
>  	exynos_phy->drv_data = drv_data;
>  
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-03-09  8:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20170308082244epcas1p4e6509812a97b0bc9912b3deb296bae38@epcas1p4.samsung.com>
2017-03-08  8:22 ` [PATCH] phy: phy-exynos-pcie: fix the wrong error return Jaehoon Chung
2017-03-09  8:13   ` Kishon Vijay Abraham I

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).