* [PATCH] PM / devfreq: exynos: Use of_property_present() for testing DT property presence
@ 2023-03-10 14:47 Rob Herring
2023-03-13 10:39 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2023-03-10 14:47 UTC (permalink / raw)
To: Chanwoo Choi, MyungJoo Ham, Kyungmin Park, Krzysztof Kozlowski,
Alim Akhtar
Cc: devicetree, linux-pm, linux-samsung-soc, linux-arm-kernel, linux-kernel
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/devfreq/exynos-bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
index 027e8f336acc..d341876e7b62 100644
--- a/drivers/devfreq/exynos-bus.c
+++ b/drivers/devfreq/exynos-bus.c
@@ -432,7 +432,7 @@ static int exynos_bus_probe(struct platform_device *pdev)
goto err;
/* Create child platform device for the interconnect provider */
- if (of_get_property(dev->of_node, "#interconnect-cells", NULL)) {
+ if (of_property_present(dev->of_node, "#interconnect-cells")) {
bus->icc_pdev = platform_device_register_data(
dev, "exynos-generic-icc",
PLATFORM_DEVID_AUTO, NULL, 0);
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PM / devfreq: exynos: Use of_property_present() for testing DT property presence
2023-03-10 14:47 [PATCH] PM / devfreq: exynos: Use of_property_present() for testing DT property presence Rob Herring
@ 2023-03-13 10:39 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2023-03-13 10:39 UTC (permalink / raw)
To: Rob Herring, Chanwoo Choi, MyungJoo Ham, Kyungmin Park,
Krzysztof Kozlowski, Alim Akhtar
Cc: devicetree, linux-pm, linux-samsung-soc, linux-arm-kernel, linux-kernel
On 23. 3. 10. 23:47, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/devfreq/exynos-bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
> index 027e8f336acc..d341876e7b62 100644
> --- a/drivers/devfreq/exynos-bus.c
> +++ b/drivers/devfreq/exynos-bus.c
> @@ -432,7 +432,7 @@ static int exynos_bus_probe(struct platform_device *pdev)
> goto err;
>
> /* Create child platform device for the interconnect provider */
> - if (of_get_property(dev->of_node, "#interconnect-cells", NULL)) {
> + if (of_property_present(dev->of_node, "#interconnect-cells")) {
> bus->icc_pdev = platform_device_register_data(
> dev, "exynos-generic-icc",
> PLATFORM_DEVID_AUTO, NULL, 0);
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-13 10:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-10 14:47 [PATCH] PM / devfreq: exynos: Use of_property_present() for testing DT property presence Rob Herring
2023-03-13 10:39 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).